* Re: + stack-corruption-detector.patch added to -mm tree
[not found] <200603082041.k28Kf7H1027435@shell0.pdx.osdl.net>
@ 2006-03-09 3:16 ` Rik van Riel
2006-03-19 18:26 ` Matt Mackall
0 siblings, 1 reply; 4+ messages in thread
From: Rik van Riel @ 2006-03-09 3:16 UTC (permalink / raw)
To: linux-kernel; +Cc: mingo, Andrew Morton
On Wed, 8 Mar 2006, akpm@osdl.org wrote:
> - memset(ret, 0, THREAD_SIZE); \
> + memset(ret, 0x55, THREAD_SIZE); \
Xen uses 0x55 as a poison pattern too. I wonder if we should
change this one (this one's newer ;)) to something else.
--
All Rights Reversed
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: + stack-corruption-detector.patch added to -mm tree
2006-03-09 3:16 ` + stack-corruption-detector.patch added to -mm tree Rik van Riel
@ 2006-03-19 18:26 ` Matt Mackall
2006-03-19 20:06 ` Arjan van de Ven
0 siblings, 1 reply; 4+ messages in thread
From: Matt Mackall @ 2006-03-19 18:26 UTC (permalink / raw)
To: Rik van Riel; +Cc: linux-kernel, mingo, Andrew Morton
On Wed, Mar 08, 2006 at 10:16:50PM -0500, Rik van Riel wrote:
> On Wed, 8 Mar 2006, akpm@osdl.org wrote:
>
> > - memset(ret, 0, THREAD_SIZE); \
> > + memset(ret, 0x55, THREAD_SIZE); \
>
> Xen uses 0x55 as a poison pattern too. I wonder if we should
> change this one (this one's newer ;)) to something else.
I think we should have a central poison.h file.
--
Mathematics is the supreme nostalgia of our time.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: + stack-corruption-detector.patch added to -mm tree
2006-03-19 18:26 ` Matt Mackall
@ 2006-03-19 20:06 ` Arjan van de Ven
2006-03-19 20:52 ` Matt Mackall
0 siblings, 1 reply; 4+ messages in thread
From: Arjan van de Ven @ 2006-03-19 20:06 UTC (permalink / raw)
To: Matt Mackall; +Cc: Rik van Riel, linux-kernel, mingo, Andrew Morton
On Sun, 2006-03-19 at 12:26 -0600, Matt Mackall wrote:
> On Wed, Mar 08, 2006 at 10:16:50PM -0500, Rik van Riel wrote:
> > On Wed, 8 Mar 2006, akpm@osdl.org wrote:
> >
> > > - memset(ret, 0, THREAD_SIZE); \
> > > + memset(ret, 0x55, THREAD_SIZE); \
> >
> > Xen uses 0x55 as a poison pattern too. I wonder if we should
> > change this one (this one's newer ;)) to something else.
>
> I think we should have a central poison.h file.
sure
but it's not like xen is anywhere near mergable, so xen should change if
anything ;)
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: + stack-corruption-detector.patch added to -mm tree
2006-03-19 20:06 ` Arjan van de Ven
@ 2006-03-19 20:52 ` Matt Mackall
0 siblings, 0 replies; 4+ messages in thread
From: Matt Mackall @ 2006-03-19 20:52 UTC (permalink / raw)
To: Arjan van de Ven; +Cc: Rik van Riel, linux-kernel, mingo, Andrew Morton
On Sun, Mar 19, 2006 at 09:06:46PM +0100, Arjan van de Ven wrote:
> On Sun, 2006-03-19 at 12:26 -0600, Matt Mackall wrote:
> > On Wed, Mar 08, 2006 at 10:16:50PM -0500, Rik van Riel wrote:
> > > On Wed, 8 Mar 2006, akpm@osdl.org wrote:
> > >
> > > > - memset(ret, 0, THREAD_SIZE); \
> > > > + memset(ret, 0x55, THREAD_SIZE); \
> > >
> > > Xen uses 0x55 as a poison pattern too. I wonder if we should
> > > change this one (this one's newer ;)) to something else.
> >
> > I think we should have a central poison.h file.
>
> sure
>
> but it's not like xen is anywhere near mergable, so xen should change if
> anything ;)
Well Xen is a separate problem. But figuring out what poison value
came from where and which values are already used is getting to be an
ugly problem for the kernel itself.
--
Mathematics is the supreme nostalgia of our time.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2006-03-19 21:03 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <200603082041.k28Kf7H1027435@shell0.pdx.osdl.net>
2006-03-09 3:16 ` + stack-corruption-detector.patch added to -mm tree Rik van Riel
2006-03-19 18:26 ` Matt Mackall
2006-03-19 20:06 ` Arjan van de Ven
2006-03-19 20:52 ` Matt Mackall
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).