From: Linus Torvalds <torvalds@osdl.org>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: Oops in ufs_fill_super at mount time
Date: Thu, 12 Jan 2006 17:14:25 -0800 (PST) [thread overview]
Message-ID: <Pine.LNX.4.64.0601121700041.3535@g5.osdl.org> (raw)
In-Reply-To: <20060113005450.GA7971@mipter.zuzino.mipt.ru>
On Fri, 13 Jan 2006, Alexey Dobriyan wrote:
>
> Version 2.6.15-43ecb9a33ba8c93ebbda81d48ca05f0d1bbf9056
>
> Actually more or less latest -git is affected too, but
> I'm sick of recompiling right now so please wait for bisecting results.
Hmm.. I don't see any recent changes that could affect this. Not after
2.6.15, but in fact not even after 2.6.14.
Your oops is also interesting in another way...
> Unable to handle kernel paging request at virtual address d734c158
> printing eip:
> c019f138
> *pde = 0005c067
> *pte = 1734c000
> Oops: 0000 [#1]
> PREEMPT DEBUG_PAGEALLOC
This is a free'd page fault, so it's due to DEBUG_PAGEALLOC rather than a
wild pointer.
Is that something new for you? Maybe the bug is older, but you've enabled
PAGEALLOC only recently? Also, out of interest, have you enabled slab
debugging?
That said, the whole ubh_get_usb_second() and ubh_get_usb_third() thing is
pretty damn scary. There's no testing of the values passed in at all and
comparing them to the allocated buffer heads. But from what I can tell,
ubh_bread_uspi() will zero out any unallocated bh's, and it certainly
_looks_ like the calculations to calculate "usb2" should fit within the
sectors that were read..
Very strange.
Linus
next prev parent reply other threads:[~2006-01-13 1:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-13 0:54 Oops in ufs_fill_super at mount time Alexey Dobriyan
2006-01-13 1:14 ` Linus Torvalds [this message]
2006-01-13 10:21 ` Alexey Dobriyan
2006-01-13 15:45 ` Linus Torvalds
2006-01-13 16:36 ` Alexey Dobriyan
2006-01-13 19:05 ` [PATCH 2.6.15] ufs cleanup Evgeniy
2006-01-13 19:51 ` Linus Torvalds
2006-01-14 8:42 ` [PATCH 2.6.15] ufs cleanup v. 2 Evgeniy
2006-01-13 15:12 ` [PATCH 2.6.15] Re: Oops in ufs_fill_super at mount time Evgeniy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0601121700041.3535@g5.osdl.org \
--to=torvalds@osdl.org \
--cc=adobriyan@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).