From: Linus Torvalds <torvalds@osdl.org>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-fsdevel@vger.kernel.org, Evgeniy <dushistov@mail.ru>
Subject: Re: Oops in ufs_fill_super at mount time
Date: Fri, 13 Jan 2006 07:45:12 -0800 (PST) [thread overview]
Message-ID: <Pine.LNX.4.64.0601130739540.3535@g5.osdl.org> (raw)
In-Reply-To: <20060113102136.GA7868@mipter.zuzino.mipt.ru>
On Fri, 13 Jan 2006, Alexey Dobriyan wrote:
> On Thu, Jan 12, 2006 at 05:14:25PM -0800, Linus Torvalds wrote:
> >
> > This is a free'd page fault, so it's due to DEBUG_PAGEALLOC rather than a
> > wild pointer.
>
> That's true. Turning it off makes mounting reliable again.
>
> > Is that something new for you? Maybe the bug is older, but you've enabled
> > PAGEALLOC only recently?
>
> Yup. In response to hangs re disk activity.
Ok, That explains why it started happening for you only _now_, but not why
it happens in the first place.
Can you test if the patch that Evgeniy sent out fixes it for you even with
PAGEALLOC debugging enabled?
Evgeniy - That is one ugly macro, can you (or Alexey, for that matter:
somebody who can test it) turn it into an inline function or something to
make it half-way readable? I realize that means changing the arguments too
(right now that horrid macro accesses "uspi" directly - uggghhh).
If somebody maintains - or is interested in doing so - UFS, please speak
up, we don't have anybody listed in the MAINTAINERS file, and when I look
through the history, all I see is updates due to secondary issues (ie
somebody did generic cleanups and just happened to touch UFS as part of
that, rather than working _directly_ on UFS issues).
Linus
next prev parent reply other threads:[~2006-01-13 15:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-13 0:54 Oops in ufs_fill_super at mount time Alexey Dobriyan
2006-01-13 1:14 ` Linus Torvalds
2006-01-13 10:21 ` Alexey Dobriyan
2006-01-13 15:45 ` Linus Torvalds [this message]
2006-01-13 16:36 ` Alexey Dobriyan
2006-01-13 19:05 ` [PATCH 2.6.15] ufs cleanup Evgeniy
2006-01-13 19:51 ` Linus Torvalds
2006-01-14 8:42 ` [PATCH 2.6.15] ufs cleanup v. 2 Evgeniy
2006-01-13 15:12 ` [PATCH 2.6.15] Re: Oops in ufs_fill_super at mount time Evgeniy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0601130739540.3535@g5.osdl.org \
--to=torvalds@osdl.org \
--cc=adobriyan@gmail.com \
--cc=dushistov@mail.ru \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).