* [patch 1/1] selinux: fix bug in security_compute_sid
@ 2006-07-25 14:13 Stephen Smalley
2006-07-25 14:44 ` James Morris
0 siblings, 1 reply; 2+ messages in thread
From: Stephen Smalley @ 2006-07-25 14:13 UTC (permalink / raw)
To: Venkat Yekkirala, lkml, James Morris, Andrew Morton
From: Venkat Yekkirala <vyekkirala@trustedcs.com>
Initializes newcontext sooner to allow for its destruction in all cases.
Please apply for 2.6.18.
Signed-off-by: Venkat Yekkirala <vyekkirala@TrustedCS.com>
Signed-off-by: Stephen Smalley <sds@tycho.nsa.gov>
---
security/selinux/ss/services.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff -X /home/sds/dontdiff -rup linux-2.6.18-rc2-git2/security/selinux/ss/services.c linux-2.6.18-rc2-git2-x/security/selinux/ss/services.c
--- linux-2.6.18-rc2-git2/security/selinux/ss/services.c 2006-07-24 11:25:49.000000000 -0400
+++ linux-2.6.18-rc2-git2-x/security/selinux/ss/services.c 2006-07-25 08:11:58.000000000 -0400
@@ -833,6 +833,8 @@ static int security_compute_sid(u32 ssid
goto out;
}
+ context_init(&newcontext);
+
POLICY_RDLOCK;
scontext = sidtab_search(&sidtab, ssid);
@@ -850,8 +852,6 @@ static int security_compute_sid(u32 ssid
goto out_unlock;
}
- context_init(&newcontext);
-
/* Set the user identity. */
switch (specified) {
case AVTAB_TRANSITION:
--
Stephen Smalley
National Security Agency
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [patch 1/1] selinux: fix bug in security_compute_sid
2006-07-25 14:13 [patch 1/1] selinux: fix bug in security_compute_sid Stephen Smalley
@ 2006-07-25 14:44 ` James Morris
0 siblings, 0 replies; 2+ messages in thread
From: James Morris @ 2006-07-25 14:44 UTC (permalink / raw)
To: Stephen Smalley; +Cc: Venkat Yekkirala, lkml, Andrew Morton
On Tue, 25 Jul 2006, Stephen Smalley wrote:
> From: Venkat Yekkirala <vyekkirala@trustedcs.com>
>
> Initializes newcontext sooner to allow for its destruction in all cases.
> Please apply for 2.6.18.
>
> Signed-off-by: Venkat Yekkirala <vyekkirala@TrustedCS.com>
> Signed-off-by: Stephen Smalley <sds@tycho.nsa.gov>
Acked-by: James Morris <jmorris@namei.org>
--
James Morris
<jmorris@namei.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-07-25 14:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-07-25 14:13 [patch 1/1] selinux: fix bug in security_compute_sid Stephen Smalley
2006-07-25 14:44 ` James Morris
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).