* [PATCH 2/3] Fix use of skb after netif_rx
@ 2007-12-09 20:03 Julia Lawall
2007-12-11 1:17 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Julia Lawall @ 2007-12-09 20:03 UTC (permalink / raw)
To: chris, wangchen, linux-kernel, kernel-janitors
From: Julia Lawall <julia@diku.dk>
Recently, Wang Chen submitted a patch
(d30f53aeb31d453a5230f526bea592af07944564) to move a call to netif_rx(skb)
after a subsequent reference to skb, because netif_rx may call kfree_skb on
its argument. The same problem occurs in some other drivers as well.
This was found using the following semantic match.
(http://www.emn.fr/x-info/coccinelle/)
// <smpl>
@@
expression skb, e,e1;
@@
(
netif_rx(skb);
|
netif_rx_ni(skb);
)
... when != skb = e
(
skb = e1
|
* skb
)
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
---
diff a/arch/xtensa/platform-iss/network.c b/arch/xtensa/platform-iss/network.c
--- a/arch/xtensa/platform-iss/network.c 2007-10-22 16:31:51.000000000 +0200
+++ b/arch/xtensa/platform-iss/network.c 2007-12-05 19:01:34.000000000 +0100
@@ -393,11 +393,11 @@ static int iss_net_rx(struct net_device
if (pkt_len > 0) {
skb_trim(skb, pkt_len);
skb->protocol = lp->tp.protocol(skb);
- // netif_rx(skb);
- netif_rx_ni(skb);
lp->stats.rx_bytes += skb->len;
lp->stats.rx_packets++;
+ // netif_rx(skb);
+ netif_rx_ni(skb);
return pkt_len;
}
kfree_skb(skb);
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 2/3] Fix use of skb after netif_rx
2007-12-09 20:03 [PATCH 2/3] Fix use of skb after netif_rx Julia Lawall
@ 2007-12-11 1:17 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2007-12-11 1:17 UTC (permalink / raw)
To: julia; +Cc: chris, wangchen, linux-kernel, kernel-janitors
From: Julia Lawall <julia@diku.dk>
Date: Sun, 9 Dec 2007 21:03:55 +0100 (CET)
> From: Julia Lawall <julia@diku.dk>
>
> Recently, Wang Chen submitted a patch
> (d30f53aeb31d453a5230f526bea592af07944564) to move a call to netif_rx(skb)
> after a subsequent reference to skb, because netif_rx may call kfree_skb on
> its argument. The same problem occurs in some other drivers as well.
>
> This was found using the following semantic match.
> (http://www.emn.fr/x-info/coccinelle/)
...
> Signed-off-by: Julia Lawall <julia@diku.dk>
Also applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-12-11 1:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-12-09 20:03 [PATCH 2/3] Fix use of skb after netif_rx Julia Lawall
2007-12-11 1:17 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).