* [PATCH] fix build error when no swap
@ 2008-07-26 12:22 Yoichi Yuasa
2008-07-26 17:11 ` Hugh Dickins
0 siblings, 1 reply; 2+ messages in thread
From: Yoichi Yuasa @ 2008-07-26 12:22 UTC (permalink / raw)
To: Andrew Morton; +Cc: yoichi_yuasa, Linux Kernel Mailing List
When CONFIG_SWAP is not set, I got the following error.
In file included from include/asm/tlb.h:21,
from fs/exec.c:55:
include/asm-generic/tlb.h: In function 'tlb_flush_mmu':
include/asm-generic/tlb.h:76: error: implicit declaration of function 'release_pages'
include/asm-generic/tlb.h: In function 'tlb_remove_page':
include/asm-generic/tlb.h:105: error: implicit declaration of function 'page_cache_release'
make[1]: *** [fs/exec.o] Error 1
Signed-off-by: Yoichi Yuasa <yoichi_yuasa@tripeaks.co.jp>
diff -pruN -X /home/yuasa/Memo/dontdiff linux-orig/include/linux/swap.h linux/include/linux/swap.h
--- linux-orig/include/linux/swap.h 2008-07-26 17:27:22.651869820 +0900
+++ linux/include/linux/swap.h 2008-07-26 18:36:46.406531575 +0900
@@ -7,6 +7,7 @@
#include <linux/list.h>
#include <linux/memcontrol.h>
#include <linux/sched.h>
+#include <linux/pagemap.h>
#include <asm/atomic.h>
#include <asm/page.h>
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] fix build error when no swap
2008-07-26 12:22 [PATCH] fix build error when no swap Yoichi Yuasa
@ 2008-07-26 17:11 ` Hugh Dickins
0 siblings, 0 replies; 2+ messages in thread
From: Hugh Dickins @ 2008-07-26 17:11 UTC (permalink / raw)
To: Yoichi Yuasa; +Cc: Andrew Morton, Linux Kernel Mailing List
On Sat, 26 Jul 2008, Yoichi Yuasa wrote:
> When CONFIG_SWAP is not set, I got the following error.
>
> In file included from include/asm/tlb.h:21,
> from fs/exec.c:55:
> include/asm-generic/tlb.h: In function 'tlb_flush_mmu':
> include/asm-generic/tlb.h:76: error: implicit declaration of function 'release_pages'
> include/asm-generic/tlb.h: In function 'tlb_remove_page':
> include/asm-generic/tlb.h:105: error: implicit declaration of function 'page_cache_release'
> make[1]: *** [fs/exec.o] Error 1
Urgrrh, that'll be my fault: sorry, I've caused nothing but trouble
with my little remove-a-few-unneeded #includes from exec.c.
I honestly believed I'd tested !CONFIG_SWAP.
>
> Signed-off-by: Yoichi Yuasa <yoichi_yuasa@tripeaks.co.jp>
>
> diff -pruN -X /home/yuasa/Memo/dontdiff linux-orig/include/linux/swap.h linux/include/linux/swap.h
> --- linux-orig/include/linux/swap.h 2008-07-26 17:27:22.651869820 +0900
> +++ linux/include/linux/swap.h 2008-07-26 18:36:46.406531575 +0900
> @@ -7,6 +7,7 @@
> #include <linux/list.h>
> #include <linux/memcontrol.h>
> #include <linux/sched.h>
> +#include <linux/pagemap.h>
>
> #include <asm/atomic.h>
> #include <asm/page.h>
There's actually a comment further down saying that sparc cannot
include pagemap.h in swap.h, so I think your patch will probably
cause some other build trouble on sparc.
I'd be more inclined to include pagemap.h back in exec.c, as it
was before I interfered, or see if there's another "obviously safe"
(haha) solution.
Please give me a little while to wander through the maze, thanks.
Hugh
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-07-26 17:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-07-26 12:22 [PATCH] fix build error when no swap Yoichi Yuasa
2008-07-26 17:11 ` Hugh Dickins
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).