* [PATCH 2/42] arch/mips/kernel: Adjust confusing if indentation
@ 2010-08-05 20:17 Julia Lawall
2010-08-06 16:10 ` Ralf Baechle
0 siblings, 1 reply; 2+ messages in thread
From: Julia Lawall @ 2010-08-05 20:17 UTC (permalink / raw)
To: Ralf Baechle, linux-mips, linux-kernel, kernel-janitors
From: Julia Lawall <julia@diku.dk>
Indent the branch of an if.
The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@r disable braces4@
position p1,p2;
statement S1,S2;
@@
(
if (...) { ... }
|
if (...) S1@p1 S2@p2
)
@script:python@
p1 << r.p1;
p2 << r.p2;
@@
if (p1[0].column == p2[0].column):
cocci.print_main("branch",p1)
cocci.print_secs("after",p2)
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
---
arch/mips/kernel/kspd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/mips/kernel/kspd.c b/arch/mips/kernel/kspd.c
index 80e2ba6..29811f0 100644
--- a/arch/mips/kernel/kspd.c
+++ b/arch/mips/kernel/kspd.c
@@ -251,7 +251,7 @@ void sp_work_handle_request(void)
memset(&tz, 0, sizeof(tz));
if ((ret.retval = sp_syscall(__NR_gettimeofday, (int)&tv,
(int)&tz, 0, 0)) == 0)
- ret.retval = tv.tv_sec;
+ ret.retval = tv.tv_sec;
break;
case MTSP_SYSCALL_EXIT:
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 2/42] arch/mips/kernel: Adjust confusing if indentation
2010-08-05 20:17 [PATCH 2/42] arch/mips/kernel: Adjust confusing if indentation Julia Lawall
@ 2010-08-06 16:10 ` Ralf Baechle
0 siblings, 0 replies; 2+ messages in thread
From: Ralf Baechle @ 2010-08-06 16:10 UTC (permalink / raw)
To: Julia Lawall; +Cc: linux-mips, linux-kernel, kernel-janitors
Applied. Thanks Julia,
Ralf
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-08-06 16:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-08-05 20:17 [PATCH 2/42] arch/mips/kernel: Adjust confusing if indentation Julia Lawall
2010-08-06 16:10 ` Ralf Baechle
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).