* [PATCH 6/42] drivers/scsi: Adjust confusing if indentation
@ 2010-08-05 20:18 Julia Lawall
0 siblings, 0 replies; only message in thread
From: Julia Lawall @ 2010-08-05 20:18 UTC (permalink / raw)
To: Willem Riede, James E.J. Bottomley, osst-users, linux-scsi,
linux-kernel, kernel-janitors
From: Julia Lawall <julia@diku.dk>
Indent the branch of an if.
The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@r disable braces4@
position p1,p2;
statement S1,S2;
@@
(
if (...) { ... }
|
if (...) S1@p1 S2@p2
)
@script:python@
p1 << r.p1;
p2 << r.p2;
@@
if (p1[0].column == p2[0].column):
cocci.print_main("branch",p1)
cocci.print_secs("after",p2)
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
---
drivers/scsi/osst.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/osst.c b/drivers/scsi/osst.c
index d64b717..f974c10 100644
--- a/drivers/scsi/osst.c
+++ b/drivers/scsi/osst.c
@@ -4694,7 +4694,7 @@ static int __os_scsi_tape_open(struct inode * inode, struct file * filp)
STp->timeout, MAX_RETRIES, 1);
if ((SRpnt->sense[0] & 0x70) != 0x70 ||
(SRpnt->sense[2] & 0x0f) == NOT_READY)
- break;
+ break;
if ((SRpnt->sense[2] & 0x0f) == UNIT_ATTENTION) {
STp->pos_unknown = 0;
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2010-08-05 20:18 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-08-05 20:18 [PATCH 6/42] drivers/scsi: Adjust confusing if indentation Julia Lawall
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).