* [PATCH 7/42] net/atm: Adjust confusing if indentation
@ 2010-08-05 20:19 Julia Lawall
2010-08-17 8:49 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Julia Lawall @ 2010-08-05 20:19 UTC (permalink / raw)
To: David S. Miller, linux-kernel, netdev, kernel-janitors
From: Julia Lawall <julia@diku.dk>
Outdent the code following an if.
The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@r disable braces4@
position p1,p2;
statement S1,S2;
@@
(
if (...) { ... }
|
if (...) S1@p1 S2@p2
)
@script:python@
p1 << r.p1;
p2 << r.p2;
@@
if (p1[0].column == p2[0].column):
cocci.print_main("branch",p1)
cocci.print_secs("after",p2)
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
---
net/atm/common.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/atm/common.c b/net/atm/common.c
index 940404a..1b9c52a 100644
--- a/net/atm/common.c
+++ b/net/atm/common.c
@@ -792,7 +792,7 @@ int vcc_getsockopt(struct socket *sock, int level, int optname,
default:
if (level == SOL_SOCKET)
return -EINVAL;
- break;
+ break;
}
if (!vcc->dev || !vcc->dev->ops->getsockopt)
return -EINVAL;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 7/42] net/atm: Adjust confusing if indentation
2010-08-05 20:19 [PATCH 7/42] net/atm: Adjust confusing if indentation Julia Lawall
@ 2010-08-17 8:49 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2010-08-17 8:49 UTC (permalink / raw)
To: julia; +Cc: linux-kernel, netdev, kernel-janitors
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-08-17 8:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-08-05 20:19 [PATCH 7/42] net/atm: Adjust confusing if indentation Julia Lawall
2010-08-17 8:49 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).