* [PATCH 29/42] drivers/scsi: Adjust confusing if indentation
@ 2010-08-05 20:25 Julia Lawall
0 siblings, 0 replies; only message in thread
From: Julia Lawall @ 2010-08-05 20:25 UTC (permalink / raw)
To: Kai Mäkisara, Willem Riede, James E.J. Bottomley,
linux-scsi, osst-users, linux-kernel, kernel-janitors
From: Julia Lawall <julia@diku.dk>
Outdent the code following the if.
The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@r disable braces4@
position p1,p2;
statement S1,S2;
@@
(
if (...) { ... }
|
if (...) S1@p1 S2@p2
)
@script:python@
p1 << r.p1;
p2 << r.p2;
@@
if (p1[0].column == p2[0].column):
cocci.print_main("branch",p1)
cocci.print_secs("after",p2)
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
---
This patch doesn't change the semantics of the code. But it might not be
what is intended.
drivers/scsi/st.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/scsi/st.c b/drivers/scsi/st.c
index 24211d0..9c57a50 100644
--- a/drivers/scsi/st.c
+++ b/drivers/scsi/st.c
@@ -4166,9 +4166,9 @@ out_free_tape:
if (STm->cdevs[j]) {
if (cdev == STm->cdevs[j])
cdev = NULL;
- device_destroy(st_sysfs_class,
- MKDEV(SCSI_TAPE_MAJOR,
- TAPE_MINOR(i, mode, j)));
+ device_destroy(st_sysfs_class,
+ MKDEV(SCSI_TAPE_MAJOR,
+ TAPE_MINOR(i, mode, j)));
cdev_del(STm->cdevs[j]);
}
}
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2010-08-05 20:25 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-08-05 20:25 [PATCH 29/42] drivers/scsi: Adjust confusing if indentation Julia Lawall
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).