* [PATCH 31/42] drivers/net: Adjust confusing if indentation
@ 2010-08-05 20:26 Julia Lawall
2010-08-17 8:49 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Julia Lawall @ 2010-08-05 20:26 UTC (permalink / raw)
To: Grant Likely, netdev, linux-kernel, devicetree-discuss, kernel-janitors
From: Julia Lawall <julia@diku.dk>
Outdent the code following the if.
The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@r disable braces4@
position p1,p2;
statement S1,S2;
@@
(
if (...) { ... }
|
if (...) S1@p1 S2@p2
)
@script:python@
p1 << r.p1;
p2 << r.p2;
@@
if (p1[0].column == p2[0].column):
cocci.print_main("branch",p1)
cocci.print_secs("after",p2)
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
---
drivers/net/gianfar.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/gianfar.c b/drivers/net/gianfar.c
index a1b6301..36ccc37 100644
--- a/drivers/net/gianfar.c
+++ b/drivers/net/gianfar.c
@@ -1859,7 +1859,7 @@ static int register_grp_irqs(struct gfar_priv_grp *grp)
printk(KERN_ERR "%s: Can't get IRQ %d\n",
dev->name, grp->interruptError);
- goto err_irq_fail;
+ goto err_irq_fail;
}
if ((err = request_irq(grp->interruptTransmit, gfar_transmit,
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 31/42] drivers/net: Adjust confusing if indentation
2010-08-05 20:26 [PATCH 31/42] drivers/net: Adjust confusing if indentation Julia Lawall
@ 2010-08-17 8:49 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2010-08-17 8:49 UTC (permalink / raw)
To: julia
Cc: grant.likely, netdev, linux-kernel, devicetree-discuss, kernel-janitors
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-08-17 8:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-08-05 20:26 [PATCH 31/42] drivers/net: Adjust confusing if indentation Julia Lawall
2010-08-17 8:49 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).