* [PATCH 38/42] drivers/net: Adjust confusing if indentation
@ 2010-08-05 20:28 Julia Lawall
2010-08-17 8:49 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Julia Lawall @ 2010-08-05 20:28 UTC (permalink / raw)
To: Florian Fainelli, netdev, linux-kernel, kernel-janitors
From: Julia Lawall <julia@diku.dk>
Outdent the code following the if.
The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@r disable braces4@
position p1,p2;
statement S1,S2;
@@
(
if (...) { ... }
|
if (...) S1@p1 S2@p2
)
@script:python@
p1 << r.p1;
p2 << r.p2;
@@
if (p1[0].column == p2[0].column):
cocci.print_main("branch",p1)
cocci.print_secs("after",p2)
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
---
drivers/net/cpmac.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/cpmac.c b/drivers/net/cpmac.c
index e1f6156..ac3985c 100644
--- a/drivers/net/cpmac.c
+++ b/drivers/net/cpmac.c
@@ -506,7 +506,7 @@ static int cpmac_poll(struct napi_struct *napi, int budget)
"restart rx from a descriptor that's "
"not free: %p\n",
priv->dev->name, restart);
- goto fatal_error;
+ goto fatal_error;
}
cpmac_write(priv->regs, CPMAC_RX_PTR(0), restart->mapping);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 38/42] drivers/net: Adjust confusing if indentation
2010-08-05 20:28 [PATCH 38/42] drivers/net: Adjust confusing if indentation Julia Lawall
@ 2010-08-17 8:49 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2010-08-17 8:49 UTC (permalink / raw)
To: julia; +Cc: florian, netdev, linux-kernel, kernel-janitors
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-08-17 8:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-08-05 20:28 [PATCH 38/42] drivers/net: Adjust confusing if indentation Julia Lawall
2010-08-17 8:49 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).