[PATCH] cpufreq: cpufreq-cpu0: use the exact frequency for clk_set_rate()

[PATCH] cpufreq: cpufreq-cpu0: use the exact frequency for clk_set_rate()

[Guennadi Liakhovetski]

clk_set_rate() isn't supposed to accept approximate frequencies, instead
a supported frequency should be obtained from clk_round_rate() and then
used to set the clock.

Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
---

Applies on top of my previous patch to fix unsigned freq_Hz "cpufreq: fix 
sign check of an unsigned variable in cpufreq-cpu0"

 drivers/cpufreq/cpufreq-cpu0.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/cpufreq/cpufreq-cpu0.c b/drivers/cpufreq/cpufreq-cpu0.c
index e7bad3c..6ce9b51 100644
--- a/drivers/cpufreq/cpufreq-cpu0.c
+++ b/drivers/cpufreq/cpufreq-cpu0.c
@@ -45,7 +45,7 @@ static int cpu0_set_target(struct cpufreq_policy *policy,
 	struct cpufreq_freqs freqs;
 	struct opp *opp;
 	unsigned long volt = 0, volt_old = 0, tol = 0;
-	long freq_Hz;
+	long freq_Hz, freq_exact;
 	unsigned int index, cpu;
 	int ret;
 
@@ -60,6 +60,7 @@ static int cpu0_set_target(struct cpufreq_policy *policy,
 	freq_Hz = clk_round_rate(cpu_clk, freq_table[index].frequency * 1000);
 	if (freq_Hz < 0)
 		freq_Hz = freq_table[index].frequency * 1000;
+	freq_exact = freq_Hz;
 	freqs.new = freq_Hz / 1000;
 	freqs.old = clk_get_rate(cpu_clk) / 1000;
 
@@ -96,7 +97,7 @@ static int cpu0_set_target(struct cpufreq_policy *policy,
 		}
 	}
 
-	ret = clk_set_rate(cpu_clk, freqs.new * 1000);
+	ret = clk_set_rate(cpu_clk, freq_exact);
 	if (ret) {
 		pr_err("failed to set clock rate: %d\n", ret);
 		if (cpu_reg)
-- 
1.7.2.5

Re: [PATCH] cpufreq: cpufreq-cpu0: use the exact frequency for clk_set_rate()

[Guennadi Liakhovetski]

Hi Shawn

On Mon, 25 Feb 2013, Guennadi Liakhovetski wrote:

> clk_set_rate() isn't supposed to accept approximate frequencies, instead
> a supported frequency should be obtained from clk_round_rate() and then
> used to set the clock.
> 
> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>

Can I have your ack for this one, please?

Thanks
Guennadi

> ---
> 
> Applies on top of my previous patch to fix unsigned freq_Hz "cpufreq: fix 
> sign check of an unsigned variable in cpufreq-cpu0"
> 
>  drivers/cpufreq/cpufreq-cpu0.c |    5 +++--
>  1 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/cpufreq/cpufreq-cpu0.c b/drivers/cpufreq/cpufreq-cpu0.c
> index e7bad3c..6ce9b51 100644
> --- a/drivers/cpufreq/cpufreq-cpu0.c
> +++ b/drivers/cpufreq/cpufreq-cpu0.c
> @@ -45,7 +45,7 @@ static int cpu0_set_target(struct cpufreq_policy *policy,
>  	struct cpufreq_freqs freqs;
>  	struct opp *opp;
>  	unsigned long volt = 0, volt_old = 0, tol = 0;
> -	long freq_Hz;
> +	long freq_Hz, freq_exact;
>  	unsigned int index, cpu;
>  	int ret;
>  
> @@ -60,6 +60,7 @@ static int cpu0_set_target(struct cpufreq_policy *policy,
>  	freq_Hz = clk_round_rate(cpu_clk, freq_table[index].frequency * 1000);
>  	if (freq_Hz < 0)
>  		freq_Hz = freq_table[index].frequency * 1000;
> +	freq_exact = freq_Hz;
>  	freqs.new = freq_Hz / 1000;
>  	freqs.old = clk_get_rate(cpu_clk) / 1000;
>  
> @@ -96,7 +97,7 @@ static int cpu0_set_target(struct cpufreq_policy *policy,
>  		}
>  	}
>  
> -	ret = clk_set_rate(cpu_clk, freqs.new * 1000);
> +	ret = clk_set_rate(cpu_clk, freq_exact);
>  	if (ret) {
>  		pr_err("failed to set clock rate: %d\n", ret);
>  		if (cpu_reg)
> -- 
> 1.7.2.5
> 
> 

---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/

Re: [PATCH] cpufreq: cpufreq-cpu0: use the exact frequency for clk_set_rate()

[Shawn Guo]

On Wed, Mar 27, 2013 at 11:46:38PM +0100, Guennadi Liakhovetski wrote:
> Hi Shawn
> 
> On Mon, 25 Feb 2013, Guennadi Liakhovetski wrote:
> 
> > clk_set_rate() isn't supposed to accept approximate frequencies, instead
> > a supported frequency should be obtained from clk_round_rate() and then
> > used to set the clock.
> > 
> > Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
> 
> Can I have your ack for this one, please?

Acked-by: Shawn Guo <shawn.guo@linaro.org>

Re: [PATCH] cpufreq: cpufreq-cpu0: use the exact frequency for clk_set_rate()

[Viresh Kumar]

On Mon, Feb 25, 2013 at 10:52 PM, Guennadi Liakhovetski
<g.liakhovetski@gmx.de> wrote:
> clk_set_rate() isn't supposed to accept approximate frequencies, instead
> a supported frequency should be obtained from clk_round_rate() and then
> used to set the clock.
>
> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
> ---
>
> Applies on top of my previous patch to fix unsigned freq_Hz "cpufreq: fix
> sign check of an unsigned variable in cpufreq-cpu0"
>
>  drivers/cpufreq/cpufreq-cpu0.c |    5 +++--
>  1 files changed, 3 insertions(+), 2 deletions(-)

Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

Re: [PATCH] cpufreq: cpufreq-cpu0: use the exact frequency for clk_set_rate()

[Guennadi Liakhovetski]

Hi Rafael

I don't see this patch in your cpufreq branch nor in next or Linus' trees, 
has it been pulled yet?

Thanks
Guennadi

On Thu, 28 Mar 2013, Shawn Guo wrote:

> On Wed, Mar 27, 2013 at 11:46:38PM +0100, Guennadi Liakhovetski wrote:
> > Hi Shawn
> > 
> > On Mon, 25 Feb 2013, Guennadi Liakhovetski wrote:
> > 
> > > clk_set_rate() isn't supposed to accept approximate frequencies, instead
> > > a supported frequency should be obtained from clk_round_rate() and then
> > > used to set the clock.
> > > 
> > > Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
> > 
> > Can I have your ack for this one, please?
> 
> Acked-by: Shawn Guo <shawn.guo@linaro.org>
> 

---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/

Re: [PATCH] cpufreq: cpufreq-cpu0: use the exact frequency for clk_set_rate()

[Rafael J. Wysocki]

On Wednesday, May 22, 2013 08:12:22 PM Guennadi Liakhovetski wrote:
> Hi Rafael
> 
> I don't see this patch in your cpufreq branch nor in next or Linus' trees, 
> has it been pulled yet?

No, I haven't applied it yet, not sure why exactly.

In the future it's better to CC cpufreq patches to linux-pm@vger.kernel.org so
that the kernel.org Patchwork can pick them up.  I'm much less likely to
overlook them then.

This is a fix, so do we need it in 3.10-rc?

Rafael


> On Thu, 28 Mar 2013, Shawn Guo wrote:
> 
> > On Wed, Mar 27, 2013 at 11:46:38PM +0100, Guennadi Liakhovetski wrote:
> > > Hi Shawn
> > > 
> > > On Mon, 25 Feb 2013, Guennadi Liakhovetski wrote:
> > > 
> > > > clk_set_rate() isn't supposed to accept approximate frequencies, instead
> > > > a supported frequency should be obtained from clk_round_rate() and then
> > > > used to set the clock.
> > > > 
> > > > Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
> > > 
> > > Can I have your ack for this one, please?
> > 
> > Acked-by: Shawn Guo <shawn.guo@linaro.org>
> > 
> 
> ---
> Guennadi Liakhovetski, Ph.D.
> Freelance Open-Source Software Developer
> http://www.open-technology.de/
-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.

Re: [PATCH] cpufreq: cpufreq-cpu0: use the exact frequency for clk_set_rate()

[Guennadi Liakhovetski]

Hi Rafael

On Wed, 22 May 2013, Rafael J. Wysocki wrote:

> On Wednesday, May 22, 2013 08:12:22 PM Guennadi Liakhovetski wrote:
> > Hi Rafael
> > 
> > I don't see this patch in your cpufreq branch nor in next or Linus' trees, 
> > has it been pulled yet?
> 
> No, I haven't applied it yet, not sure why exactly.
> 
> In the future it's better to CC cpufreq patches to linux-pm@vger.kernel.org so
> that the kernel.org Patchwork can pick them up.  I'm much less likely to
> overlook them then.
> 
> This is a fix, so do we need it in 3.10-rc?

Would be good, yes.

Thanks
Guennadi

> 
> Rafael
> 
> 
> > On Thu, 28 Mar 2013, Shawn Guo wrote:
> > 
> > > On Wed, Mar 27, 2013 at 11:46:38PM +0100, Guennadi Liakhovetski wrote:
> > > > Hi Shawn
> > > > 
> > > > On Mon, 25 Feb 2013, Guennadi Liakhovetski wrote:
> > > > 
> > > > > clk_set_rate() isn't supposed to accept approximate frequencies, instead
> > > > > a supported frequency should be obtained from clk_round_rate() and then
> > > > > used to set the clock.
> > > > > 
> > > > > Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
> > > > 
> > > > Can I have your ack for this one, please?
> > > 
> > > Acked-by: Shawn Guo <shawn.guo@linaro.org>

---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/

Re: [PATCH] cpufreq: cpufreq-cpu0: use the exact frequency for clk_set_rate()

[Rafael J. Wysocki]

On Wednesday, June 05, 2013 01:25:37 PM Guennadi Liakhovetski wrote:
> Hi Rafael
> 
> On Wed, 22 May 2013, Rafael J. Wysocki wrote:
> 
> > On Wednesday, May 22, 2013 08:12:22 PM Guennadi Liakhovetski wrote:
> > > Hi Rafael
> > > 
> > > I don't see this patch in your cpufreq branch nor in next or Linus' trees, 
> > > has it been pulled yet?
> > 
> > No, I haven't applied it yet, not sure why exactly.
> > 
> > In the future it's better to CC cpufreq patches to linux-pm@vger.kernel.org so
> > that the kernel.org Patchwork can pick them up.  I'm much less likely to
> > overlook them then.
> > 
> > This is a fix, so do we need it in 3.10-rc?
> 
> Would be good, yes.

OK, queued up for 3.10.

Thanks,
Rafael


> > > On Thu, 28 Mar 2013, Shawn Guo wrote:
> > > 
> > > > On Wed, Mar 27, 2013 at 11:46:38PM +0100, Guennadi Liakhovetski wrote:
> > > > > Hi Shawn
> > > > > 
> > > > > On Mon, 25 Feb 2013, Guennadi Liakhovetski wrote:
> > > > > 
> > > > > > clk_set_rate() isn't supposed to accept approximate frequencies, instead
> > > > > > a supported frequency should be obtained from clk_round_rate() and then
> > > > > > used to set the clock.
> > > > > > 
> > > > > > Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
> > > > > 
> > > > > Can I have your ack for this one, please?
> > > > 
> > > > Acked-by: Shawn Guo <shawn.guo@linaro.org>
> 
> ---
> Guennadi Liakhovetski, Ph.D.
> Freelance Open-Source Software Developer
> http://www.open-technology.de/
-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.