From: Javier Achirica <achirica@telefonica.net>
To: Daniel Ritz <daniel.ritz@gmx.ch>
Cc: Jeff Garzik <jgarzik@pobox.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-net <linux-net@vger.kernel.org>,
Jean Tourrilhes <jt@bougret.hpl.hp.com>,
Mike Kershaw <dragorn@melchior.nerv-un.net>
Subject: Re: [PATCH 2.5] fixes for airo.c
Date: Mon, 21 Jul 2003 13:00:54 +0200 (MEST) [thread overview]
Message-ID: <Pine.SOL.4.30.0307211252190.25549-100000@tudela.mad.ttd.net> (raw)
In-Reply-To: <200307180015.16687.daniel.ritz@gmx.ch>
Daniel,
Thank you for your patch. Some comments about it:
- I'd rather fix whatever is broken in the current code than going back to
spinlocks, as they increase latency and reduce concurrency. In any case,
please check your code. I've seen a spinlock in the interrupt handler that
may lock the system.
- The fix for the transmit code you mention, is about fixing the returned
value in case of error? If not, please explain it to me as I don't see any
other changes.
- Where did you fix a buffer overflow?
I submitted to Jeff an updated version just before you sent your e-mail.
It incorporates most of your fixes expect for the possible loop-forever.
It's more stable that the one in the current kernel tree.
Javier Achirica
On Fri, 18 Jul 2003, Daniel Ritz wrote:
> in 2.4.20+ airo.c is broken and can even kill keventd. this patch fixes it:
> - sane locking with spinlocks and irqs disabled instead of the buggy locking
> with semaphores
> - fix transmit code
> - safer unload ordering of disable irq, unregister_netdev, kfree
> - fix possible loop-forever bug
> - fix a buffer overflow
>
> a kernel 2.4 version of the patch is tested by some people with good results.
> against 2.6.0-test1-bk. please apply.
>
>
> rgds
> -daniel
next prev parent reply other threads:[~2003-07-21 11:52 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-07-17 22:15 [PATCH 2.4] fixes for airo.c Daniel Ritz
2003-07-21 11:00 ` Javier Achirica [this message]
2003-07-21 12:37 ` [PATCH 2.5] " Christoph Hellwig
2003-07-21 13:46 ` Javier Achirica
2003-07-21 15:08 ` Mike Kershaw
2003-07-21 18:56 ` Javier Achirica
2003-07-21 17:49 ` Daniel Ritz
2003-07-21 19:44 ` Javier Achirica
2003-07-21 21:01 ` Daniel Ritz
2003-07-21 21:24 ` Javier Achirica
2003-07-22 8:15 ` Javier Achirica
2003-07-23 9:36 ` Daniel Ritz
2003-07-23 10:26 ` Javier Achirica
2003-07-23 17:56 ` Daniel Ritz
2003-07-23 18:03 ` Alan Cox
2003-07-23 18:20 ` Javier Achirica
2003-07-23 18:10 ` Javier Achirica
2003-07-23 18:20 ` Alan Cox
2003-07-23 18:52 ` Daniel Ritz
2003-07-23 20:43 ` Jeff Garzik
2003-07-23 21:19 ` Daniel Ritz
2003-07-24 17:07 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.SOL.4.30.0307211252190.25549-100000@tudela.mad.ttd.net \
--to=achirica@telefonica.net \
--cc=daniel.ritz@gmx.ch \
--cc=dragorn@melchior.nerv-un.net \
--cc=jgarzik@pobox.com \
--cc=jt@bougret.hpl.hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-net@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).