* [PATCH v2 7/9] dt-bindings: arm: qcom: Add MSM8996 Pro compatible
@ 2022-04-09 4:18 Yassine Oudjana
2022-04-12 19:30 ` Bjorn Andersson
0 siblings, 1 reply; 3+ messages in thread
From: Yassine Oudjana @ 2022-04-09 4:18 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Rob Herring, Krzysztof Kozlowski,
Michael Turquette, Stephen Boyd, Ilia Lin, Viresh Kumar,
Nishanth Menon, Rafael J. Wysocki
Cc: Yassine Oudjana, Konrad Dybcio, Dmitry Baryshkov, Loic Poulain,
linux-arm-msm, devicetree, linux-kernel, linux-clk, linux-pm
Add a qcom,msm8996pro compatible and move xiaomi,scorpio to the
same items list as it.
Signed-off-by: Yassine Oudjana <y.oudjana@protonmail.com>
---
Documentation/devicetree/bindings/arm/qcom.yaml | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
index 129cdd246223..dcf2e0102857 100644
--- a/Documentation/devicetree/bindings/arm/qcom.yaml
+++ b/Documentation/devicetree/bindings/arm/qcom.yaml
@@ -186,7 +186,12 @@ properties:
- sony,kagura-row
- sony,keyaki-row
- xiaomi,gemini
+ - const: qcom,msm8996
+
+ - items:
+ - enum:
- xiaomi,scorpio
+ - const: qcom,msm8996pro
- const: qcom,msm8996
- items:
--
2.35.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2 7/9] dt-bindings: arm: qcom: Add MSM8996 Pro compatible
2022-04-09 4:18 [PATCH v2 7/9] dt-bindings: arm: qcom: Add MSM8996 Pro compatible Yassine Oudjana
@ 2022-04-12 19:30 ` Bjorn Andersson
2022-04-16 2:24 ` Yassine Oudjana
0 siblings, 1 reply; 3+ messages in thread
From: Bjorn Andersson @ 2022-04-12 19:30 UTC (permalink / raw)
To: Yassine Oudjana
Cc: Andy Gross, Rob Herring, Krzysztof Kozlowski, Michael Turquette,
Stephen Boyd, Ilia Lin, Viresh Kumar, Nishanth Menon,
Rafael J. Wysocki, Konrad Dybcio, Dmitry Baryshkov, Loic Poulain,
linux-arm-msm, devicetree, linux-kernel, linux-clk, linux-pm
On Fri 08 Apr 23:18 CDT 2022, Yassine Oudjana wrote:
> Add a qcom,msm8996pro compatible and move xiaomi,scorpio to the
> same items list as it.
>
> Signed-off-by: Yassine Oudjana <y.oudjana@protonmail.com>
> ---
> Documentation/devicetree/bindings/arm/qcom.yaml | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> index 129cdd246223..dcf2e0102857 100644
> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
> @@ -186,7 +186,12 @@ properties:
> - sony,kagura-row
> - sony,keyaki-row
> - xiaomi,gemini
> + - const: qcom,msm8996
> +
> + - items:
> + - enum:
> - xiaomi,scorpio
> + - const: qcom,msm8996pro
> - const: qcom,msm8996
So we want both platform compatibles in there?
>
> - items:
> --
> 2.35.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2 7/9] dt-bindings: arm: qcom: Add MSM8996 Pro compatible
2022-04-12 19:30 ` Bjorn Andersson
@ 2022-04-16 2:24 ` Yassine Oudjana
0 siblings, 0 replies; 3+ messages in thread
From: Yassine Oudjana @ 2022-04-16 2:24 UTC (permalink / raw)
To: Bjorn Andersson
Cc: Andy Gross, Rob Herring, Krzysztof Kozlowski, Michael Turquette,
Stephen Boyd, Ilia Lin, Viresh Kumar, Nishanth Menon,
Rafael J. Wysocki, Konrad Dybcio, Dmitry Baryshkov, Loic Poulain,
linux-arm-msm, devicetree, linux-kernel, linux-clk, linux-pm
------- Original Message -------
On Tuesday, April 12th, 2022 at 11:30 PM, Bjorn Andersson <bjorn.andersson@linaro.org> wrote:
> On Fri 08 Apr 23:18 CDT 2022, Yassine Oudjana wrote:
> > Add a qcom,msm8996pro compatible and move xiaomi,scorpio to the
> > same items list as it.
> >
> > Signed-off-by: Yassine Oudjana y.oudjana@protonmail.com
> > ---
> > Documentation/devicetree/bindings/arm/qcom.yaml | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> > index 129cdd246223..dcf2e0102857 100644
> > --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> > +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
> > @@ -186,7 +186,12 @@ properties:
> > - sony,kagura-row
> > - sony,keyaki-row
> > - xiaomi,gemini
> > + - const: qcom,msm8996
> > +
> > + - items:
> > + - enum:
> > - xiaomi,scorpio
> > + - const: qcom,msm8996pro
> > - const: qcom,msm8996
>
>
> So we want both platform compatibles in there?
Instead of adding qcom,msm8996pro to qcom-cpufreq-nvmem and cpufreq-dt-platdev,
I kept qcom,msm8996 as a fallback since pro isn't too different from non-pro 8996
and should run mostly fine if treated as that. I'll remove it if you think it
is better.
>
> > - items:
> > --
> > 2.35.1
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-04-16 2:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-09 4:18 [PATCH v2 7/9] dt-bindings: arm: qcom: Add MSM8996 Pro compatible Yassine Oudjana
2022-04-12 19:30 ` Bjorn Andersson
2022-04-16 2:24 ` Yassine Oudjana
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).