* [PATCH] scsi: jazz_esp, sun3x_esp: Pass struct device pointer in dma calls
@ 2018-03-07 6:56 Finn Thain
2018-03-09 10:52 ` Tom Bogendoerfer
0 siblings, 1 reply; 3+ messages in thread
From: Finn Thain @ 2018-03-07 6:56 UTC (permalink / raw)
To: James E.J. Bottomley, Martin K. Petersen
Cc: Thomas Bogendoerfer, linux-scsi, linux-kernel
In jazz_esp and sun3x_esp, the esp_driver_ops methods pass esp->dev
in dma api calls as if it was a pointer to a struct device. But
it actually points to a struct platform_device. Fix this.
Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
---
drivers/scsi/jazz_esp.c | 2 +-
drivers/scsi/sun3x_esp.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/jazz_esp.c b/drivers/scsi/jazz_esp.c
index 9aaa74e349cc..6eb5ff3e2e61 100644
--- a/drivers/scsi/jazz_esp.c
+++ b/drivers/scsi/jazz_esp.c
@@ -147,7 +147,7 @@ static int esp_jazz_probe(struct platform_device *dev)
esp = shost_priv(host);
esp->host = host;
- esp->dev = dev;
+ esp->dev = &dev->dev;
esp->ops = &jazz_esp_ops;
res = platform_get_resource(dev, IORESOURCE_MEM, 0);
diff --git a/drivers/scsi/sun3x_esp.c b/drivers/scsi/sun3x_esp.c
index d50c5ed8f428..0b1421cdf8a0 100644
--- a/drivers/scsi/sun3x_esp.c
+++ b/drivers/scsi/sun3x_esp.c
@@ -210,7 +210,7 @@ static int esp_sun3x_probe(struct platform_device *dev)
esp = shost_priv(host);
esp->host = host;
- esp->dev = dev;
+ esp->dev = &dev->dev;
esp->ops = &sun3x_esp_ops;
res = platform_get_resource(dev, IORESOURCE_MEM, 0);
--
2.16.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: jazz_esp, sun3x_esp: Pass struct device pointer in dma calls
2018-03-07 6:56 [PATCH] scsi: jazz_esp, sun3x_esp: Pass struct device pointer in dma calls Finn Thain
@ 2018-03-09 10:52 ` Tom Bogendoerfer
0 siblings, 0 replies; 3+ messages in thread
From: Tom Bogendoerfer @ 2018-03-09 10:52 UTC (permalink / raw)
To: Finn Thain
Cc: James E.J. Bottomley, Martin K. Petersen, linux-scsi, linux-kernel
On Wed, Mar 07, 2018 at 05:56:41PM +1100, Finn Thain wrote:
> In jazz_esp and sun3x_esp, the esp_driver_ops methods pass esp->dev
> in dma api calls as if it was a pointer to a struct device. But
> it actually points to a struct platform_device. Fix this.
>
> Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
> Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
Looks good.
Reviewed-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: jazz_esp, sun3x_esp: Pass struct device pointer in dma calls
[not found] <S1751076AbeCGG4t/20180307065702Z+42@vger.kernel.org>
@ 2018-03-13 2:06 ` Martin K. Petersen
0 siblings, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2018-03-13 2:06 UTC (permalink / raw)
To: Finn Thain
Cc: James E.J. Bottomley, Martin K. Petersen, Thomas Bogendoerfer,
linux-scsi, linux-kernel
Finn,
> In jazz_esp and sun3x_esp, the esp_driver_ops methods pass esp->dev
> in dma api calls as if it was a pointer to a struct device. But
> it actually points to a struct platform_device. Fix this.
Applied to 4.17/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-03-13 2:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-07 6:56 [PATCH] scsi: jazz_esp, sun3x_esp: Pass struct device pointer in dma calls Finn Thain
2018-03-09 10:52 ` Tom Bogendoerfer
[not found] <S1751076AbeCGG4t/20180307065702Z+42@vger.kernel.org>
2018-03-13 2:06 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).