* [PATCH 1/6] ASoC: mediatek: mt8186: fix an "unused" warning
2022-10-20 21:08 [PATCH 0/6] a pile of randconfig fixes Adam Borowski
@ 2022-09-14 20:06 ` Adam Borowski
2022-09-14 20:13 ` [PATCH 2/6] certs: fips test: fix build failure with PKCS7_MESSAGE_PARSER=m Adam Borowski
` (6 subsequent siblings)
7 siblings, 0 replies; 12+ messages in thread
From: Adam Borowski @ 2022-09-14 20:06 UTC (permalink / raw)
To: Matthias Brugger, Liam Girdwood, Mark Brown, Jiaxin Yu,
AngeloGioacchino Del Regno, linux-mediatek, alsa-devel,
linux-kernel
This, and a whole bunch of referenced functions are not needed without
CONFIG_OF. The warning makes the build fail under CONFIG_WERROR.
Signed-off-by: Adam Borowski <kilobyte@angband.pl>
---
sound/soc/mediatek/mt8186/mt8186-mt6366-da7219-max98357.c | 2 +-
sound/soc/mediatek/mt8186/mt8186-mt6366-rt1019-rt5682s.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/soc/mediatek/mt8186/mt8186-mt6366-da7219-max98357.c b/sound/soc/mediatek/mt8186/mt8186-mt6366-da7219-max98357.c
index cfca6bdee834..b15e97bd9d4d 100644
--- a/sound/soc/mediatek/mt8186/mt8186-mt6366-da7219-max98357.c
+++ b/sound/soc/mediatek/mt8186/mt8186-mt6366-da7219-max98357.c
@@ -1000,7 +1000,7 @@ mt8186_mt6366_da7219_max98357_controls[] = {
SOC_DAPM_PIN_SWITCH("HDMI1"),
};
-static struct snd_soc_card mt8186_mt6366_da7219_max98357_soc_card = {
+static __maybe_unused struct snd_soc_card mt8186_mt6366_da7219_max98357_soc_card = {
.name = "mt8186_da7219_max98357",
.owner = THIS_MODULE,
.dai_link = mt8186_mt6366_da7219_max98357_dai_links,
diff --git a/sound/soc/mediatek/mt8186/mt8186-mt6366-rt1019-rt5682s.c b/sound/soc/mediatek/mt8186/mt8186-mt6366-rt1019-rt5682s.c
index 2414c5b77233..22ce2f849909 100644
--- a/sound/soc/mediatek/mt8186/mt8186-mt6366-rt1019-rt5682s.c
+++ b/sound/soc/mediatek/mt8186/mt8186-mt6366-rt1019-rt5682s.c
@@ -976,7 +976,7 @@ mt8186_mt6366_rt1019_rt5682s_controls[] = {
SOC_DAPM_PIN_SWITCH("HDMI1"),
};
-static struct snd_soc_card mt8186_mt6366_rt1019_rt5682s_soc_card = {
+static __maybe_unused struct snd_soc_card mt8186_mt6366_rt1019_rt5682s_soc_card = {
.name = "mt8186_rt1019_rt5682s",
.owner = THIS_MODULE,
.dai_link = mt8186_mt6366_rt1019_rt5682s_dai_links,
--
2.37.2.609.g9ff673ca1a
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 2/6] certs: fips test: fix build failure with PKCS7_MESSAGE_PARSER=m
2022-10-20 21:08 [PATCH 0/6] a pile of randconfig fixes Adam Borowski
2022-09-14 20:06 ` [PATCH 1/6] ASoC: mediatek: mt8186: fix an "unused" warning Adam Borowski
@ 2022-09-14 20:13 ` Adam Borowski
2022-09-14 21:29 ` [PATCH 3/6] mtd: eject cfi_interleave code to its own header Adam Borowski
` (5 subsequent siblings)
7 siblings, 0 replies; 12+ messages in thread
From: Adam Borowski @ 2022-09-14 20:13 UTC (permalink / raw)
To: David Howells, Herbert Xu, David S. Miller, keyrings,
linux-crypto, linux-kernel
ld: crypto/asymmetric_keys/selftest.o: in function `fips_signature_selftest':
selftest.c:(.init.text+0xcd): undefined reference to `pkcs7_parse_message'
ld: selftest.c:(.init.text+0x103): undefined reference to `pkcs7_supply_detached_data'
ld: selftest.c:(.init.text+0x10d): undefined reference to `pkcs7_verify'
ld: selftest.c:(.init.text+0x135): undefined reference to `pkcs7_validate_trust'
ld: selftest.c:(.init.text+0x157): undefined reference to `pkcs7_free_message'
Fixes: 3cde3174eb910513d32a9ec8a9b95ea59be833df
Signed-off-by: Adam Borowski <kilobyte@angband.pl>
---
crypto/asymmetric_keys/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/crypto/asymmetric_keys/Kconfig b/crypto/asymmetric_keys/Kconfig
index 3df3fe4ed95f..fe007db96c69 100644
--- a/crypto/asymmetric_keys/Kconfig
+++ b/crypto/asymmetric_keys/Kconfig
@@ -83,6 +83,6 @@ config FIPS_SIGNATURE_SELFTEST
for FIPS.
depends on KEYS
depends on ASYMMETRIC_KEY_TYPE
- depends on PKCS7_MESSAGE_PARSER
+ depends on PKCS7_MESSAGE_PARSER=y
endif # ASYMMETRIC_KEY_TYPE
--
2.37.2.609.g9ff673ca1a
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 3/6] mtd: eject cfi_interleave code to its own header
2022-10-20 21:08 [PATCH 0/6] a pile of randconfig fixes Adam Borowski
2022-09-14 20:06 ` [PATCH 1/6] ASoC: mediatek: mt8186: fix an "unused" warning Adam Borowski
2022-09-14 20:13 ` [PATCH 2/6] certs: fips test: fix build failure with PKCS7_MESSAGE_PARSER=m Adam Borowski
@ 2022-09-14 21:29 ` Adam Borowski
2022-09-15 23:33 ` [PATCH 4/6] media: ipu3-cio2: make the bridge depend on i2c Adam Borowski
` (4 subsequent siblings)
7 siblings, 0 replies; 12+ messages in thread
From: Adam Borowski @ 2022-09-14 21:29 UTC (permalink / raw)
To: Miquel Raynal, Richard Weinberger, Vignesh Raghavendra,
linux-mtd, Mark Brown, linux-spi, linux-kernel
This fixes build failures for stuff that doesn't care about that, such as:
In file included from ./include/linux/mtd/spi-nor.h:10,
from drivers/spi/spi-intel.c:13:
./include/linux/mtd/cfi.h:62:2: error: #warning No CONFIG_MTD_CFI_Ix selected. No NOR chip support
62 | #warning No CONFIG_MTD_CFI_Ix selected. No NOR chip support can work.
| ^~~~~~~
Signed-off-by: Adam Borowski <kilobyte@angband.pl>
---
drivers/mtd/chips/cfi_cmdset_0001.c | 1 +
drivers/mtd/chips/cfi_cmdset_0002.c | 1 +
drivers/mtd/chips/cfi_cmdset_0020.c | 1 +
drivers/mtd/chips/cfi_util.c | 1 +
drivers/mtd/chips/gen_probe.c | 1 +
drivers/mtd/chips/jedec_probe.c | 1 +
include/linux/mtd/cfi.h | 75 --------------------------
include/linux/mtd/cfi_interleave.h | 83 +++++++++++++++++++++++++++++
8 files changed, 89 insertions(+), 75 deletions(-)
create mode 100644 include/linux/mtd/cfi_interleave.h
diff --git a/drivers/mtd/chips/cfi_cmdset_0001.c b/drivers/mtd/chips/cfi_cmdset_0001.c
index 54f92d09d9cf..efbf06fce95b 100644
--- a/drivers/mtd/chips/cfi_cmdset_0001.c
+++ b/drivers/mtd/chips/cfi_cmdset_0001.c
@@ -34,6 +34,7 @@
#include <linux/mtd/map.h>
#include <linux/mtd/mtd.h>
#include <linux/mtd/cfi.h>
+#include <linux/mtd/cfi_interleave.h>
/* #define CMDSET0001_DISABLE_ERASE_SUSPEND_ON_WRITE */
/* #define CMDSET0001_DISABLE_WRITE_SUSPEND */
diff --git a/drivers/mtd/chips/cfi_cmdset_0002.c b/drivers/mtd/chips/cfi_cmdset_0002.c
index 67453f59c69c..70d00c3641d8 100644
--- a/drivers/mtd/chips/cfi_cmdset_0002.c
+++ b/drivers/mtd/chips/cfi_cmdset_0002.c
@@ -37,6 +37,7 @@
#include <linux/mtd/map.h>
#include <linux/mtd/mtd.h>
#include <linux/mtd/cfi.h>
+#include <linux/mtd/cfi_interleave.h>
#include <linux/mtd/xip.h>
#define AMD_BOOTLOC_BUG
diff --git a/drivers/mtd/chips/cfi_cmdset_0020.c b/drivers/mtd/chips/cfi_cmdset_0020.c
index d35df526e0a6..007e37faff56 100644
--- a/drivers/mtd/chips/cfi_cmdset_0020.c
+++ b/drivers/mtd/chips/cfi_cmdset_0020.c
@@ -31,6 +31,7 @@
#include <linux/interrupt.h>
#include <linux/mtd/map.h>
#include <linux/mtd/cfi.h>
+#include <linux/mtd/cfi_interleave.h>
#include <linux/mtd/mtd.h>
diff --git a/drivers/mtd/chips/cfi_util.c b/drivers/mtd/chips/cfi_util.c
index 6a6a2a21d2ed..608315032f9e 100644
--- a/drivers/mtd/chips/cfi_util.c
+++ b/drivers/mtd/chips/cfi_util.c
@@ -22,6 +22,7 @@
#include <linux/mtd/mtd.h>
#include <linux/mtd/map.h>
#include <linux/mtd/cfi.h>
+#include <linux/mtd/cfi_interleave.h>
void cfi_udelay(int us)
{
diff --git a/drivers/mtd/chips/gen_probe.c b/drivers/mtd/chips/gen_probe.c
index 4d4f97841016..8703890ff20e 100644
--- a/drivers/mtd/chips/gen_probe.c
+++ b/drivers/mtd/chips/gen_probe.c
@@ -10,6 +10,7 @@
#include <linux/mtd/mtd.h>
#include <linux/mtd/map.h>
#include <linux/mtd/cfi.h>
+#include <linux/mtd/cfi_interleave.h>
#include <linux/mtd/gen_probe.h>
static struct mtd_info *check_cmd_set(struct map_info *, int);
diff --git a/drivers/mtd/chips/jedec_probe.c b/drivers/mtd/chips/jedec_probe.c
index 6f7e7e1b3fe5..88a979bb59bb 100644
--- a/drivers/mtd/chips/jedec_probe.c
+++ b/drivers/mtd/chips/jedec_probe.c
@@ -20,6 +20,7 @@
#include <linux/mtd/mtd.h>
#include <linux/mtd/map.h>
#include <linux/mtd/cfi.h>
+#include <linux/mtd/cfi_interleave.h>
#include <linux/mtd/gen_probe.h>
/* AMD */
diff --git a/include/linux/mtd/cfi.h b/include/linux/mtd/cfi.h
index d88bb56c18e2..4a8ddb51afee 100644
--- a/include/linux/mtd/cfi.h
+++ b/include/linux/mtd/cfi.h
@@ -8,87 +8,12 @@
#include <linux/delay.h>
#include <linux/types.h>
-#include <linux/bug.h>
#include <linux/interrupt.h>
#include <linux/mtd/flashchip.h>
#include <linux/mtd/map.h>
#include <linux/mtd/cfi_endian.h>
#include <linux/mtd/xip.h>
-#ifdef CONFIG_MTD_CFI_I1
-#define cfi_interleave(cfi) 1
-#define cfi_interleave_is_1(cfi) (cfi_interleave(cfi) == 1)
-#else
-#define cfi_interleave_is_1(cfi) (0)
-#endif
-
-#ifdef CONFIG_MTD_CFI_I2
-# ifdef cfi_interleave
-# undef cfi_interleave
-# define cfi_interleave(cfi) ((cfi)->interleave)
-# else
-# define cfi_interleave(cfi) 2
-# endif
-#define cfi_interleave_is_2(cfi) (cfi_interleave(cfi) == 2)
-#else
-#define cfi_interleave_is_2(cfi) (0)
-#endif
-
-#ifdef CONFIG_MTD_CFI_I4
-# ifdef cfi_interleave
-# undef cfi_interleave
-# define cfi_interleave(cfi) ((cfi)->interleave)
-# else
-# define cfi_interleave(cfi) 4
-# endif
-#define cfi_interleave_is_4(cfi) (cfi_interleave(cfi) == 4)
-#else
-#define cfi_interleave_is_4(cfi) (0)
-#endif
-
-#ifdef CONFIG_MTD_CFI_I8
-# ifdef cfi_interleave
-# undef cfi_interleave
-# define cfi_interleave(cfi) ((cfi)->interleave)
-# else
-# define cfi_interleave(cfi) 8
-# endif
-#define cfi_interleave_is_8(cfi) (cfi_interleave(cfi) == 8)
-#else
-#define cfi_interleave_is_8(cfi) (0)
-#endif
-
-#ifndef cfi_interleave
-#warning No CONFIG_MTD_CFI_Ix selected. No NOR chip support can work.
-static inline int cfi_interleave(void *cfi)
-{
- BUG();
- return 0;
-}
-#endif
-
-static inline int cfi_interleave_supported(int i)
-{
- switch (i) {
-#ifdef CONFIG_MTD_CFI_I1
- case 1:
-#endif
-#ifdef CONFIG_MTD_CFI_I2
- case 2:
-#endif
-#ifdef CONFIG_MTD_CFI_I4
- case 4:
-#endif
-#ifdef CONFIG_MTD_CFI_I8
- case 8:
-#endif
- return 1;
-
- default:
- return 0;
- }
-}
-
/* NB: these values must represents the number of bytes needed to meet the
* device type (x8, x16, x32). Eg. a 32 bit device is 4 x 8 bytes.
diff --git a/include/linux/mtd/cfi_interleave.h b/include/linux/mtd/cfi_interleave.h
new file mode 100644
index 000000000000..03d94a6d11fc
--- /dev/null
+++ b/include/linux/mtd/cfi_interleave.h
@@ -0,0 +1,83 @@
+/* SPDX-License-Identifier: GPL-2.0-or-later */
+
+#ifndef __MTD_CFI_INTERLEAVE_H__
+#define __MTD_CFI_INTERLEAVE_H__
+
+#include <linux/bug.h>
+
+#ifdef CONFIG_MTD_CFI_I1
+#define cfi_interleave(cfi) 1
+#define cfi_interleave_is_1(cfi) (cfi_interleave(cfi) == 1)
+#else
+#define cfi_interleave_is_1(cfi) (0)
+#endif
+
+#ifdef CONFIG_MTD_CFI_I2
+# ifdef cfi_interleave
+# undef cfi_interleave
+# define cfi_interleave(cfi) ((cfi)->interleave)
+# else
+# define cfi_interleave(cfi) 2
+# endif
+#define cfi_interleave_is_2(cfi) (cfi_interleave(cfi) == 2)
+#else
+#define cfi_interleave_is_2(cfi) (0)
+#endif
+
+#ifdef CONFIG_MTD_CFI_I4
+# ifdef cfi_interleave
+# undef cfi_interleave
+# define cfi_interleave(cfi) ((cfi)->interleave)
+# else
+# define cfi_interleave(cfi) 4
+# endif
+#define cfi_interleave_is_4(cfi) (cfi_interleave(cfi) == 4)
+#else
+#define cfi_interleave_is_4(cfi) (0)
+#endif
+
+#ifdef CONFIG_MTD_CFI_I8
+# ifdef cfi_interleave
+# undef cfi_interleave
+# define cfi_interleave(cfi) ((cfi)->interleave)
+# else
+# define cfi_interleave(cfi) 8
+# endif
+#define cfi_interleave_is_8(cfi) (cfi_interleave(cfi) == 8)
+#else
+#define cfi_interleave_is_8(cfi) (0)
+#endif
+
+#ifndef cfi_interleave
+#warning No CONFIG_MTD_CFI_Ix selected. No NOR chip support can work.
+static inline int cfi_interleave(void *cfi)
+{
+ BUG();
+ return 0;
+}
+#endif
+
+static inline int cfi_interleave_supported(int i)
+{
+ switch (i) {
+#ifdef CONFIG_MTD_CFI_I1
+ case 1:
+#endif
+#ifdef CONFIG_MTD_CFI_I2
+ case 2:
+#endif
+#ifdef CONFIG_MTD_CFI_I4
+ case 4:
+#endif
+#ifdef CONFIG_MTD_CFI_I8
+ case 8:
+#endif
+ return 1;
+
+ default:
+ return 0;
+ }
+}
+
+
+#endif /* __MTD_CFI_INTERLEAVE_H__ */
--
2.37.2.609.g9ff673ca1a
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 4/6] media: ipu3-cio2: make the bridge depend on i2c
2022-10-20 21:08 [PATCH 0/6] a pile of randconfig fixes Adam Borowski
` (2 preceding siblings ...)
2022-09-14 21:29 ` [PATCH 3/6] mtd: eject cfi_interleave code to its own header Adam Borowski
@ 2022-09-15 23:33 ` Adam Borowski
2022-10-10 18:33 ` [PATCH 5/6] i2c: mlxbf: depend on ACPI; clean away ifdeffage Adam Borowski
` (3 subsequent siblings)
7 siblings, 0 replies; 12+ messages in thread
From: Adam Borowski @ 2022-09-15 23:33 UTC (permalink / raw)
To: Yong Zhi, Sakari Ailus, Bingbu Cao, Dan Scally, Tianshu Qiu,
Mauro Carvalho Chehab, linux-media, linux-kernel
drivers/media/pci/intel/ipu3/cio2-bridge.c: In function ‘cio2_bridge_unregister_sensors’:
drivers/media/pci/intel/ipu3/cio2-bridge.c:258:17: error: implicit declaration of function ‘i2c_unregister_device’; did you mean ‘spi_unregister_device’? [-Werror=implicit-function-declaration]
258 | i2c_unregister_device(sensor->vcm_i2c_client);
| ^~~~~~~~~~~~~~~~~~~~~
| spi_unregister_device
Signed-off-by: Adam Borowski <kilobyte@angband.pl>
---
drivers/media/pci/intel/ipu3/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/pci/intel/ipu3/Kconfig b/drivers/media/pci/intel/ipu3/Kconfig
index 39bd3be0b43d..65b0c1598fbf 100644
--- a/drivers/media/pci/intel/ipu3/Kconfig
+++ b/drivers/media/pci/intel/ipu3/Kconfig
@@ -21,6 +21,7 @@ config VIDEO_IPU3_CIO2
config CIO2_BRIDGE
bool "IPU3 CIO2 Sensors Bridge"
depends on VIDEO_IPU3_CIO2 && ACPI
+ depends on I2C
help
This extension provides an API for the ipu3-cio2 driver to create
connections to cameras that are hidden in the SSDB buffer in ACPI.
--
2.37.2.609.g9ff673ca1a
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 5/6] i2c: mlxbf: depend on ACPI; clean away ifdeffage
2022-10-20 21:08 [PATCH 0/6] a pile of randconfig fixes Adam Borowski
` (3 preceding siblings ...)
2022-09-15 23:33 ` [PATCH 4/6] media: ipu3-cio2: make the bridge depend on i2c Adam Borowski
@ 2022-10-10 18:33 ` Adam Borowski
2022-10-17 6:17 ` [PATCH 6/6] ASoC: Intel: boards: add missing dependency from realtek-common Adam Borowski
` (2 subsequent siblings)
7 siblings, 0 replies; 12+ messages in thread
From: Adam Borowski @ 2022-10-10 18:33 UTC (permalink / raw)
To: Khalil Blaiech, Asmaa Mnebhi, linux-i2c, linux-kernel
This fixes maybe_unused warnings/errors.
According to a comment during device tree removal, only ACPI is supported,
thus let's actually require it.
Fixes: be18c5ede25da39a0eda541f6de3620a30cf731f
Signed-off-by: Adam Borowski <kilobyte@angband.pl>
---
drivers/i2c/busses/Kconfig | 1 +
drivers/i2c/busses/i2c-mlxbf.c | 9 ---------
2 files changed, 1 insertion(+), 9 deletions(-)
diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
index 264e780ae32e..e50f9603d189 100644
--- a/drivers/i2c/busses/Kconfig
+++ b/drivers/i2c/busses/Kconfig
@@ -764,6 +764,7 @@ config I2C_LPC2K
config I2C_MLXBF
tristate "Mellanox BlueField I2C controller"
depends on MELLANOX_PLATFORM && ARM64
+ depends on ACPI
select I2C_SLAVE
help
Enabling this option will add I2C SMBus support for Mellanox BlueField
diff --git a/drivers/i2c/busses/i2c-mlxbf.c b/drivers/i2c/busses/i2c-mlxbf.c
index e68e775f187e..1810d5791b3d 100644
--- a/drivers/i2c/busses/i2c-mlxbf.c
+++ b/drivers/i2c/busses/i2c-mlxbf.c
@@ -2247,7 +2247,6 @@ static struct i2c_adapter_quirks mlxbf_i2c_quirks = {
.max_write_len = MLXBF_I2C_MASTER_DATA_W_LENGTH,
};
-#ifdef CONFIG_ACPI
static const struct acpi_device_id mlxbf_i2c_acpi_ids[] = {
{ "MLNXBF03", (kernel_ulong_t)&mlxbf_i2c_chip[MLXBF_I2C_CHIP_TYPE_1] },
{ "MLNXBF23", (kernel_ulong_t)&mlxbf_i2c_chip[MLXBF_I2C_CHIP_TYPE_2] },
@@ -2282,12 +2281,6 @@ static int mlxbf_i2c_acpi_probe(struct device *dev, struct mlxbf_i2c_priv *priv)
return 0;
}
-#else
-static int mlxbf_i2c_acpi_probe(struct device *dev, struct mlxbf_i2c_priv *priv)
-{
- return -ENOENT;
-}
-#endif /* CONFIG_ACPI */
static int mlxbf_i2c_probe(struct platform_device *pdev)
{
@@ -2490,9 +2483,7 @@ static struct platform_driver mlxbf_i2c_driver = {
.remove = mlxbf_i2c_remove,
.driver = {
.name = "i2c-mlxbf",
-#ifdef CONFIG_ACPI
.acpi_match_table = ACPI_PTR(mlxbf_i2c_acpi_ids),
-#endif /* CONFIG_ACPI */
},
};
--
2.37.2.609.g9ff673ca1a
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 6/6] ASoC: Intel: boards: add missing dependency from realtek-common
2022-10-20 21:08 [PATCH 0/6] a pile of randconfig fixes Adam Borowski
` (4 preceding siblings ...)
2022-10-10 18:33 ` [PATCH 5/6] i2c: mlxbf: depend on ACPI; clean away ifdeffage Adam Borowski
@ 2022-10-17 6:17 ` Adam Borowski
[not found] ` <S229897AbiJTWqk/20221020224640Z+957@vger.kernel.org>
2022-10-27 12:44 ` [PATCH 6/6] ASoC: Intel: boards: add missing dependency from realtek-common Mark Brown
7 siblings, 0 replies; 12+ messages in thread
From: Adam Borowski @ 2022-10-17 6:17 UTC (permalink / raw)
To: Cezary Rojewski, Pierre-Louis Bossart, Liam Girdwood,
Peter Ujfalusi, Bard Liao, Ranjani Sridharan, Kai Vehmanen,
Mark Brown, Jaroslav Kysela, Takashi Iwai, Brent Lu, alsa-devel,
linux-kernel
These boards use code from sound/soc/sof/sof-audio.c
Fixes: e1d5e13324020c4b405e63cae34560c7992bec2e
Signed-off-by: Adam Borowski <kilobyte@angband.pl>
---
sound/soc/intel/boards/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/soc/intel/boards/Kconfig b/sound/soc/intel/boards/Kconfig
index aa12d7e3dd2f..3179ba061d87 100644
--- a/sound/soc/intel/boards/Kconfig
+++ b/sound/soc/intel/boards/Kconfig
@@ -34,6 +34,7 @@ config SND_SOC_INTEL_SOF_MAXIM_COMMON
config SND_SOC_INTEL_SOF_REALTEK_COMMON
tristate
+ depends on SND_SOC_SOF
config SND_SOC_INTEL_SOF_CIRRUS_COMMON
tristate
--
2.37.2.609.g9ff673ca1a
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 0/6] a pile of randconfig fixes
@ 2022-10-20 21:08 Adam Borowski
2022-09-14 20:06 ` [PATCH 1/6] ASoC: mediatek: mt8186: fix an "unused" warning Adam Borowski
` (7 more replies)
0 siblings, 8 replies; 12+ messages in thread
From: Adam Borowski @ 2022-10-20 21:08 UTC (permalink / raw)
To: linux-kernel
Cc: Matthias Brugger, Liam Girdwood, Mark Brown, Jiaxin Yu,
AngeloGioacchino Del Regno, linux-mediatek, alsa-devel,
David Howells, Herbert Xu, David S. Miller, keyrings,
linux-crypto, Miquel Raynal, Richard Weinberger,
Vignesh Raghavendra, linux-mtd, Mark Brown, linux-spi, Yong Zhi,
Sakari Ailus, Bingbu Cao, Dan Scally, Tianshu Qiu,
Mauro Carvalho Chehab, linux-media, Khalil Blaiech, Asmaa Mnebhi,
linux-i2c, Cezary Rojewski, Pierre-Louis Bossart, Liam Girdwood,
Peter Ujfalusi, Bard Liao, Ranjani Sridharan, Kai Vehmanen,
Mark Brown, Jaroslav Kysela, Takashi Iwai, Brent Lu, alsa-devel
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 1092 bytes --]
Hi!
I've been doing randconfig build tests for quite a while, here's a pile of
fixes. I'm not sure what's the best way to submit these: do you folks
prefer a series like this, or a number of individual submissions?
With these applied, it seems that archs I run (64-bit x86 arm riscv) are
clean now -- at least for the values of "haven't failed build in a while".
My restrictions were:
[amd64]
CONFIG_64BIT=y
CONFIG_COMPILE_TEST=y
CONFIG_AIC79XX_BUILD_FIRMWARE=n
CONFIG_AIC7XXX_BUILD_FIRMWARE=n
[arm64]
CONFIG_AIC79XX_BUILD_FIRMWARE=n
CONFIG_AIC7XXX_BUILD_FIRMWARE=n
[riscv64]
!CONFIG_ARCH_RV32I=y #yay "selects"
CONFIG_CMODEL_MEDANY=y
CONFIG_BPF_PRELOAD_UMD=n
CONFIG_AIC79XX_BUILD_FIRMWARE=n
CONFIG_AIC7XXX_BUILD_FIRMWARE=n
and applied fixes for dwc3-qcom riscv_cbom_block_size dump_emit_page
riscv:jump_label.
All builds were done with gcc-12 on Debian unstable.
[apologies for the broken first attempt to send, mbox is too new technology
for me I guess]
Meow!
--
⢀⣴⠾⠻⢶⣦⠀
⣾⠁⢠⠒⠀⣿⡁
⢿⡄⠘⠷⠚⠋⠀ Quis trollabit ipsos trollos?
⠈⠳⣄⠀⠀⠀⠀
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 5/6] i2c: mlxbf: depend on ACPI; clean away ifdeffage
[not found] ` <S229897AbiJTWqk/20221020224640Z+957@vger.kernel.org>
@ 2022-10-21 6:43 ` Wolfram Sang
2022-10-21 6:47 ` Wolfram Sang
` (2 more replies)
0 siblings, 3 replies; 12+ messages in thread
From: Wolfram Sang @ 2022-10-21 6:43 UTC (permalink / raw)
To: Adam Borowski; +Cc: Khalil Blaiech, Asmaa Mnebhi, linux-i2c, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 658 bytes --]
On Mon, Oct 10, 2022 at 08:33:51PM +0200, Adam Borowski wrote:
> This fixes maybe_unused warnings/errors.
>
> According to a comment during device tree removal, only ACPI is supported,
> thus let's actually require it.
>
> Fixes: be18c5ede25da39a0eda541f6de3620a30cf731f
> Signed-off-by: Adam Borowski <kilobyte@angband.pl>
Applied to for-current, thanks!
@Asmaa, @Khalil: normally, I will not skip the driver maintainer's ack
but wait for it. I'd like to make an exception this time because I don't
want to get another dozen of patches fixing this build warning. Since
Asmaa already acked a similar patch, I hope this is okay with you.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 5/6] i2c: mlxbf: depend on ACPI; clean away ifdeffage
2022-10-21 6:43 ` [PATCH 5/6] i2c: mlxbf: depend on ACPI; clean away ifdeffage Wolfram Sang
@ 2022-10-21 6:47 ` Wolfram Sang
2022-10-21 12:43 ` Asmaa Mnebhi
2022-10-21 12:57 ` Khalil Blaiech
2 siblings, 0 replies; 12+ messages in thread
From: Wolfram Sang @ 2022-10-21 6:47 UTC (permalink / raw)
To: Adam Borowski, Khalil Blaiech, Asmaa Mnebhi, linux-i2c, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 213 bytes --]
> > Fixes: be18c5ede25da39a0eda541f6de3620a30cf731f
BTW this has to look like:
Fixes: be18c5ede25d ("i2c: mlxbf: remove device tree support")
checkpatch will warn you about it. This time, I fixed it for you.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* RE: [PATCH 5/6] i2c: mlxbf: depend on ACPI; clean away ifdeffage
2022-10-21 6:43 ` [PATCH 5/6] i2c: mlxbf: depend on ACPI; clean away ifdeffage Wolfram Sang
2022-10-21 6:47 ` Wolfram Sang
@ 2022-10-21 12:43 ` Asmaa Mnebhi
2022-10-21 12:57 ` Khalil Blaiech
2 siblings, 0 replies; 12+ messages in thread
From: Asmaa Mnebhi @ 2022-10-21 12:43 UTC (permalink / raw)
To: Wolfram Sang, Adam Borowski; +Cc: Khalil Blaiech, linux-i2c, linux-kernel
LGTM. Thanks Wolfram!
Acked-By: Asmaa Mnebhi <asmaa@nvidia.com>
-----Original Message-----
From: Wolfram Sang <wsa@kernel.org>
Sent: Friday, October 21, 2022 2:43 AM
To: Adam Borowski <kilobyte@angband.pl>
Cc: Khalil Blaiech <kblaiech@nvidia.com>; Asmaa Mnebhi <asmaa@nvidia.com>; linux-i2c@vger.kernel.org; linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/6] i2c: mlxbf: depend on ACPI; clean away ifdeffage
On Mon, Oct 10, 2022 at 08:33:51PM +0200, Adam Borowski wrote:
> This fixes maybe_unused warnings/errors.
>
> According to a comment during device tree removal, only ACPI is
> supported, thus let's actually require it.
>
> Fixes: be18c5ede25da39a0eda541f6de3620a30cf731f
> Signed-off-by: Adam Borowski <kilobyte@angband.pl>
Applied to for-current, thanks!
@Asmaa, @Khalil: normally, I will not skip the driver maintainer's ack but wait for it. I'd like to make an exception this time because I don't want to get another dozen of patches fixing this build warning. Since Asmaa already acked a similar patch, I hope this is okay with you.
^ permalink raw reply [flat|nested] 12+ messages in thread
* RE: [PATCH 5/6] i2c: mlxbf: depend on ACPI; clean away ifdeffage
2022-10-21 6:43 ` [PATCH 5/6] i2c: mlxbf: depend on ACPI; clean away ifdeffage Wolfram Sang
2022-10-21 6:47 ` Wolfram Sang
2022-10-21 12:43 ` Asmaa Mnebhi
@ 2022-10-21 12:57 ` Khalil Blaiech
2 siblings, 0 replies; 12+ messages in thread
From: Khalil Blaiech @ 2022-10-21 12:57 UTC (permalink / raw)
To: Wolfram Sang, Adam Borowski; +Cc: Asmaa Mnebhi, linux-i2c, linux-kernel
Fine with me. Thanks Wolfram.
Acked-By: Khalil Blaiech <kblaiech@nvidia.com>
Thanks,
-Khalil
-----Original Message-----
From: Wolfram Sang <wsa@kernel.org>
Sent: Friday, October 21, 2022 2:43 AM
To: Adam Borowski <kilobyte@angband.pl>
Cc: Khalil Blaiech <kblaiech@nvidia.com>; Asmaa Mnebhi <asmaa@nvidia.com>; linux-i2c@vger.kernel.org; linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/6] i2c: mlxbf: depend on ACPI; clean away ifdeffage
On Mon, Oct 10, 2022 at 08:33:51PM +0200, Adam Borowski wrote:
> This fixes maybe_unused warnings/errors.
>
> According to a comment during device tree removal, only ACPI is
> supported, thus let's actually require it.
>
> Fixes: be18c5ede25da39a0eda541f6de3620a30cf731f
> Signed-off-by: Adam Borowski <kilobyte@angband.pl>
Applied to for-current, thanks!
@Asmaa, @Khalil: normally, I will not skip the driver maintainer's ack but wait for it. I'd like to make an exception this time because I don't want to get another dozen of patches fixing this build warning. Since Asmaa already acked a similar patch, I hope this is okay with you.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 6/6] ASoC: Intel: boards: add missing dependency from realtek-common
2022-10-20 21:08 [PATCH 0/6] a pile of randconfig fixes Adam Borowski
` (6 preceding siblings ...)
[not found] ` <S229897AbiJTWqk/20221020224640Z+957@vger.kernel.org>
@ 2022-10-27 12:44 ` Mark Brown
7 siblings, 0 replies; 12+ messages in thread
From: Mark Brown @ 2022-10-27 12:44 UTC (permalink / raw)
To: Adam Borowski
Cc: Cezary Rojewski, Pierre-Louis Bossart, Liam Girdwood,
Peter Ujfalusi, Bard Liao, Ranjani Sridharan, Kai Vehmanen,
Jaroslav Kysela, Takashi Iwai, Brent Lu, alsa-devel,
linux-kernel
[-- Attachment #1: Type: text/plain, Size: 737 bytes --]
On Mon, Oct 17, 2022 at 08:17:12AM +0200, Adam Borowski wrote:
> These boards use code from sound/soc/sof/sof-audio.c
>
> Fixes: e1d5e13324020c4b405e63cae34560c7992bec2e
> Signed-off-by: Adam Borowski <kilobyte@angband.pl>
Please include human readable descriptions of things like commits and
issues being discussed in e-mail in your mails, this makes them much
easier for humans to read especially when they have no internet access.
I do frequently catch up on my mail on flights or while otherwise
travelling so this is even more pressing for me than just being about
making things a bit easier to read.
You've not incldued a cover letter for this and only copied me on some
patches, are there any dependency issues?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2022-10-27 12:44 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-20 21:08 [PATCH 0/6] a pile of randconfig fixes Adam Borowski
2022-09-14 20:06 ` [PATCH 1/6] ASoC: mediatek: mt8186: fix an "unused" warning Adam Borowski
2022-09-14 20:13 ` [PATCH 2/6] certs: fips test: fix build failure with PKCS7_MESSAGE_PARSER=m Adam Borowski
2022-09-14 21:29 ` [PATCH 3/6] mtd: eject cfi_interleave code to its own header Adam Borowski
2022-09-15 23:33 ` [PATCH 4/6] media: ipu3-cio2: make the bridge depend on i2c Adam Borowski
2022-10-10 18:33 ` [PATCH 5/6] i2c: mlxbf: depend on ACPI; clean away ifdeffage Adam Borowski
2022-10-17 6:17 ` [PATCH 6/6] ASoC: Intel: boards: add missing dependency from realtek-common Adam Borowski
[not found] ` <S229897AbiJTWqk/20221020224640Z+957@vger.kernel.org>
2022-10-21 6:43 ` [PATCH 5/6] i2c: mlxbf: depend on ACPI; clean away ifdeffage Wolfram Sang
2022-10-21 6:47 ` Wolfram Sang
2022-10-21 12:43 ` Asmaa Mnebhi
2022-10-21 12:57 ` Khalil Blaiech
2022-10-27 12:44 ` [PATCH 6/6] ASoC: Intel: boards: add missing dependency from realtek-common Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).