[PATCH v1 2/3] dt-bindings: clock: Add AST2600 video engine reset definition

[PATCH v1 2/3] dt-bindings: clock: Add AST2600 video engine reset definition

[Howard Chiu]

Reset bit for VE is 6

Signed-off-by: Howard Chiu <howard_chiu@aspeedtech.com>
---
 include/dt-bindings/clock/ast2600-clock.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/dt-bindings/clock/ast2600-clock.h b/include/dt-bindings/clock/ast2600-clock.h
index 62b9520a00fd..a7d0ad9539eb 100644
--- a/include/dt-bindings/clock/ast2600-clock.h
+++ b/include/dt-bindings/clock/ast2600-clock.h
@@ -110,6 +110,7 @@
 #define ASPEED_RESET_PCIE_DEV_OEN	20
 #define ASPEED_RESET_PCIE_RC_O		19
 #define ASPEED_RESET_PCIE_RC_OEN	18
+#define ASPEED_RESET_VIDEO		6
 #define ASPEED_RESET_PCI_DP		5
 #define ASPEED_RESET_AHB		1
 #define ASPEED_RESET_SDRAM		0
-- 
2.25.1

Re: [PATCH v1 2/3] dt-bindings: clock: Add AST2600 video engine reset definition

[Jae Hyun Yoo]

On 3/24/2022 12:27 AM, Howard Chiu wrote:
> Reset bit for VE is 6
> 
> Signed-off-by: Howard Chiu <howard_chiu@aspeedtech.com>
> ---
>   include/dt-bindings/clock/ast2600-clock.h | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/include/dt-bindings/clock/ast2600-clock.h b/include/dt-bindings/clock/ast2600-clock.h
> index 62b9520a00fd..a7d0ad9539eb 100644
> --- a/include/dt-bindings/clock/ast2600-clock.h
> +++ b/include/dt-bindings/clock/ast2600-clock.h
> @@ -110,6 +110,7 @@
>   #define ASPEED_RESET_PCIE_DEV_OEN	20
>   #define ASPEED_RESET_PCIE_RC_O		19
>   #define ASPEED_RESET_PCIE_RC_OEN	18
> +#define ASPEED_RESET_VIDEO		6

You don't need to add 'resets' for video node in DT so it wouldn't be
needed.

-Jae

>   #define ASPEED_RESET_PCI_DP		5
>   #define ASPEED_RESET_AHB		1
>   #define ASPEED_RESET_SDRAM		0

RE: [PATCH v1 2/3] dt-bindings: clock: Add AST2600 video engine reset definition

[Howard Chiu]

Hi Jae

************* Email Confidentiality Notice ********************
DISCLAIMER:
This message (and any attachments) may contain legally privileged and/or other confidential information. If you have received it in error, please notify the sender by reply e-mail and immediately delete the e-mail and any attachments without copying or disclosing the contents. Thank you.

> -----Original Message-----
> From: Jae Hyun Yoo <quic_jaehyoo@quicinc.com>
> Sent: Thursday, March 24, 2022 9:51 PM
> To: Howard Chiu <howard_chiu@aspeedtech.com>; robh+dt@kernel.org; Joel
> Stanley <joel@jms.id.au>; andrew@aj.id.au; devicetree@vger.kernel.org;
> linux-arm-kernel@lists.infradead.org; linux-aspeed@lists.ozlabs.org;
> linux-kernel@vger.kernel.org
> Subject: Re: [PATCH v1 2/3] dt-bindings: clock: Add AST2600 video engine reset
> definition
> 
> 
> 
> On 3/24/2022 12:27 AM, Howard Chiu wrote:
> > Reset bit for VE is 6
> >
> > Signed-off-by: Howard Chiu <howard_chiu@aspeedtech.com>
> > ---
> >   include/dt-bindings/clock/ast2600-clock.h | 1 +
> >   1 file changed, 1 insertion(+)
> >
> > diff --git a/include/dt-bindings/clock/ast2600-clock.h
> > b/include/dt-bindings/clock/ast2600-clock.h
> > index 62b9520a00fd..a7d0ad9539eb 100644
> > --- a/include/dt-bindings/clock/ast2600-clock.h
> > +++ b/include/dt-bindings/clock/ast2600-clock.h
> > @@ -110,6 +110,7 @@
> >   #define ASPEED_RESET_PCIE_DEV_OEN	20
> >   #define ASPEED_RESET_PCIE_RC_O		19
> >   #define ASPEED_RESET_PCIE_RC_OEN	18
> > +#define ASPEED_RESET_VIDEO		6
> 
> You don't need to add 'resets' for video node in DT so it wouldn't be needed.
> 
Got it.
> -Jae
> 
> >   #define ASPEED_RESET_PCI_DP		5
> >   #define ASPEED_RESET_AHB		1
> >   #define ASPEED_RESET_SDRAM		0