From: "Luck, Tony" <tony.luck@intel.com>
To: Peter Zijlstra <peterz@infradead.org>,
"kan.liang@linux.intel.com" <kan.liang@linux.intel.com>
Cc: "mingo@redhat.com" <mingo@redhat.com>,
"acme@kernel.org" <acme@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"alexander.shishkin@linux.intel.com"
<alexander.shishkin@linux.intel.com>,
"jolsa@kernel.org" <jolsa@kernel.org>,
"namhyung@kernel.org" <namhyung@kernel.org>,
"irogers@google.com" <irogers@google.com>,
"Hunter, Adrian" <adrian.hunter@intel.com>,
"ak@linux.intel.com" <ak@linux.intel.com>,
"Eranian, Stephane" <eranian@google.com>,
"alexey.v.bayduraev@linux.intel.com"
<alexey.v.bayduraev@linux.intel.com>,
"Zhang, Tinghao" <tinghao.zhang@intel.com>
Subject: RE: [PATCH V2 1/6] perf/x86/intel: Add Grand Ridge and Sierra Forest
Date: Wed, 7 Jun 2023 21:43:57 +0000 [thread overview]
Message-ID: <SJ1PR11MB608367DC5D25856073C86FCFFC53A@SJ1PR11MB6083.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20230522202659.GC3334667@hirez.programming.kicks-ass.net>
> > Create a non-hybrid PMU setup for Grand Ridge and Sierra Forest.
>
> Moo... Tony, did you sneak product names instead of uarch names in the
> intel-family thing again?
>
> That is; I'm thinking we want the below, no?
>
> -#define INTEL_FAM6_SIERRAFOREST_X 0xAF
> -
> -#define INTEL_FAM6_GRANDRIDGE 0xB6
> +#define INTEL_FAM6_ATOM_CRESTMONT_X 0xAF /* Sierra Forest */
> +#define INTEL_FAM6_ATOM_CRESTMONT 0xB6 /* Grand Ridge */
I don't think that's really any more helpful.
Using the code name of the model makes it easy to look things
up in ark.intel.com. Using the "core" name doesn't even work for
hybrid CPU models which have more than one core type.
So I'd like to keep it as it is.
But if you want to change to the core name, then please just
do it now.
There are folks internally worried that all upstream work for
these two CPU models is going to be blocked while this
is discussed.
-Tony
next prev parent reply other threads:[~2023-06-07 21:44 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-22 11:30 [PATCH V2 1/6] perf/x86/intel: Add Grand Ridge and Sierra Forest kan.liang
2023-05-22 11:30 ` [PATCH V2 2/6] perf: Add branch stack extension kan.liang
2023-05-23 6:03 ` Sandipan Das
2023-05-23 13:08 ` Liang, Kan
2023-08-02 21:58 ` Peter Zijlstra
2023-08-03 14:22 ` Liang, Kan
2023-05-22 11:30 ` [PATCH V2 3/6] perf: Support branch events kan.liang
2023-05-22 11:30 ` [PATCH V2 4/6] perf/x86/intel: Support LBR event logging kan.liang
2023-05-22 11:30 ` [PATCH V2 5/6] tools headers UAPI: Sync include/uapi/linux/perf_event.h header with the kernel kan.liang
2023-05-22 11:30 ` [PATCH V2 6/6] perf tools: Add branch event knob kan.liang
2023-05-22 20:26 ` [PATCH V2 1/6] perf/x86/intel: Add Grand Ridge and Sierra Forest Peter Zijlstra
2023-05-22 20:42 ` Luck, Tony
2023-05-22 20:48 ` Peter Zijlstra
2023-06-07 21:43 ` Luck, Tony [this message]
2023-06-08 7:24 ` Peter Zijlstra
2023-06-08 16:20 ` Luck, Tony
2023-06-29 22:39 ` Tony Luck
2023-08-02 15:01 ` Peter Zijlstra
2023-06-06 12:42 ` Liang, Kan
2023-06-06 13:24 ` Peter Zijlstra
2023-06-06 16:16 ` Liang, Kan
2023-06-06 18:17 ` Peter Zijlstra
2023-06-06 18:34 ` Liang, Kan
2023-06-06 19:37 ` Peter Zijlstra
2023-06-06 19:54 ` Liang, Kan
2023-08-09 20:04 ` [tip: perf/core] perf/x86/intel: Add Crestmont PMU tip-bot2 for Kan Liang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SJ1PR11MB608367DC5D25856073C86FCFFC53A@SJ1PR11MB6083.namprd11.prod.outlook.com \
--to=tony.luck@intel.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=alexey.v.bayduraev@linux.intel.com \
--cc=eranian@google.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=tinghao.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).