From: Akhil R <akhilrajeev@nvidia.com>
To: Rob Herring <robh@kernel.org>
Cc: "dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>,
Jonathan Hunter <jonathanh@nvidia.com>,
Laxman Dewangan <ldewangan@nvidia.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
"p.zabel@pengutronix.de" <p.zabel@pengutronix.de>,
"thierry.reding@gmail.com" <thierry.reding@gmail.com>,
"vkoul@kernel.org" <vkoul@kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: RE: [PATCH v3 1/3] dt-bindings: dmaengine: Add compatible for Tegra234
Date: Tue, 19 Jul 2022 07:41:43 +0000 [thread overview]
Message-ID: <SJ1PR12MB63391677B9E3249F98D8F1ABC08F9@SJ1PR12MB6339.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20220718191627.GA3375779-robh@kernel.org>
> On Mon, Jul 11, 2022 at 09:15:34PM +0530, Akhil R wrote:
> > Document the compatible string used by GPCDMA controller for Tegra234.
> >
> > Signed-off-by: Akhil R <akhilrajeev@nvidia.com>
> > ---
> > .../devicetree/bindings/dma/nvidia,tegra186-gpc-dma.yaml | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/dma/nvidia,tegra186-gpc-
> dma.yaml b/Documentation/devicetree/bindings/dma/nvidia,tegra186-gpc-
> dma.yaml
> > index 9dd1476d1849..399edcd5cecf 100644
> > --- a/Documentation/devicetree/bindings/dma/nvidia,tegra186-gpc-dma.yaml
> > +++ b/Documentation/devicetree/bindings/dma/nvidia,tegra186-gpc-
> dma.yaml
> > @@ -26,6 +26,10 @@ properties:
> > - const: nvidia,tegra194-gpcdma
> > - const: nvidia,tegra186-gpcdma
> >
> > + - items:
> > + - const: nvidia,tegra234-gpcdma
>
> This can be added to the above entry changing it from a const to enum.
>
So, it could look like this, correct?
compatible:
oneOf:
- const: nvidia,tegra186-gpcdma
- items:
- enum:
- nvidia,tegra234-gpcdma
- nvidia,tegra194-gpcdma
- const: nvidia,tegra186-gpcdma
Tried dt_binding_check and dtbs_check with this change and did not see any error.
Regards,
Akhil
--
nvpublic
next prev parent reply other threads:[~2022-07-19 7:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-11 15:45 [PATCH v3 0/3] Add compatible for Tegra234 GPCDMA Akhil R
2022-07-11 15:45 ` [PATCH v3 1/3] dt-bindings: dmaengine: Add compatible for Tegra234 Akhil R
2022-07-13 15:21 ` Jon Hunter
2022-07-18 19:16 ` Rob Herring
2022-07-19 7:41 ` Akhil R [this message]
2022-07-11 15:45 ` [PATCH v3 2/3] dmaengine: tegra: Add terminate() " Akhil R
2022-07-13 15:22 ` Jon Hunter
2022-07-11 15:45 ` [PATCH v3 3/3] arm64: tegra: Update compatible for Tegra234 GPCDMA Akhil R
2022-07-13 15:22 ` Jon Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SJ1PR12MB63391677B9E3249F98D8F1ABC08F9@SJ1PR12MB6339.namprd12.prod.outlook.com \
--to=akhilrajeev@nvidia.com \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=jonathanh@nvidia.com \
--cc=ldewangan@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).