* [PATCH] amdgpu: fix NULL pointer dereference at tonga_check_states_equal
@ 2016-02-23 1:11 Bradley Pankow
2016-02-23 2:21 ` Zhu, Rex
0 siblings, 1 reply; 3+ messages in thread
From: Bradley Pankow @ 2016-02-23 1:11 UTC (permalink / raw)
To: Alex Deucher, Rex Zhu, Jammy Zhou; +Cc: dri-devel, linux-kernel, Bradley Pankow
The event_data passed from pem_fini was not cleared upon initialization.
This caused NULL checks to pass and cast_const_phw_tonga_power_state to
attempt to dereference an invalid pointer. Clear the event_data in
pem_init and pem_fini before calling pem_handle_event.
Signed-off-by: Bradley Pankow <btpankow@gmail.com>
---
drivers/gpu/drm/amd/powerplay/eventmgr/eventmgr.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/powerplay/eventmgr/eventmgr.c b/drivers/gpu/drm/amd/powerplay/eventmgr/eventmgr.c
index 52a3efc..46410e3 100644
--- a/drivers/gpu/drm/amd/powerplay/eventmgr/eventmgr.c
+++ b/drivers/gpu/drm/amd/powerplay/eventmgr/eventmgr.c
@@ -31,7 +31,7 @@
static int pem_init(struct pp_eventmgr *eventmgr)
{
int result = 0;
- struct pem_event_data event_data;
+ struct pem_event_data event_data = { {0} };
/* Initialize PowerPlay feature info */
pem_init_feature_info(eventmgr);
@@ -52,7 +52,7 @@ static int pem_init(struct pp_eventmgr *eventmgr)
static void pem_fini(struct pp_eventmgr *eventmgr)
{
- struct pem_event_data event_data;
+ struct pem_event_data event_data = { {0} };
pem_uninit_featureInfo(eventmgr);
pem_unregister_interrupts(eventmgr);
--
2.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH] amdgpu: fix NULL pointer dereference at tonga_check_states_equal
2016-02-23 1:11 [PATCH] amdgpu: fix NULL pointer dereference at tonga_check_states_equal Bradley Pankow
@ 2016-02-23 2:21 ` Zhu, Rex
2016-02-23 17:50 ` Alex Deucher
0 siblings, 1 reply; 3+ messages in thread
From: Zhu, Rex @ 2016-02-23 2:21 UTC (permalink / raw)
To: Bradley Pankow, Deucher, Alexander; +Cc: dri-devel, linux-kernel
Reviewed-by: Rex Zhu <Rex.Zhu@amd.com>
Best Regards
Rex Zhu
-----Original Message-----
From: Bradley Pankow [mailto:btpankow@gmail.com]
Sent: Tuesday, February 23, 2016 9:12 AM
To: Deucher, Alexander; Zhu, Rex; Zhou, Jammy
Cc: dri-devel@lists.freedesktop.org; linux-kernel@vger.kernel.org; Bradley Pankow
Subject: [PATCH] amdgpu: fix NULL pointer dereference at tonga_check_states_equal
The event_data passed from pem_fini was not cleared upon initialization.
This caused NULL checks to pass and cast_const_phw_tonga_power_state to attempt to dereference an invalid pointer. Clear the event_data in pem_init and pem_fini before calling pem_handle_event.
Signed-off-by: Bradley Pankow <btpankow@gmail.com>
---
drivers/gpu/drm/amd/powerplay/eventmgr/eventmgr.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/powerplay/eventmgr/eventmgr.c b/drivers/gpu/drm/amd/powerplay/eventmgr/eventmgr.c
index 52a3efc..46410e3 100644
--- a/drivers/gpu/drm/amd/powerplay/eventmgr/eventmgr.c
+++ b/drivers/gpu/drm/amd/powerplay/eventmgr/eventmgr.c
@@ -31,7 +31,7 @@
static int pem_init(struct pp_eventmgr *eventmgr) {
int result = 0;
- struct pem_event_data event_data;
+ struct pem_event_data event_data = { {0} };
/* Initialize PowerPlay feature info */
pem_init_feature_info(eventmgr);
@@ -52,7 +52,7 @@ static int pem_init(struct pp_eventmgr *eventmgr)
static void pem_fini(struct pp_eventmgr *eventmgr) {
- struct pem_event_data event_data;
+ struct pem_event_data event_data = { {0} };
pem_uninit_featureInfo(eventmgr);
pem_unregister_interrupts(eventmgr);
--
2.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] amdgpu: fix NULL pointer dereference at tonga_check_states_equal
2016-02-23 2:21 ` Zhu, Rex
@ 2016-02-23 17:50 ` Alex Deucher
0 siblings, 0 replies; 3+ messages in thread
From: Alex Deucher @ 2016-02-23 17:50 UTC (permalink / raw)
To: Zhu, Rex; +Cc: Bradley Pankow, Deucher, Alexander, linux-kernel, dri-devel
Applied. thanks!
Alex
On Mon, Feb 22, 2016 at 9:21 PM, Zhu, Rex <Rex.Zhu@amd.com> wrote:
>
> Reviewed-by: Rex Zhu <Rex.Zhu@amd.com>
>
> Best Regards
> Rex Zhu
>
> -----Original Message-----
> From: Bradley Pankow [mailto:btpankow@gmail.com]
> Sent: Tuesday, February 23, 2016 9:12 AM
> To: Deucher, Alexander; Zhu, Rex; Zhou, Jammy
> Cc: dri-devel@lists.freedesktop.org; linux-kernel@vger.kernel.org; Bradley Pankow
> Subject: [PATCH] amdgpu: fix NULL pointer dereference at tonga_check_states_equal
>
> The event_data passed from pem_fini was not cleared upon initialization.
> This caused NULL checks to pass and cast_const_phw_tonga_power_state to attempt to dereference an invalid pointer. Clear the event_data in pem_init and pem_fini before calling pem_handle_event.
>
> Signed-off-by: Bradley Pankow <btpankow@gmail.com>
> ---
> drivers/gpu/drm/amd/powerplay/eventmgr/eventmgr.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/powerplay/eventmgr/eventmgr.c b/drivers/gpu/drm/amd/powerplay/eventmgr/eventmgr.c
> index 52a3efc..46410e3 100644
> --- a/drivers/gpu/drm/amd/powerplay/eventmgr/eventmgr.c
> +++ b/drivers/gpu/drm/amd/powerplay/eventmgr/eventmgr.c
> @@ -31,7 +31,7 @@
> static int pem_init(struct pp_eventmgr *eventmgr) {
> int result = 0;
> - struct pem_event_data event_data;
> + struct pem_event_data event_data = { {0} };
>
> /* Initialize PowerPlay feature info */
> pem_init_feature_info(eventmgr);
> @@ -52,7 +52,7 @@ static int pem_init(struct pp_eventmgr *eventmgr)
>
> static void pem_fini(struct pp_eventmgr *eventmgr) {
> - struct pem_event_data event_data;
> + struct pem_event_data event_data = { {0} };
>
> pem_uninit_featureInfo(eventmgr);
> pem_unregister_interrupts(eventmgr);
> --
> 2.7.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-02-23 17:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-02-23 1:11 [PATCH] amdgpu: fix NULL pointer dereference at tonga_check_states_equal Bradley Pankow
2016-02-23 2:21 ` Zhu, Rex
2016-02-23 17:50 ` Alex Deucher
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).