* [PATCH -next] scsi: sd_zbc: Remove unused inline functions
@ 2020-07-15 2:55 YueHaibing
2020-07-15 3:09 ` Damien Le Moal
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: YueHaibing @ 2020-07-15 2:55 UTC (permalink / raw)
To: jejb, martin.petersen, axboe, damien.lemoal, johannes.thumshirn
Cc: linux-scsi, linux-kernel, YueHaibing
They are never used, so can remove it.
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/scsi/sd.h | 6 ------
1 file changed, 6 deletions(-)
diff --git a/drivers/scsi/sd.h b/drivers/scsi/sd.h
index 3a74f4b45134..27c0f4e9b1d4 100644
--- a/drivers/scsi/sd.h
+++ b/drivers/scsi/sd.h
@@ -229,17 +229,11 @@ blk_status_t sd_zbc_prepare_zone_append(struct scsi_cmnd *cmd, sector_t *lba,
#else /* CONFIG_BLK_DEV_ZONED */
-static inline int sd_zbc_init(void)
-{
- return 0;
-}
-
static inline int sd_zbc_init_disk(struct scsi_disk *sdkp)
{
return 0;
}
-static inline void sd_zbc_exit(void) {}
static inline void sd_zbc_release_disk(struct scsi_disk *sdkp) {}
static inline int sd_zbc_read_zones(struct scsi_disk *sdkp,
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH -next] scsi: sd_zbc: Remove unused inline functions
2020-07-15 2:55 [PATCH -next] scsi: sd_zbc: Remove unused inline functions YueHaibing
@ 2020-07-15 3:09 ` Damien Le Moal
2020-07-15 7:13 ` Johannes Thumshirn
2020-07-15 22:14 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Damien Le Moal @ 2020-07-15 3:09 UTC (permalink / raw)
To: YueHaibing, jejb, martin.petersen, axboe, Johannes Thumshirn
Cc: linux-scsi, linux-kernel
On 2020/07/15 11:56, YueHaibing wrote:
> They are never used, so can remove it.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/scsi/sd.h | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/scsi/sd.h b/drivers/scsi/sd.h
> index 3a74f4b45134..27c0f4e9b1d4 100644
> --- a/drivers/scsi/sd.h
> +++ b/drivers/scsi/sd.h
> @@ -229,17 +229,11 @@ blk_status_t sd_zbc_prepare_zone_append(struct scsi_cmnd *cmd, sector_t *lba,
>
> #else /* CONFIG_BLK_DEV_ZONED */
>
> -static inline int sd_zbc_init(void)
> -{
> - return 0;
> -}
> -
> static inline int sd_zbc_init_disk(struct scsi_disk *sdkp)
> {
> return 0;
> }
>
> -static inline void sd_zbc_exit(void) {}
> static inline void sd_zbc_release_disk(struct scsi_disk *sdkp) {}
>
> static inline int sd_zbc_read_zones(struct scsi_disk *sdkp,
>
Reviewed-by: Damien Le Moal <damien.lemoal@wdc.com>
--
Damien Le Moal
Western Digital Research
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next] scsi: sd_zbc: Remove unused inline functions
2020-07-15 2:55 [PATCH -next] scsi: sd_zbc: Remove unused inline functions YueHaibing
2020-07-15 3:09 ` Damien Le Moal
@ 2020-07-15 7:13 ` Johannes Thumshirn
2020-07-15 22:14 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Johannes Thumshirn @ 2020-07-15 7:13 UTC (permalink / raw)
To: YueHaibing, jejb, martin.petersen, axboe, Damien Le Moal
Cc: linux-scsi, linux-kernel
On 15/07/2020 04:56, YueHaibing wrote:
> They are never used, so can remove it.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/scsi/sd.h | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/scsi/sd.h b/drivers/scsi/sd.h
> index 3a74f4b45134..27c0f4e9b1d4 100644
> --- a/drivers/scsi/sd.h
> +++ b/drivers/scsi/sd.h
> @@ -229,17 +229,11 @@ blk_status_t sd_zbc_prepare_zone_append(struct scsi_cmnd *cmd, sector_t *lba,
>
> #else /* CONFIG_BLK_DEV_ZONED */
>
> -static inline int sd_zbc_init(void)
> -{
> - return 0;
> -}
> -
> static inline int sd_zbc_init_disk(struct scsi_disk *sdkp)
> {
> return 0;
> }
>
> -static inline void sd_zbc_exit(void) {}
> static inline void sd_zbc_release_disk(struct scsi_disk *sdkp) {}
>
> static inline int sd_zbc_read_zones(struct scsi_disk *sdkp,
>
Woops that looks like some leftover from development. My bad.
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next] scsi: sd_zbc: Remove unused inline functions
2020-07-15 2:55 [PATCH -next] scsi: sd_zbc: Remove unused inline functions YueHaibing
2020-07-15 3:09 ` Damien Le Moal
2020-07-15 7:13 ` Johannes Thumshirn
@ 2020-07-15 22:14 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2020-07-15 22:14 UTC (permalink / raw)
To: jejb, YueHaibing, damien.lemoal, axboe, johannes.thumshirn
Cc: Martin K . Petersen, linux-scsi, linux-kernel
On Wed, 15 Jul 2020 10:55:23 +0800, YueHaibing wrote:
> They are never used, so can remove it.
Applied to 5.9/scsi-queue, thanks!
[1/1] scsi: sd_zbc: Remove unused inline functions
https://git.kernel.org/mkp/scsi/c/ca0800a68ac7
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-07-15 22:16 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-15 2:55 [PATCH -next] scsi: sd_zbc: Remove unused inline functions YueHaibing
2020-07-15 3:09 ` Damien Le Moal
2020-07-15 7:13 ` Johannes Thumshirn
2020-07-15 22:14 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).