linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH V3] arm64: dts: qcom: sm8150: Fix the I2C7 interrupt
@ 2023-07-27  2:53 Zeyan Li
  2023-07-27  6:51 ` Krzysztof Kozlowski
  2023-07-31 23:52 ` Bjorn Andersson
  0 siblings, 2 replies; 3+ messages in thread
From: Zeyan Li @ 2023-07-27  2:53 UTC (permalink / raw)
  To: andersson, agross, konrad.dybcio, robh+dt,
	krzysztof.kozlowski+dt, conor+dt
  Cc: linux-arm-msm, devicetree, linux-kernel, Zeyan Li

I2C6 and I2C7 use the same interrupts, which is incorrect.
In the downstream kernel, I2C7 has interrupts of 608 instead of 607.

Fixes: 81bee6953b58 ("arm64: dts: qcom: sm8150: add i2c nodes")
Signed-off-by: Zeyan Li <qaz6750@outlook.com>
---
 [v3] Change to use my real name
 [v2] Fixed issue of not using full name

 arch/arm64/boot/dts/qcom/sm8150.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi b/arch/arm64/boot/dts/qcom/sm8150.dtsi
index 18c822abdb88..214f6e028f3c 100644
--- a/arch/arm64/boot/dts/qcom/sm8150.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8150.dtsi
@@ -1231,7 +1231,7 @@ i2c7: i2c@89c000 {
 				dma-names = "tx", "rx";
 				pinctrl-names = "default";
 				pinctrl-0 = <&qup_i2c7_default>;
-				interrupts = <GIC_SPI 607 IRQ_TYPE_LEVEL_HIGH>;
+				interrupts = <GIC_SPI 608 IRQ_TYPE_LEVEL_HIGH>;
 				#address-cells = <1>;
 				#size-cells = <0>;
 				status = "disabled";
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH V3] arm64: dts: qcom: sm8150: Fix the I2C7 interrupt
  2023-07-27  2:53 [PATCH V3] arm64: dts: qcom: sm8150: Fix the I2C7 interrupt Zeyan Li
@ 2023-07-27  6:51 ` Krzysztof Kozlowski
  2023-07-31 23:52 ` Bjorn Andersson
  1 sibling, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2023-07-27  6:51 UTC (permalink / raw)
  To: Zeyan Li, andersson, agross, konrad.dybcio, robh+dt,
	krzysztof.kozlowski+dt, conor+dt
  Cc: linux-arm-msm, devicetree, linux-kernel

On 27/07/2023 04:53, Zeyan Li wrote:
> I2C6 and I2C7 use the same interrupts, which is incorrect.
> In the downstream kernel, I2C7 has interrupts of 608 instead of 607.
> 
> Fixes: 81bee6953b58 ("arm64: dts: qcom: sm8150: add i2c nodes")
> Signed-off-by: Zeyan Li <qaz6750@outlook.com>
> ---
>  [v3] Change to use my real name
>  [v2] Fixed issue of not using full name

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>


---

This is an automated instruction, just in case, because many review tags
are being ignored. If you know the process, you can skip it (please do
not feel offended by me posting it here - no bad intentions intended).
If you do not know the process, here is a short explanation:

Please add Acked-by/Reviewed-by/Tested-by tags when posting new
versions, under or above your Signed-off-by tag. Tag is "received", when
provided in a message replied to you on the mailing list. Tools like b4
can help here. However, there's no need to repost patches *only* to add
the tags. The upstream maintainer will do that for tags received on the
version they apply.

https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH V3] arm64: dts: qcom: sm8150: Fix the I2C7 interrupt
  2023-07-27  2:53 [PATCH V3] arm64: dts: qcom: sm8150: Fix the I2C7 interrupt Zeyan Li
  2023-07-27  6:51 ` Krzysztof Kozlowski
@ 2023-07-31 23:52 ` Bjorn Andersson
  1 sibling, 0 replies; 3+ messages in thread
From: Bjorn Andersson @ 2023-07-31 23:52 UTC (permalink / raw)
  To: agross, konrad.dybcio, robh+dt, krzysztof.kozlowski+dt, conor+dt,
	Zeyan Li
  Cc: linux-arm-msm, devicetree, linux-kernel


On Thu, 27 Jul 2023 10:53:21 +0800, Zeyan Li wrote:
> I2C6 and I2C7 use the same interrupts, which is incorrect.
> In the downstream kernel, I2C7 has interrupts of 608 instead of 607.
> 
> 

Applied, thanks!

[1/1] arm64: dts: qcom: sm8150: Fix the I2C7 interrupt
      commit: f9568d22ce06192a7e14bda3a29dc216659554ff

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-07-31 23:50 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-27  2:53 [PATCH V3] arm64: dts: qcom: sm8150: Fix the I2C7 interrupt Zeyan Li
2023-07-27  6:51 ` Krzysztof Kozlowski
2023-07-31 23:52 ` Bjorn Andersson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).