[PATCH 0/2] mips: pci-mt7620: reduce unnecessary error logs

[PATCH 0/2] mips: pci-mt7620: reduce unnecessary error logs

[Shiji Yang]

These patches silence some mt7620 PCIe driver error messeges by
removing the useless debugging codes and replacing incorrectly
used 'dev_err()' with 'dev_info()'. 

Shiji Yang (2):
  mips: pci-mt7620: do not print NFTS register value as error log
  mips: pci-mt7620: use dev_info() to log PCIe device detection result

 arch/mips/pci/pci-mt7620.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

-- 
2.30.2

Re: [PATCH 0/2] mips: pci-mt7620: reduce unnecessary error logs

[Sergio Paracuellos]

On Tue, Jun 20, 2023 at 12:48 PM Shiji Yang <yangshiji66@outlook.com> wrote:
>
> These patches silence some mt7620 PCIe driver error messeges by
> removing the useless debugging codes and replacing incorrectly
> used 'dev_err()' with 'dev_info()'.
>
> Shiji Yang (2):
>   mips: pci-mt7620: do not print NFTS register value as error log
>   mips: pci-mt7620: use dev_info() to log PCIe device detection result
>
>  arch/mips/pci/pci-mt7620.c | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)

For the series:
Reviewed-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>

I'd really love to have this driver ported to PCI_DRIVERS_GENERIC
moved to 'drivers/pci/controller/pcie-mt7621.c' since they are pretty
similar just changing that mt7620 and mt7628 init the hardware
different and only use one virtual bridge. My problem is that I don't
have and cannot find hardware to test. Do you have interest in helping
me to do this?

Thanks,
    Sergio Paracuellos

>
> --
> 2.30.2
>

Re: [PATCH 0/2] mips: pci-mt7620: reduce unnecessary error logs

[Shiji Yang]

>On Tue, Jun 20, 2023 at 12:48 PM Shiji Yang <yangshiji66@outlook.com> wrote:
>>
>> These patches silence some mt7620 PCIe driver error messeges by
>> removing the useless debugging codes and replacing incorrectly
>> used 'dev_err()' with 'dev_info()'.
>>
>> Shiji Yang (2):
>>   mips: pci-mt7620: do not print NFTS register value as error log
>>   mips: pci-mt7620: use dev_info() to log PCIe device detection result
>>
>>  arch/mips/pci/pci-mt7620.c | 7 ++-----
>>  1 file changed, 2 insertions(+), 5 deletions(-)
>
>For the series:
>Reviewed-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
>
>I'd really love to have this driver ported to PCI_DRIVERS_GENERIC
>moved to 'drivers/pci/controller/pcie-mt7621.c' since they are pretty
>similar just changing that mt7620 and mt7628 init the hardware
>different and only use one virtual bridge. My problem is that I don't
>have and cannot find hardware to test. Do you have interest in helping
>me to do this?

Thanks,
    Sergio Paracuellos

Thank you for rewriting these drivers! I am glad to help test them. Please
let me know at any time when they are ready.

Best regards,
    Shiji Yang

Re: [PATCH 0/2] mips: pci-mt7620: reduce unnecessary error logs

[Sergio Paracuellos]

On Wed, Jun 21, 2023 at 3:04 AM Shiji Yang <yangshiji66@outlook.com> wrote:
>
> >On Tue, Jun 20, 2023 at 12:48 PM Shiji Yang <yangshiji66@outlook.com> wrote:
> >>
> >> These patches silence some mt7620 PCIe driver error messeges by
> >> removing the useless debugging codes and replacing incorrectly
> >> used 'dev_err()' with 'dev_info()'.
> >>
> >> Shiji Yang (2):
> >>   mips: pci-mt7620: do not print NFTS register value as error log
> >>   mips: pci-mt7620: use dev_info() to log PCIe device detection result
> >>
> >>  arch/mips/pci/pci-mt7620.c | 7 ++-----
> >>  1 file changed, 2 insertions(+), 5 deletions(-)
> >
> >For the series:
> >Reviewed-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
> >
> >I'd really love to have this driver ported to PCI_DRIVERS_GENERIC
> >moved to 'drivers/pci/controller/pcie-mt7621.c' since they are pretty
> >similar just changing that mt7620 and mt7628 init the hardware
> >different and only use one virtual bridge. My problem is that I don't
> >have and cannot find hardware to test. Do you have interest in helping
> >me to do this?
>
> Thanks,
>     Sergio Paracuellos
>
> Thank you for rewriting these drivers! I am glad to help test them. Please
> let me know at any time when they are ready.

Thanks! I need to build time for this but I will do it for sure at any
time and let you know.

Best regards,
    Sergio Paracuellos
>
> Best regards,
>     Shiji Yang

Re: [PATCH 0/2] mips: pci-mt7620: reduce unnecessary error logs

[Thomas Bogendoerfer]

On Tue, Jun 20, 2023 at 06:43:21PM +0800, Shiji Yang wrote:
> These patches silence some mt7620 PCIe driver error messeges by
> removing the useless debugging codes and replacing incorrectly
> used 'dev_err()' with 'dev_info()'. 
> 
> Shiji Yang (2):
>   mips: pci-mt7620: do not print NFTS register value as error log
>   mips: pci-mt7620: use dev_info() to log PCIe device detection result
> 
>  arch/mips/pci/pci-mt7620.c | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)

series applied to mips-next.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]