From: "tan.shaopeng@fujitsu.com" <tan.shaopeng@fujitsu.com>
To: 'James Morse' <james.morse@arm.com>,
"'x86@kernel.org'" <x86@kernel.org>,
"'linux-kernel@vger.kernel.org'" <linux-kernel@vger.kernel.org>
Cc: 'Fenghua Yu' <fenghua.yu@intel.com>,
'Reinette Chatre' <reinette.chatre@intel.com>,
'Thomas Gleixner' <tglx@linutronix.de>,
'Ingo Molnar' <mingo@redhat.com>,
'Borislav Petkov' <bp@alien8.de>, 'H Peter Anvin' <hpa@zytor.com>,
'Babu Moger' <Babu.Moger@amd.com>,
"'shameerali.kolothum.thodi@huawei.com'"
<shameerali.kolothum.thodi@huawei.com>,
'Jamie Iles' <jamie@nuviainc.com>,
'D Scott Phillips OS' <scott@os.amperecomputing.com>,
"'lcherian@marvell.com'" <lcherian@marvell.com>,
"'bobo.shaobowang@huawei.com'" <bobo.shaobowang@huawei.com>,
"tan.shaopeng@fujitsu.com" <tan.shaopeng@fujitsu.com>
Subject: RE: [PATCH v1 13/20] x86/recstrl: Allow per-rmid arch private storage to be reset
Date: Fri, 24 Sep 2021 06:34:55 +0000 [thread overview]
Message-ID: <TYAPR01MB633030707DD9C8AF6A2FEBA08BA49@TYAPR01MB6330.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <20210729223610.29373-14-james.morse@arm.com>
Hi James,
> To abstract the rmid counters into a helper that returns the number of bytes
> counted, architecture specific per-rmid state is needed.
>
> It needs to be possible to reset this hidden state, as the values may outlive the
> life of an rmid, or the mount time of the filesystem.
>
> mon_event_read() is called with first = true when an rmid is first allocated in
> mkdir_mondata_subdir(). Add resctrl_arch_reset_rmid() and call it from
> __mon_event_count()'s rr->first check.
>
> Signed-off-by: James Morse <james.morse@arm.com>
> ---
> arch/x86/kernel/cpu/resctrl/internal.h | 18 ++++--------
> arch/x86/kernel/cpu/resctrl/monitor.c | 38
> +++++++++++++++++++++-----
> include/linux/resctrl.h | 23 ++++++++++++++++
> 3 files changed, 59 insertions(+), 20 deletions(-)
>
> diff --git a/arch/x86/kernel/cpu/resctrl/internal.h
> b/arch/x86/kernel/cpu/resctrl/internal.h
> index aaae900a8ef3..f3f31315a907 100644
> --- a/arch/x86/kernel/cpu/resctrl/internal.h
> +++ b/arch/x86/kernel/cpu/resctrl/internal.h
> @@ -22,14 +22,6 @@
>
> #define L2_QOS_CDP_ENABLE 0x01ULL
>
> -/*
> - * Event IDs are used to program IA32_QM_EVTSEL before reading event
> - * counter from IA32_QM_CTR
> - */
> -#define QOS_L3_OCCUP_EVENT_ID 0x01
> -#define QOS_L3_MBM_TOTAL_EVENT_ID 0x02
> -#define QOS_L3_MBM_LOCAL_EVENT_ID 0x03
> -
> #define CQM_LIMBOCHECK_INTERVAL 1000
>
> #define MBM_CNTR_WIDTH_BASE 24
> @@ -73,7 +65,7 @@ DECLARE_STATIC_KEY_FALSE(rdt_mon_enable_key);
> * @list: entry in &rdt_resource->evt_list
> */
> struct mon_evt {
> - u32 evtid;
> + enum resctrl_event_id evtid;
> char *name;
> struct list_head list;
> };
> @@ -90,9 +82,9 @@ struct mon_evt {
> union mon_data_bits {
> void *priv;
> struct {
> - unsigned int rid : 10;
> - unsigned int evtid : 8;
> - unsigned int domid : 14;
> + unsigned int rid : 10;
> + enum resctrl_event_id evtid : 8;
> + unsigned int domid : 14;
> } u;
> };
>
> @@ -100,7 +92,7 @@ struct rmid_read {
> struct rdtgroup *rgrp;
> struct rdt_resource *r;
> struct rdt_domain *d;
> - int evtid;
> + enum resctrl_event_id evtid;
> bool first;
> u64 val;
> };
> diff --git a/arch/x86/kernel/cpu/resctrl/monitor.c
> b/arch/x86/kernel/cpu/resctrl/monitor.c
> index af60e154f0ed..3b8b29470a5c 100644
> --- a/arch/x86/kernel/cpu/resctrl/monitor.c
> +++ b/arch/x86/kernel/cpu/resctrl/monitor.c
> @@ -137,7 +137,34 @@ static inline struct rmid_entry *__rmid_entry(u32 rmid)
> return entry;
> }
>
> -static u64 __rmid_read(u32 rmid, u32 eventid)
> +static struct arch_mbm_state *get_arch_mbm_state(struct rdt_hw_domain
> *hw_dom,
> + u32 rmid,
> + enum resctrl_event_id
> eventid)
> +{
> + switch (eventid) {
> + case QOS_L3_OCCUP_EVENT_ID:
> + return NULL;
> + case QOS_L3_MBM_TOTAL_EVENT_ID:
> + return &hw_dom->arch_mbm_total[rmid];
> + case QOS_L3_MBM_LOCAL_EVENT_ID:
> + return &hw_dom->arch_mbm_local[rmid];
> + }
> +
Since it is unexpected to come here,
it might be better to add WARN_ON.
In addition, I have tested these patches on Intel(R) Xeon(R) Gold 6254 CPU with resctrl selftest. It is no problem.
Thanks,
Shaopeng Tan
> + return NULL;
> +}
> +
> +void resctrl_arch_reset_rmid(struct rdt_resource *r, struct rdt_domain *d,
> + u32 rmid, enum resctrl_event_id eventid) {
> + struct rdt_hw_domain *hw_dom = resctrl_to_arch_dom(d);
> + struct arch_mbm_state *m;
> +
> + m = get_arch_mbm_state(hw_dom, rmid, eventid);
> + if (m)
> + memset(m, 0, sizeof(*m));
> +}
> +
> +static u64 __rmid_read(u32 rmid, enum resctrl_event_id eventid)
> {
> u64 val;
>
> @@ -291,6 +318,9 @@ static int __mon_event_count(u32 rmid, struct
> rmid_read *rr)
> struct mbm_state *m;
> u64 chunks, tval;
>
> + if (rr->first)
> + resctrl_arch_reset_rmid(rr->r, rr->d, rmid, rr->evtid);
> +
> tval = __rmid_read(rmid, rr->evtid);
> if (tval & (RMID_VAL_ERROR | RMID_VAL_UNAVAIL)) {
> rr->val = tval;
> @@ -306,12 +336,6 @@ static int __mon_event_count(u32 rmid, struct
> rmid_read *rr)
> case QOS_L3_MBM_LOCAL_EVENT_ID:
> m = &rr->d->mbm_local[rmid];
> break;
> - default:
> - /*
> - * Code would never reach here because
> - * an invalid event id would fail the __rmid_read.
> - */
> - return -EINVAL;
> }
>
> if (rr->first) {
> diff --git a/include/linux/resctrl.h b/include/linux/resctrl.h index
> 4fe2d5500315..79e83ce3dfbc 100644
> --- a/include/linux/resctrl.h
> +++ b/include/linux/resctrl.h
> @@ -32,6 +32,16 @@ enum resctrl_conf_type {
>
> #define CDP_NUM_TYPES (CDP_DATA + 1)
>
> +/*
> + * Event IDs, the values match those used to program IA32_QM_EVTSEL
> +before
> + * reading IA32_QM_CTR on RDT systems.
> + */
> +enum resctrl_event_id {
> + QOS_L3_OCCUP_EVENT_ID = 0x01,
> + QOS_L3_MBM_TOTAL_EVENT_ID = 0x02,
> + QOS_L3_MBM_LOCAL_EVENT_ID = 0x03,
> +};
> +
> /**
> * struct resctrl_staged_config - parsed configuration to be applied
> * @new_ctrl: new ctrl value to be loaded
> @@ -219,4 +229,17 @@ void resctrl_arch_get_config(struct rdt_resource *r,
> struct rdt_domain *d, int resctrl_online_domain(struct rdt_resource *r, struct
> rdt_domain *d); void resctrl_offline_domain(struct rdt_resource *r, struct
> rdt_domain *d);
>
> +/**
> + * resctrl_arch_reset_rmid() - Reset any private state associated with rmid
> + * and eventid.
> + * @r: The domain's resource.
> + * @d: The rmid's domain.
> + * @rmid: The rmid whose counter values should be reset.
> + * @eventid: The eventid whose counter values should be reset.
> + *
> + * This can be called from any CPU.
> + */
> +void resctrl_arch_reset_rmid(struct rdt_resource *r, struct rdt_domain *d,
> + u32 rmid, enum resctrl_event_id eventid);
> +
> #endif /* _RESCTRL_H */
> --
> 2.30.2
next prev parent reply other threads:[~2021-09-24 6:42 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-29 22:35 [PATCH v1 00/20] x86/resctrl: Make resctrl_arch_rmid_read() return values in bytes James Morse
2021-07-29 22:35 ` [PATCH v1 01/20] x86/resctrl: Kill off alloc_enabled James Morse
2021-08-11 12:12 ` Jamie Iles
2021-09-01 21:18 ` Reinette Chatre
2021-07-29 22:35 ` [PATCH v1 02/20] x86/resctrl: Merge mon_capable and mon_enabled James Morse
2021-08-11 12:15 ` Jamie Iles
2021-08-11 15:16 ` James Morse
2021-07-29 22:35 ` [PATCH v1 03/20] x86/resctrl: Add domain online callback for resctrl work James Morse
2021-09-01 21:19 ` Reinette Chatre
2021-09-17 16:57 ` James Morse
2021-07-29 22:35 ` [PATCH v1 04/20] x86/resctrl: Add domain offline " James Morse
2021-08-11 16:10 ` Jamie Iles
2021-09-01 21:21 ` Reinette Chatre
2021-07-29 22:35 ` [PATCH v1 05/20] x86/resctrl: Create mba_sc configuration in the rdt_domain James Morse
2021-08-11 16:32 ` Jamie Iles
2021-08-31 16:24 ` James Morse
2021-09-01 21:22 ` Reinette Chatre
2021-09-17 16:57 ` James Morse
2021-07-29 22:35 ` [PATCH v1 06/20] x86/resctrl: Switch over to the resctrl mbps_val list James Morse
2021-09-01 21:25 ` Reinette Chatre
2021-09-17 16:57 ` James Morse
2021-09-17 18:20 ` Reinette Chatre
2021-10-01 16:02 ` James Morse
2021-07-29 22:35 ` [PATCH v1 07/20] x86/resctrl: Remove architecture copy of mbps_val James Morse
2021-09-01 21:26 ` Reinette Chatre
2021-09-17 16:57 ` James Morse
2021-07-29 22:35 ` [PATCH v1 08/20] x86/resctrl: Remove set_mba_sc()s control array re-initialisation James Morse
2021-07-29 22:35 ` [PATCH v1 09/20] x86/resctrl: Abstract and use supports_mba_mbps() James Morse
2021-09-01 21:27 ` Reinette Chatre
2021-09-17 16:57 ` James Morse
2021-09-24 6:23 ` tan.shaopeng
2021-10-01 16:01 ` James Morse
2021-07-29 22:36 ` [PATCH v1 10/20] x86/resctrl: Allow update_mba_bw() to update controls directly James Morse
2021-09-01 21:28 ` Reinette Chatre
2021-07-29 22:36 ` [PATCH v1 11/20] x86/resctrl: Calculate bandwidth from the total bytes counter James Morse
2021-09-01 21:31 ` Reinette Chatre
2021-09-17 16:58 ` James Morse
2021-07-29 22:36 ` [PATCH v1 12/20] x86/recstrl: Add per-rmid arch private storage for overflow and chunks James Morse
2021-08-11 17:14 ` Jamie Iles
2021-08-31 16:25 ` James Morse
2021-07-29 22:36 ` [PATCH v1 13/20] x86/recstrl: Allow per-rmid arch private storage to be reset James Morse
2021-09-24 6:34 ` tan.shaopeng [this message]
2021-10-01 16:01 ` James Morse
2021-07-29 22:36 ` [PATCH v1 14/20] x86/resctrl: Abstract __rmid_read() James Morse
2021-07-29 22:36 ` [PATCH v1 15/20] x86/resctrl: Pass the required parameters into resctrl_arch_rmid_read() James Morse
2021-07-29 22:36 ` [PATCH v1 16/20] x86/resctrl: Move mbm_overflow_count() " James Morse
2021-07-29 22:36 ` [PATCH v1 17/20] x86/resctrl: Move get_corrected_mbm_count() " James Morse
2021-07-29 22:36 ` [PATCH v1 18/20] x86/resctrl: Rename and change the units of resctrl_cqm_threshold James Morse
2021-07-29 22:36 ` [PATCH v1 19/20] x86/resctrl: Add resctrl_rmid_realloc_limit to abstract x86's boot_cpu_data James Morse
2021-07-29 22:36 ` [PATCH v1 20/20] x86/resctrl: Make resctrl_arch_rmid_read() return values in bytes James Morse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=TYAPR01MB633030707DD9C8AF6A2FEBA08BA49@TYAPR01MB6330.jpnprd01.prod.outlook.com \
--to=tan.shaopeng@fujitsu.com \
--cc=Babu.Moger@amd.com \
--cc=bobo.shaobowang@huawei.com \
--cc=bp@alien8.de \
--cc=fenghua.yu@intel.com \
--cc=hpa@zytor.com \
--cc=james.morse@arm.com \
--cc=jamie@nuviainc.com \
--cc=lcherian@marvell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=reinette.chatre@intel.com \
--cc=scott@os.amperecomputing.com \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).