From: "d.hatayama@fujitsu.com" <d.hatayama@fujitsu.com>
To: "Guilherme G. Piccoli" <gpiccoli@igalia.com>,
"kexec@lists.infradead.org" <kexec@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"dyoung@redhat.com" <dyoung@redhat.com>
Cc: "linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"bhe@redhat.com" <bhe@redhat.com>,
"vgoyal@redhat.com" <vgoyal@redhat.com>,
"stern@rowland.harvard.edu" <stern@rowland.harvard.edu>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"andriy.shevchenko@linux.intel.com"
<andriy.shevchenko@linux.intel.com>,
"corbet@lwn.net" <corbet@lwn.net>,
"halves@canonical.com" <halves@canonical.com>,
"kernel@gpiccoli.net" <kernel@gpiccoli.net>,
"d.hatayama@fujitsu.com" <d.hatayama@fujitsu.com>
Subject: Re: [PATCH V4] notifier/panic: Introduce panic_notifier_filter
Date: Tue, 25 Jan 2022 13:06:47 +0000 [thread overview]
Message-ID: <TYAPR01MB6507D9747647685B554B8F8F955F9@TYAPR01MB6507.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <fda509a5-ea0d-4d1d-a1c1-ca5e80010fc0@igalia.com>
> Hi, thanks for the review. First of all, notice that it's very likely
> this patch isn't gonna get merged this way, we are considering a
> refactor that included 2 panic notifiers: one a bit earlier (pre_dump),
> that includes functions less risky, as watchdog unloaders, kernel offset
> dump, etc, and the second panic notifier (post_dump) will keep the
> majority of callbacks, and can be conditionally executed on kdump
> through the usage of "crash_kexec_post_notifiers".
But the pre_dump cannot avoid calling multiple unnecessary handlers, right?
It's more risky than the previous idea...
> Anyway, I'm curious with your code review - how can we use this filter
> with modules, if the filter setup is invoked as early_param(), before
> modules load? In that case, module functions won't have a valid address,
> correct? So, in that moment, this lookup fails, we cannot record an
> unloaded module address in such list. Please, correct me if I'm wrong.
For example, how about simply maintaining function symbol names in the list
as string, not address.
Thanks.
HATAYAMA, Daisuke
next prev parent reply other threads:[~2022-01-25 13:10 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-08 15:34 [PATCH V4] notifier/panic: Introduce panic_notifier_filter Guilherme G. Piccoli
2022-01-14 19:03 ` Guilherme G. Piccoli
[not found] ` <CALu+AoR+GrCpf0gqsx_XYETBGUAfRyP+SPNarK179hT7iQmCqQ@mail.gmail.com>
2022-01-18 13:22 ` Guilherme G. Piccoli
2022-01-16 13:11 ` Baoquan He
2022-01-17 12:59 ` Guilherme G. Piccoli
2022-01-20 15:14 ` Petr Mladek
2022-01-21 20:31 ` Guilherme G. Piccoli
2022-01-22 10:55 ` Baoquan He
2022-01-23 13:07 ` Masami Hiramatsu
2022-01-24 13:59 ` Baoquan He
2022-01-24 14:48 ` Guilherme G. Piccoli
2022-01-26 3:10 ` Baoquan He
2022-01-26 12:20 ` d.hatayama
2022-01-26 13:20 ` Petr Mladek
2022-01-30 8:50 ` Baoquan He
2022-01-24 11:43 ` d.hatayama
2022-01-24 14:15 ` Baoquan He
2022-01-25 11:50 ` d.hatayama
2022-01-25 12:34 ` Guilherme G. Piccoli
2022-01-25 13:06 ` d.hatayama [this message]
2022-01-27 17:16 ` Guilherme G. Piccoli
2022-01-28 13:38 ` Petr Mladek
2022-02-08 18:51 ` Guilherme G. Piccoli
2022-02-09 0:31 ` bhe
2022-02-10 16:39 ` Guilherme G. Piccoli
2022-02-10 17:26 ` Michael Kelley (LINUX)
2022-02-10 17:50 ` Guilherme G. Piccoli
2022-03-06 14:21 ` Guilherme G. Piccoli
2022-03-07 3:42 ` bhe
2022-03-07 13:11 ` Guilherme G. Piccoli
2022-03-07 14:04 ` bhe
2022-03-07 14:25 ` Guilherme G. Piccoli
2022-03-08 12:54 ` Petr Mladek
2022-03-08 13:04 ` Guilherme G. Piccoli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=TYAPR01MB6507D9747647685B554B8F8F955F9@TYAPR01MB6507.jpnprd01.prod.outlook.com \
--to=d.hatayama@fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bhe@redhat.com \
--cc=corbet@lwn.net \
--cc=dyoung@redhat.com \
--cc=gpiccoli@igalia.com \
--cc=halves@canonical.com \
--cc=kernel@gpiccoli.net \
--cc=kexec@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).