* [PATCH 1/3] scripts/gdb: fix lx-timerlist for struct timequeue_head change
@ 2023-03-21 6:18 Peng Liu
0 siblings, 0 replies; 6+ messages in thread
From: Peng Liu @ 2023-03-21 6:18 UTC (permalink / raw)
Cc: jan.kiszka, kbingham, akpm, linux-kernel, liupeng17
From: Peng Liu <liupeng17@lenovo.com>
commit 511885d7061e ("lib/timerqueue: Rely on rbtree semantics for next
timer") changed struct timerqueue_head, and so print_active_timers()
should be changed accordingly with its way to interpret the structure.
Signed-off-by: Peng Liu <liupeng17@lenovo.com>
Reviewed-by: Jan Kiszka <jan.kiszka@siemens.com>
---
scripts/gdb/linux/timerlist.py | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/scripts/gdb/linux/timerlist.py b/scripts/gdb/linux/timerlist.py
index 071d0dd5a634..44e39dc3eb64 100644
--- a/scripts/gdb/linux/timerlist.py
+++ b/scripts/gdb/linux/timerlist.py
@@ -43,8 +43,7 @@ def print_timer(rb_node, idx):
def print_active_timers(base):
- curr = base['active']['next']['node']
- curr = curr.address.cast(rbtree.rb_node_type.get_type().pointer())
+ curr = base['active']['rb_root']['rb_leftmost']
idx = 0
while curr:
yield print_timer(curr, idx)
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 1/3] scripts/gdb: fix lx-timerlist for struct timequeue_head change
@ 2022-07-20 12:27 pngliu
2022-08-04 8:49 ` Peng Liu
2022-08-31 15:00 ` Jan Kiszka
0 siblings, 2 replies; 6+ messages in thread
From: pngliu @ 2022-07-20 12:27 UTC (permalink / raw)
To: jan.kiszka, kbingham; +Cc: linux-kernel, Peng Liu
From: Peng Liu <liupeng17@lenovo.com>
commit 511885d7061e ("lib/timerqueue: Rely on rbtree semantics for next
timer") changed struct timerqueue_head, and so print_active_timers()
should be changed accordingly with its way to interpret the structure.
Signed-off-by: Peng Liu <liupeng17@lenovo.com>
---
scripts/gdb/linux/timerlist.py | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/scripts/gdb/linux/timerlist.py b/scripts/gdb/linux/timerlist.py
index 071d0dd5a634..44e39dc3eb64 100644
--- a/scripts/gdb/linux/timerlist.py
+++ b/scripts/gdb/linux/timerlist.py
@@ -43,8 +43,7 @@ def print_timer(rb_node, idx):
def print_active_timers(base):
- curr = base['active']['next']['node']
- curr = curr.address.cast(rbtree.rb_node_type.get_type().pointer())
+ curr = base['active']['rb_root']['rb_leftmost']
idx = 0
while curr:
yield print_timer(curr, idx)
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 1/3] scripts/gdb: fix lx-timerlist for struct timequeue_head change
2022-07-20 12:27 pngliu
@ 2022-08-04 8:49 ` Peng Liu
2022-08-22 9:29 ` Peng Liu
2022-08-31 15:00 ` Jan Kiszka
1 sibling, 1 reply; 6+ messages in thread
From: Peng Liu @ 2022-08-04 8:49 UTC (permalink / raw)
To: jan.kiszka, kbingham; +Cc: linux-kernel, Peng Liu
ping
On 2022/7/20 20:27, pngliu@hotmail.com wrote:
> From: Peng Liu <liupeng17@lenovo.com>
>
> commit 511885d7061e ("lib/timerqueue: Rely on rbtree semantics for next
> timer") changed struct timerqueue_head, and so print_active_timers()
> should be changed accordingly with its way to interpret the structure.
>
> Signed-off-by: Peng Liu <liupeng17@lenovo.com>
> ---
> scripts/gdb/linux/timerlist.py | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/scripts/gdb/linux/timerlist.py b/scripts/gdb/linux/timerlist.py
> index 071d0dd5a634..44e39dc3eb64 100644
> --- a/scripts/gdb/linux/timerlist.py
> +++ b/scripts/gdb/linux/timerlist.py
> @@ -43,8 +43,7 @@ def print_timer(rb_node, idx):
>
>
> def print_active_timers(base):
> - curr = base['active']['next']['node']
> - curr = curr.address.cast(rbtree.rb_node_type.get_type().pointer())
> + curr = base['active']['rb_root']['rb_leftmost']
> idx = 0
> while curr:
> yield print_timer(curr, idx)
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 1/3] scripts/gdb: fix lx-timerlist for struct timequeue_head change
2022-08-04 8:49 ` Peng Liu
@ 2022-08-22 9:29 ` Peng Liu
2022-08-31 2:01 ` Peng Liu
0 siblings, 1 reply; 6+ messages in thread
From: Peng Liu @ 2022-08-22 9:29 UTC (permalink / raw)
To: jan.kiszka; +Cc: kbingham, linux-kernel, Peng Liu
ping
On 2022/8/4 16:49, Peng Liu wrote:
> ping
>
> On 2022/7/20 20:27, pngliu@hotmail.com wrote:
>> From: Peng Liu <liupeng17@lenovo.com>
>>
>> commit 511885d7061e ("lib/timerqueue: Rely on rbtree semantics for next
>> timer") changed struct timerqueue_head, and so print_active_timers()
>> should be changed accordingly with its way to interpret the structure.
>>
>> Signed-off-by: Peng Liu <liupeng17@lenovo.com>
>> ---
>> scripts/gdb/linux/timerlist.py | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/scripts/gdb/linux/timerlist.py
>> b/scripts/gdb/linux/timerlist.py
>> index 071d0dd5a634..44e39dc3eb64 100644
>> --- a/scripts/gdb/linux/timerlist.py
>> +++ b/scripts/gdb/linux/timerlist.py
>> @@ -43,8 +43,7 @@ def print_timer(rb_node, idx):
>> def print_active_timers(base):
>> - curr = base['active']['next']['node']
>> - curr = curr.address.cast(rbtree.rb_node_type.get_type().pointer())
>> + curr = base['active']['rb_root']['rb_leftmost']
>> idx = 0
>> while curr:
>> yield print_timer(curr, idx)
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 1/3] scripts/gdb: fix lx-timerlist for struct timequeue_head change
2022-08-22 9:29 ` Peng Liu
@ 2022-08-31 2:01 ` Peng Liu
0 siblings, 0 replies; 6+ messages in thread
From: Peng Liu @ 2022-08-31 2:01 UTC (permalink / raw)
To: kbingham; +Cc: jan.kiszka, linux-kernel, Peng Liu
ping
On 2022/8/22 17:29, Peng Liu wrote:
> ping
>
> On 2022/8/4 16:49, Peng Liu wrote:
>> ping
>>
>> On 2022/7/20 20:27, pngliu@hotmail.com wrote:
>>> From: Peng Liu <liupeng17@lenovo.com>
>>>
>>> commit 511885d7061e ("lib/timerqueue: Rely on rbtree semantics for next
>>> timer") changed struct timerqueue_head, and so print_active_timers()
>>> should be changed accordingly with its way to interpret the structure.
>>>
>>> Signed-off-by: Peng Liu <liupeng17@lenovo.com>
>>> ---
>>> scripts/gdb/linux/timerlist.py | 3 +--
>>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>>
>>> diff --git a/scripts/gdb/linux/timerlist.py
>>> b/scripts/gdb/linux/timerlist.py
>>> index 071d0dd5a634..44e39dc3eb64 100644
>>> --- a/scripts/gdb/linux/timerlist.py
>>> +++ b/scripts/gdb/linux/timerlist.py
>>> @@ -43,8 +43,7 @@ def print_timer(rb_node, idx):
>>> def print_active_timers(base):
>>> - curr = base['active']['next']['node']
>>> - curr = curr.address.cast(rbtree.rb_node_type.get_type().pointer())
>>> + curr = base['active']['rb_root']['rb_leftmost']
>>> idx = 0
>>> while curr:
>>> yield print_timer(curr, idx)
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/3] scripts/gdb: fix lx-timerlist for struct timequeue_head change
2022-07-20 12:27 pngliu
2022-08-04 8:49 ` Peng Liu
@ 2022-08-31 15:00 ` Jan Kiszka
1 sibling, 0 replies; 6+ messages in thread
From: Jan Kiszka @ 2022-08-31 15:00 UTC (permalink / raw)
To: pngliu, kbingham, Andrew Morton; +Cc: linux-kernel, Peng Liu, Stephen Boyd
On 20.07.22 14:27, pngliu@hotmail.com wrote:
> From: Peng Liu <liupeng17@lenovo.com>
>
> commit 511885d7061e ("lib/timerqueue: Rely on rbtree semantics for next
> timer") changed struct timerqueue_head, and so print_active_timers()
> should be changed accordingly with its way to interpret the structure.
>
> Signed-off-by: Peng Liu <liupeng17@lenovo.com>
> ---
> scripts/gdb/linux/timerlist.py | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/scripts/gdb/linux/timerlist.py b/scripts/gdb/linux/timerlist.py
> index 071d0dd5a634..44e39dc3eb64 100644
> --- a/scripts/gdb/linux/timerlist.py
> +++ b/scripts/gdb/linux/timerlist.py
> @@ -43,8 +43,7 @@ def print_timer(rb_node, idx):
>
>
> def print_active_timers(base):
> - curr = base['active']['next']['node']
> - curr = curr.address.cast(rbtree.rb_node_type.get_type().pointer())
> + curr = base['active']['rb_root']['rb_leftmost']
> idx = 0
> while curr:
> yield print_timer(curr, idx)
Looks good to me.
Reviewed-by: Jan Kiszka <jan.kiszka@siemens.com>
Jan
--
Siemens AG, Technology
Competence Center Embedded Linux
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-03-21 6:19 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-21 6:18 [PATCH 1/3] scripts/gdb: fix lx-timerlist for struct timequeue_head change Peng Liu
-- strict thread matches above, loose matches on Subject: below --
2022-07-20 12:27 pngliu
2022-08-04 8:49 ` Peng Liu
2022-08-22 9:29 ` Peng Liu
2022-08-31 2:01 ` Peng Liu
2022-08-31 15:00 ` Jan Kiszka
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).