From: Peng Liu <pngliu@hotmail.com>
To: jan.kiszka@siemens.com
Cc: kbingham@kernel.org, linux-kernel@vger.kernel.org,
Peng Liu <liupeng17@lenovo.com>
Subject: Re: [PATCH 2/3] scripts/gdb: fix lx-timerlist for Python3
Date: Mon, 22 Aug 2022 17:30:05 +0800 [thread overview]
Message-ID: <TYYP286MB17633C3B6BFAFD8951BD06F0C6719@TYYP286MB1763.JPNP286.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <TYYP286MB17633E7DDA7739F53B1C4CF2C69F9@TYYP286MB1763.JPNP286.PROD.OUTLOOK.COM>
ping
On 2022/8/4 16:50, Peng Liu wrote:
> ping
>
> On 2022/7/20 20:27, pngliu@hotmail.com wrote:
>> From: Peng Liu <liupeng17@lenovo.com>
>>
>> Below incompatibilities between Python2 and Python3 made lx-timerlist
>> fail to run under Python3.
>>
>> o xrange() is replaced by range() in Python3
>> o bytes and str are different types in Python3
>> o the return value of Inferior.read_memory() is memoryview object in
>> Python3
>>
>> Signed-off-by: Peng Liu <liupeng17@lenovo.com>
>> ---
>> scripts/gdb/linux/timerlist.py | 4 +++-
>> scripts/gdb/linux/utils.py | 5 ++++-
>> 2 files changed, 7 insertions(+), 2 deletions(-)
>>
>> diff --git a/scripts/gdb/linux/timerlist.py
>> b/scripts/gdb/linux/timerlist.py
>> index 44e39dc3eb64..8281da068c5b 100644
>> --- a/scripts/gdb/linux/timerlist.py
>> +++ b/scripts/gdb/linux/timerlist.py
>> @@ -72,7 +72,7 @@ def print_cpu(hrtimer_bases, cpu, max_clock_bases):
>> ts = cpus.per_cpu(tick_sched_ptr, cpu)
>> text = "cpu: {}\n".format(cpu)
>> - for i in xrange(max_clock_bases):
>> + for i in range(max_clock_bases):
>> text += " clock {}:\n".format(i)
>> text += print_base(cpu_base['clock_base'][i])
>> @@ -157,6 +157,8 @@ def pr_cpumask(mask):
>> num_bytes = (nr_cpu_ids + 7) / 8
>> buf = utils.read_memoryview(inf, bits, num_bytes).tobytes()
>> buf = binascii.b2a_hex(buf)
>> + if type(buf) is not str:
>> + buf=buf.decode()
>> chunks = []
>> i = num_bytes
>> diff --git a/scripts/gdb/linux/utils.py b/scripts/gdb/linux/utils.py
>> index ff7c1799d588..db59f986c7fd 100644
>> --- a/scripts/gdb/linux/utils.py
>> +++ b/scripts/gdb/linux/utils.py
>> @@ -89,7 +89,10 @@ def get_target_endianness():
>> def read_memoryview(inf, start, length):
>> - return memoryview(inf.read_memory(start, length))
>> + m = inf.read_memory(start, length)
>> + if type(m) is memoryview:
>> + return m
>> + return memoryview(m)
>> def read_u16(buffer, offset):
next prev parent reply other threads:[~2022-08-22 9:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220720122711.6174-1-pngliu@hotmail.com>
2022-07-20 12:27 ` [PATCH 2/3] scripts/gdb: fix lx-timerlist for Python3 pngliu
2022-08-04 8:50 ` Peng Liu
2022-08-22 9:30 ` Peng Liu [this message]
2022-08-31 2:02 ` Peng Liu
2022-08-31 15:01 ` Jan Kiszka
2022-09-01 2:29 ` Peng Liu
2022-07-20 12:27 ` [PATCH 3/3] scripts/gdb: fix lx-timerlist for HRTIMER_MAX_CLOCK_BASES printing pngliu
2022-08-04 8:50 ` Peng Liu
2022-08-22 9:30 ` Peng Liu
2022-08-31 2:02 ` Peng Liu
2022-08-31 15:03 ` Jan Kiszka
2023-03-21 6:19 [PATCH 2/3] scripts/gdb: fix lx-timerlist for Python3 Peng Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=TYYP286MB17633C3B6BFAFD8951BD06F0C6719@TYYP286MB1763.JPNP286.PROD.OUTLOOK.COM \
--to=pngliu@hotmail.com \
--cc=jan.kiszka@siemens.com \
--cc=kbingham@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liupeng17@lenovo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).