From: Min Li <min.li.xe@renesas.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: "sameo@linux.intel.com" <sameo@linux.intel.com>,
"grant.likely@linaro.org" <grant.likely@linaro.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: RE: [PATCH mfd v2] mfd: Add Renesas Synchronization Management Unit (SMU) support
Date: Wed, 16 Jun 2021 15:07:17 +0000 [thread overview]
Message-ID: <TYYPR01MB6603D0473CF72D7EFB599D2CBA0F9@TYYPR01MB6603.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <YMoP7fdkyyYUrDf2@dell>
> >
> > Hi Lee
> >
> > The PHC driver already existed in the current tree as
> > drivers/ptp/ptp_clockmatrix.c and ptp_idt82p33.c
> >
> > Right now, they act as i2c driver. I plan to change them as a normal
> > platform device driver after this MFD change kicked in
> >
> > That is why I would prefer the name "phc" instead of "clock" since the
> > driver is not a normal clk driver under drivers/clk but a ptp clock
> > driver. And down the road, we will have our real clock driver and I wanna
> reserve the name "clock" for the real clock driver.
>
> I see. To be honest, I wasn't aware of the PTP subsystem.
>
> In which case, the name needs to match the one in the driver:
>
> static struct i2c_driver idtcm_driver = {
> .driver = {
> .of_match_table = of_match_ptr(idtcm_dt_id),
> .name = "idtcm",
> },
> .probe = idtcm_probe,
> .remove = idtcm_remove,
> .id_table = idtcm_i2c_id,
> };
>
> So, "idtcm" in this case.
>
> How else will it match?
>
Hi Lee
I actually like to comply with the mfd sub device naming convention by naming it 8a3400x-phc
About the names in ptp clock driver, I will have to change them anyways down the road to
make them work with the mfd driver
Another match doesn't exist in the current tree yet. It would be a normal platform device driver that I
will submit to drivers/misc a little later after this mfd change is merged.
Thanks
Min
next prev parent reply other threads:[~2021-06-16 15:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-02 16:43 [PATCH mfd v2] mfd: Add Renesas Synchronization Management Unit (SMU) support min.li.xe
2021-06-14 20:31 ` Min Li
2021-06-14 21:40 ` Lee Jones
2021-06-15 13:50 ` Lee Jones
2021-06-15 16:38 ` Min Li
2021-06-16 7:57 ` Lee Jones
2021-06-16 14:32 ` Min Li
2021-06-16 14:51 ` Lee Jones
2021-06-16 15:07 ` Min Li [this message]
2021-06-16 15:28 ` Lee Jones
2021-06-16 16:24 ` Min Li
2021-06-16 16:35 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=TYYPR01MB6603D0473CF72D7EFB599D2CBA0F9@TYYPR01MB6603.jpnprd01.prod.outlook.com \
--to=min.li.xe@renesas.com \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).