From: Lee Jones <lee.jones@linaro.org>
To: Min Li <min.li.xe@renesas.com>
Cc: "sameo@linux.intel.com" <sameo@linux.intel.com>,
"grant.likely@linaro.org" <grant.likely@linaro.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH mfd v2] mfd: Add Renesas Synchronization Management Unit (SMU) support
Date: Wed, 16 Jun 2021 15:51:25 +0100 [thread overview]
Message-ID: <YMoP7fdkyyYUrDf2@dell> (raw)
In-Reply-To: <TYYPR01MB6603047A864DB37F111BDAD9BA0F9@TYYPR01MB6603.jpnprd01.prod.outlook.com>
On Wed, 16 Jun 2021, Min Li wrote:
> >
> > > >
> > > > > +static struct mfd_cell rsmu_cm_devs[] = {
> > > > > + [RSMU_PHC] = {
> > > > > + .name = "idtcm-phc",
> > > >
> > > > Can't you have a nicer name?
> > > >
> > > Hi Lee
> > >
> > > I wonder which part of the name that you don't like? PHC stands from PTP
> > Hardware Clock.
> > > I was following the name convention like tps65912-regulator.
> > > Do you accept "8a3400-phc"?
> >
> > I think you're trying to put too much information into the device name.
> >
> > Currently it's:
> >
> > idt <company name> cm <platform> - phc <exact device type>
> >
> > Where usually we have, taking your example:
> >
> > tps65912 <chip> - regulator <subsystem>
> >
> > So assuming the PTP HW Clock is just a clock it should be:
> >
> > 8a3400 <chip> - clock <subsystem>
> >
> > It's difficult to say without seeing the associated child device(s).
> > When do you propose to upstream those? Maybe they should be part of
> > this initial set. I think that would help a lot.
> >
>
> Hi Lee
>
> The PHC driver already existed in the current tree as drivers/ptp/ptp_clockmatrix.c and
> ptp_idt82p33.c
>
> Right now, they act as i2c driver. I plan to change them as a normal platform device driver
> after this MFD change kicked in
>
> That is why I would prefer the name "phc" instead of "clock" since the driver is not a normal clk driver
> under drivers/clk but a ptp clock driver. And down the road, we will have our real clock driver and I wanna
> reserve the name "clock" for the real clock driver.
I see. To be honest, I wasn't aware of the PTP subsystem.
In which case, the name needs to match the one in the driver:
static struct i2c_driver idtcm_driver = {
.driver = {
.of_match_table = of_match_ptr(idtcm_dt_id),
.name = "idtcm",
},
.probe = idtcm_probe,
.remove = idtcm_remove,
.id_table = idtcm_i2c_id,
};
So, "idtcm" in this case.
How else will it match?
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2021-06-16 14:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-02 16:43 [PATCH mfd v2] mfd: Add Renesas Synchronization Management Unit (SMU) support min.li.xe
2021-06-14 20:31 ` Min Li
2021-06-14 21:40 ` Lee Jones
2021-06-15 13:50 ` Lee Jones
2021-06-15 16:38 ` Min Li
2021-06-16 7:57 ` Lee Jones
2021-06-16 14:32 ` Min Li
2021-06-16 14:51 ` Lee Jones [this message]
2021-06-16 15:07 ` Min Li
2021-06-16 15:28 ` Lee Jones
2021-06-16 16:24 ` Min Li
2021-06-16 16:35 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YMoP7fdkyyYUrDf2@dell \
--to=lee.jones@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=min.li.xe@renesas.com \
--cc=robh+dt@kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).