* [patch] Re: 2.4.19-pre2: ufs problems
@ 2002-03-04 0:35 Andries.Brouwer
2002-03-05 18:09 ` Marcelo Tosatti
0 siblings, 1 reply; 2+ messages in thread
From: Andries.Brouwer @ 2002-03-04 0:35 UTC (permalink / raw)
To: jurgen, linux-kernel; +Cc: kraxel, marcelo
Both Gerd Knorr and Jurgen Philippaerts complain about
problems mounting an ufs filesystem, one for BSD, the
other for Solaris.
The reason is the patch fragment in patch-2.4.19-pre2:
--- linux.orig/fs/ufs/super.c Thu Feb 28 18:24:57 2002
+++ linux/fs/ufs/super.c Wed Feb 27 20:34:30 2002
@@ -597,7 +597,11 @@
}
again:
- set_blocksize (sb->s_dev, block_size);
+ if (!set_blocksize (sb->s_dev, block_size)) {
+ printk(KERN_ERR "UFS: failed to set blocksize\n");
+ goto failed;
+ }
+
sb->s_blocksize = block_size;
/*
Indeed, set_blocksize returns 0 when all is well.
Thus, this change will always cause a failure.
Andries
[so, this patch fragment must be reverted, or the '!'
must be removed]
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [patch] Re: 2.4.19-pre2: ufs problems
2002-03-04 0:35 [patch] Re: 2.4.19-pre2: ufs problems Andries.Brouwer
@ 2002-03-05 18:09 ` Marcelo Tosatti
0 siblings, 0 replies; 2+ messages in thread
From: Marcelo Tosatti @ 2002-03-05 18:09 UTC (permalink / raw)
To: Andries.Brouwer; +Cc: jurgen, linux-kernel, kraxel
On Mon, 4 Mar 2002 Andries.Brouwer@cwi.nl wrote:
> Both Gerd Knorr and Jurgen Philippaerts complain about
> problems mounting an ufs filesystem, one for BSD, the
> other for Solaris.
> The reason is the patch fragment in patch-2.4.19-pre2:
>
> --- linux.orig/fs/ufs/super.c Thu Feb 28 18:24:57 2002
> +++ linux/fs/ufs/super.c Wed Feb 27 20:34:30 2002
> @@ -597,7 +597,11 @@
> }
>
> again:
> - set_blocksize (sb->s_dev, block_size);
> + if (!set_blocksize (sb->s_dev, block_size)) {
> + printk(KERN_ERR "UFS: failed to set blocksize\n");
> + goto failed;
> + }
> +
> sb->s_blocksize = block_size;
>
> /*
>
> Indeed, set_blocksize returns 0 when all is well.
> Thus, this change will always cause a failure.
Fixed in my tree.
Thanks
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2002-03-05 19:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2002-03-04 0:35 [patch] Re: 2.4.19-pre2: ufs problems Andries.Brouwer
2002-03-05 18:09 ` Marcelo Tosatti
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).