* Re: [PATCH] 2.5.13 IDE PIO mode Fix
@ 2002-05-04 10:15 Andries.Brouwer
2002-05-05 0:10 ` Martin Dalecki
0 siblings, 1 reply; 4+ messages in thread
From: Andries.Brouwer @ 2002-05-04 10:15 UTC (permalink / raw)
To: dalecki, linux-kernel, tomita; +Cc: torvalds
I found this bug in 2.5.10 first. And caused ext2 FS corruption.
We are porting Linux to PC-9801 architecture (made by NEC Japan).
It has PIO ONLY IDE I/F. So please check PIO mode too.
# Our porting status - 2.2.x/2.4.x done and updating. 2.5.x partial.
diff -urN linux-2.5.10/drivers/ide/ide-taskfile.c linux/drivers/ide/ide-taskfile.c
--- linux-2.5.10/drivers/ide/ide-taskfile.c Wed Apr 24 16:15:19 2002
+++ linux/drivers/ide/ide-taskfile.c Fri Apr 26 15:44:42 2002
@@ -202,7 +202,7 @@
ata_write_slow(drive, buffer, wcount);
else
#endif
- ata_write_16(drive, buffer, wcount<<1);
+ ata_write_16(drive, buffer, wcount);
}
}
Excellent!
It was introduced in 2.5.9 and still exists in 2.5.13,
and caused superblock corruption for me. This fixes it.
Andries
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] 2.5.13 IDE PIO mode Fix
2002-05-04 10:15 [PATCH] 2.5.13 IDE PIO mode Fix Andries.Brouwer
@ 2002-05-05 0:10 ` Martin Dalecki
0 siblings, 0 replies; 4+ messages in thread
From: Martin Dalecki @ 2002-05-05 0:10 UTC (permalink / raw)
To: Andries.Brouwer; +Cc: linux-kernel, tomita, torvalds
Użytkownik Andries.Brouwer@cwi.nl napisał:
> I found this bug in 2.5.10 first. And caused ext2 FS corruption.
> We are porting Linux to PC-9801 architecture (made by NEC Japan).
> It has PIO ONLY IDE I/F. So please check PIO mode too.
> # Our porting status - 2.2.x/2.4.x done and updating. 2.5.x partial.
>
> diff -urN linux-2.5.10/drivers/ide/ide-taskfile.c linux/drivers/ide/ide-taskfile.c
> --- linux-2.5.10/drivers/ide/ide-taskfile.c Wed Apr 24 16:15:19 2002
> +++ linux/drivers/ide/ide-taskfile.c Fri Apr 26 15:44:42 2002
> @@ -202,7 +202,7 @@
> ata_write_slow(drive, buffer, wcount);
> else
> #endif
> - ata_write_16(drive, buffer, wcount<<1);
> + ata_write_16(drive, buffer, wcount);
> }
> }
>
> Excellent!
Thank you for confirmations. This even streamlines the code to what
it was intendid to be.
BTW.> The next thing I plan to break is host chips initialization,
since Jens introduced several additional ide_dma_action_t fields
for no good reaons... I decided to remove them all as next... :-).
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] 2.5.13 IDE PIO mode Fix
2002-05-03 23:08 Osamu Tomita
@ 2002-05-05 0:06 ` Martin Dalecki
0 siblings, 0 replies; 4+ messages in thread
From: Martin Dalecki @ 2002-05-05 0:06 UTC (permalink / raw)
To: Osamu Tomita; +Cc: linux-kernel
Uz.ytkownik Osamu Tomita napisa?:
> I found this bug in 2.5.10 first. And caused ext2 FS corruption.
> We are porting Linux to PC-9801 architecture (made by NEC Japan).
> It has PIO ONLY IDE I/F. So please check PIO mode too.
Hey I can't do everything. And I know that people like you will
check it anyway :-)... But seriously - Thank you very much for
the plague and indeed 16 bit transfers are something I see makes sense for
embedded platforms.
> # Our porting status - 2.2.x/2.4.x done and updating. 2.5.x partial.
>
> diff -urN linux-2.5.10/drivers/ide/ide-taskfile.c linux/drivers/ide/ide-taskfile.c
> --- linux-2.5.10/drivers/ide/ide-taskfile.c Wed Apr 24 16:15:19 2002
> +++ linux/drivers/ide/ide-taskfile.c Fri Apr 26 15:44:42 2002
> @@ -202,7 +202,7 @@
> ata_write_slow(drive, buffer, wcount);
> else
> #endif
> - ata_write_16(drive, buffer, wcount<<1);
> + ata_write_16(drive, buffer, wcount);
> }
> }
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] 2.5.13 IDE PIO mode Fix
@ 2002-05-03 23:08 Osamu Tomita
2002-05-05 0:06 ` Martin Dalecki
0 siblings, 1 reply; 4+ messages in thread
From: Osamu Tomita @ 2002-05-03 23:08 UTC (permalink / raw)
To: linux-kernel
I found this bug in 2.5.10 first. And caused ext2 FS corruption.
We are porting Linux to PC-9801 architecture (made by NEC Japan).
It has PIO ONLY IDE I/F. So please check PIO mode too.
# Our porting status - 2.2.x/2.4.x done and updating. 2.5.x partial.
diff -urN linux-2.5.10/drivers/ide/ide-taskfile.c linux/drivers/ide/ide-taskfile.c
--- linux-2.5.10/drivers/ide/ide-taskfile.c Wed Apr 24 16:15:19 2002
+++ linux/drivers/ide/ide-taskfile.c Fri Apr 26 15:44:42 2002
@@ -202,7 +202,7 @@
ata_write_slow(drive, buffer, wcount);
else
#endif
- ata_write_16(drive, buffer, wcount<<1);
+ ata_write_16(drive, buffer, wcount);
}
}
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2002-05-05 1:13 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2002-05-04 10:15 [PATCH] 2.5.13 IDE PIO mode Fix Andries.Brouwer
2002-05-05 0:10 ` Martin Dalecki
-- strict thread matches above, loose matches on Subject: below --
2002-05-03 23:08 Osamu Tomita
2002-05-05 0:06 ` Martin Dalecki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).