From: Andries.Brouwer@cwi.nl
To: Andries.Brouwer@cwi.nl, jgarzik@pobox.com
Cc: B.Zolnierkiewicz@elka.pw.edu.pl, linux-kernel@vger.kernel.org,
torvalds@osdl.org
Subject: Re: Add identify decoding 4/4
Date: Wed, 6 Aug 2003 15:51:06 +0200 (MEST) [thread overview]
Message-ID: <UTC200308061351.h76Dp6413498.aeb@smtp.cwi.nl> (raw)
Andries.Brouwer@cwi.nl wrote:
> Here a somewhat uneven commented ide_identify.h.
> This is part of a larger patch, but suffices for now.
Do you really want to stick that long function in a header?
Stick it in ide-lib.c, that's a better place for it, IMO...
No. <linux/ide-identify.h> contains a lot of 1-line static inline
functions, just readable names for current magic bit checks,
and one big function ide_dump_identify_info() that is included as
#ifdef IDE_IDENTIFY_DEBUG
static void
ide_dump_identify_info(const struct hd_driveid *id, const char *name)
{
...
}
#endif
Thus, ide-floppy.c and ide-tape.c and isd200.c can do
#if IDEFLOPPY_DEBUG_INFO
#define IDE_IDENTIFY_DEBUG
#include <linux/ide-identify.h>
#endif
and get this big function, but only when their local debugging option
is set. We would not want to see it in the binary if there were no users.
Andries
next reply other threads:[~2003-08-06 13:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-06 13:51 Andries.Brouwer [this message]
2003-08-06 21:25 ` Add identify decoding 4/4 Jeff Garzik
-- strict thread matches above, loose matches on Subject: below --
2003-08-06 21:44 Andries.Brouwer
2003-08-07 22:11 ` Horst von Brand
2003-08-06 7:23 Andries.Brouwer
2003-08-06 12:19 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=UTC200308061351.h76Dp6413498.aeb@smtp.cwi.nl \
--to=andries.brouwer@cwi.nl \
--cc=B.Zolnierkiewicz@elka.pw.edu.pl \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).