From: Andries.Brouwer@cwi.nl
To: Andries.Brouwer@cwi.nl, jgarzik@pobox.com
Cc: B.Zolnierkiewicz@elka.pw.edu.pl, linux-kernel@vger.kernel.org,
torvalds@osdl.org
Subject: Re: Add identify decoding 4/4
Date: Wed, 6 Aug 2003 23:44:21 +0200 (MEST) [thread overview]
Message-ID: <UTC200308062144.h76LiLm16781.aeb@smtp.cwi.nl> (raw)
> I know full well _why_ the big function is in the header;
> that doesn't address my point: we don't need to be putting
> big functions in header files. That's why libraries were invented
Well. I chose the most elegant solution I saw.
If you see a better solution, I would like to see it.
Note that local symbols in several files determine
whether this function should be compiled or not.
Also, consider the following.
This file *is* a library. It contains a hundred
(in the version you saw half a dozen) one-line
static inline functions. That is the real library.
It describes all identify stuff.
And there is a single large function used for debugging,
invisible unless a debugging symbol is defined.
I cannot see anything wrong with that.
You are very narrow minded if you are blinded by the
fact that the name ends in an h.
Andries
next reply other threads:[~2003-08-06 21:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-06 21:44 Andries.Brouwer [this message]
2003-08-07 22:11 ` Add identify decoding 4/4 Horst von Brand
-- strict thread matches above, loose matches on Subject: below --
2003-08-06 13:51 Andries.Brouwer
2003-08-06 21:25 ` Jeff Garzik
2003-08-06 7:23 Andries.Brouwer
2003-08-06 12:19 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=UTC200308062144.h76LiLm16781.aeb@smtp.cwi.nl \
--to=andries.brouwer@cwi.nl \
--cc=B.Zolnierkiewicz@elka.pw.edu.pl \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).