linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andries.Brouwer@cwi.nl
To: torvalds@osdl.org
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] small dev_t fix
Date: Sun, 28 Sep 2003 13:51:46 +0200 (MEST)	[thread overview]
Message-ID: <UTC200309281151.h8SBpkH15931.aeb@smtp.cwi.nl> (raw)

See that we finally got a larger dev_t. Very good!
Will check over time what form my patches got in the current tree.
The first one I checked was broken a little. Below a fix.

[ext2 used a 32-bit field for dev_t, with possibly undefined
storage following; thus, no action was required to go to
32-bit dev_t, but going to 64-bit dev_t required some subtlety:
0 was written in the first word and the 64 bits in the following two.
Al truncated my 64-bit stuff to 32 bits but did not understand why
there was this split, and wrote 0 followed by a single word.
We should at least zero the word following to have well-defined
storage later.]

Andries

This is for fs/ext2/inode.c.

--- inode.c~	Sun Sep 28 12:42:15 2003
+++ inode.c	Sun Sep 28 13:25:03 2003
@@ -1228,6 +1228,7 @@
 			raw_inode->i_block[0] = 0;
 			raw_inode->i_block[1] =
 				cpu_to_le32(new_encode_dev(inode->i_rdev));
+			raw_inode->i_block[2] = 0;
 		}
 	} else for (n = 0; n < EXT2_N_BLOCKS; n++)
 		raw_inode->i_block[n] = ei->i_data[n];

                 reply	other threads:[~2003-09-28 11:51 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=UTC200309281151.h8SBpkH15931.aeb@smtp.cwi.nl \
    --to=andries.brouwer@cwi.nl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).