* [PATCH] arm64: dts: ls1028a: Add temperature sensor node
@ 2019-05-24 1:21 Yuantian Tang
2019-05-24 22:31 ` Li Yang
0 siblings, 1 reply; 4+ messages in thread
From: Yuantian Tang @ 2019-05-24 1:21 UTC (permalink / raw)
To: shawnguo
Cc: leoyang.li, robh+dt, mark.rutland, linux-arm-kernel, devicetree,
linux-kernel, Yuantian Tang
Add nxp sa56004 chip node for temperature monitor.
Signed-off-by: Yuantian Tang <andy.tang@nxp.com>
---
arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts | 5 +++++
arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts | 5 +++++
2 files changed, 10 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
index b359068d9605..31fd626dd344 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
@@ -131,6 +131,11 @@
compatible = "atmel,24c512";
reg = <0x57>;
};
+
+ temp@4c {
+ compatible = "nxp,sa56004";
+ reg = <0x4c>;
+ };
};
i2c@5 {
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts
index f9c272fb0738..012b3f8696b7 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts
@@ -119,6 +119,11 @@
compatible = "nxp,pcf2129";
reg = <0x51>;
};
+
+ temp@4c {
+ compatible = "nxp,sa56004";
+ reg = <0x4c>;
+ };
};
};
};
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: dts: ls1028a: Add temperature sensor node
2019-05-24 1:21 [PATCH] arm64: dts: ls1028a: Add temperature sensor node Yuantian Tang
@ 2019-05-24 22:31 ` Li Yang
2019-05-27 8:27 ` [EXT] " Andy Tang
0 siblings, 1 reply; 4+ messages in thread
From: Li Yang @ 2019-05-24 22:31 UTC (permalink / raw)
To: Yuantian Tang
Cc: Shawn Guo, Rob Herring, Mark Rutland,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, lkml
On Thu, May 23, 2019 at 8:30 PM Yuantian Tang <andy.tang@nxp.com> wrote:
>
> Add nxp sa56004 chip node for temperature monitor.
>
> Signed-off-by: Yuantian Tang <andy.tang@nxp.com>
> ---
> arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts | 5 +++++
> arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts | 5 +++++
> 2 files changed, 10 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
> index b359068d9605..31fd626dd344 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
> @@ -131,6 +131,11 @@
> compatible = "atmel,24c512";
> reg = <0x57>;
> };
> +
> + temp@4c {
The recommended name for temperature senor in dts spec is temperature-sensor.
> + compatible = "nxp,sa56004";
The binding says the following property is required. If it is not the
case, probably we should update the binding.
- vcc-supply: vcc regulator for the supply voltage.
> + reg = <0x4c>;
> + };
> };
>
> i2c@5 {
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts
> index f9c272fb0738..012b3f8696b7 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts
> @@ -119,6 +119,11 @@
> compatible = "nxp,pcf2129";
> reg = <0x51>;
> };
> +
> + temp@4c {
> + compatible = "nxp,sa56004";
> + reg = <0x4c>;
> + };
> };
> };
> };
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [EXT] Re: [PATCH] arm64: dts: ls1028a: Add temperature sensor node
2019-05-24 22:31 ` Li Yang
@ 2019-05-27 8:27 ` Andy Tang
2019-05-27 19:19 ` Leo Li
0 siblings, 1 reply; 4+ messages in thread
From: Andy Tang @ 2019-05-27 8:27 UTC (permalink / raw)
To: Leo Li
Cc: Shawn Guo, Rob Herring, Mark Rutland,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, lkml
Hi Leo,
> -----Original Message-----
> From: Li Yang <leoyang.li@nxp.com>
> Sent: 2019年5月25日 6:32
> To: Andy Tang <andy.tang@nxp.com>
> Cc: Shawn Guo <shawnguo@kernel.org>; Rob Herring <robh+dt@kernel.org>;
> Mark Rutland <mark.rutland@arm.com>; moderated list:ARM/FREESCALE
> IMX / MXC ARM ARCHITECTURE <linux-arm-kernel@lists.infradead.org>;
> open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS
> <devicetree@vger.kernel.org>; lkml <linux-kernel@vger.kernel.org>
> Subject: [EXT] Re: [PATCH] arm64: dts: ls1028a: Add temperature sensor
> node
>
> Caution: EXT Email
>
> On Thu, May 23, 2019 at 8:30 PM Yuantian Tang <andy.tang@nxp.com>
> wrote:
> >
> > Add nxp sa56004 chip node for temperature monitor.
> >
> > Signed-off-by: Yuantian Tang <andy.tang@nxp.com>
> > ---
> > arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts | 5 +++++
> > arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts | 5 +++++
> > 2 files changed, 10 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
> > b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
> > index b359068d9605..31fd626dd344 100644
> > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
> > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
> > @@ -131,6 +131,11 @@
> > compatible = "atmel,24c512";
> > reg = <0x57>;
> > };
> > +
> > + temp@4c {
>
> The recommended name for temperature senor in dts spec is
> temperature-sensor.
I didn't find the spec for this recommendation. Could you please provide the link?
I like to update it to temp-sensor though.
>
> > + compatible = "nxp,sa56004";
>
> The binding says the following property is required. If it is not the case,
> probably we should update the binding.
> - vcc-supply: vcc regulator for the supply voltage.
I will add the vcc-supply to comply this requirement.
Thanks,
Andy
>
> > + reg = <0x4c>;
> > + };
> > };
> >
> > i2c@5 {
> > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts
> > b/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts
> > index f9c272fb0738..012b3f8696b7 100644
> > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts
> > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts
> > @@ -119,6 +119,11 @@
> > compatible = "nxp,pcf2129";
> > reg = <0x51>;
> > };
> > +
> > + temp@4c {
> > + compatible = "nxp,sa56004";
> > + reg = <0x4c>;
> > + };
> > };
> > };
> > };
> > --
> > 2.17.1
> >
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [EXT] Re: [PATCH] arm64: dts: ls1028a: Add temperature sensor node
2019-05-27 8:27 ` [EXT] " Andy Tang
@ 2019-05-27 19:19 ` Leo Li
0 siblings, 0 replies; 4+ messages in thread
From: Leo Li @ 2019-05-27 19:19 UTC (permalink / raw)
To: Andy Tang
Cc: Shawn Guo, Rob Herring, Mark Rutland,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, lkml
> -----Original Message-----
> From: Andy Tang
> Sent: Monday, May 27, 2019 3:27 AM
> To: Leo Li <leoyang.li@nxp.com>
> Cc: Shawn Guo <shawnguo@kernel.org>; Rob Herring
> <robh+dt@kernel.org>; Mark Rutland <mark.rutland@arm.com>;
> moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE <linux-arm-
> kernel@lists.infradead.org>; open list:OPEN FIRMWARE AND FLATTENED
> DEVICE TREE BINDINGS <devicetree@vger.kernel.org>; lkml <linux-
> kernel@vger.kernel.org>
> Subject: RE: [EXT] Re: [PATCH] arm64: dts: ls1028a: Add temperature sensor
> node
>
> Hi Leo,
>
> > -----Original Message-----
> > From: Li Yang <leoyang.li@nxp.com>
> > Sent: 2019年5月25日 6:32
> > To: Andy Tang <andy.tang@nxp.com>
> > Cc: Shawn Guo <shawnguo@kernel.org>; Rob Herring
> <robh+dt@kernel.org>;
> > Mark Rutland <mark.rutland@arm.com>; moderated list:ARM/FREESCALE
> IMX
> > / MXC ARM ARCHITECTURE <linux-arm-kernel@lists.infradead.org>;
> > open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS
> > <devicetree@vger.kernel.org>; lkml <linux-kernel@vger.kernel.org>
> > Subject: [EXT] Re: [PATCH] arm64: dts: ls1028a: Add temperature sensor
> > node
> >
> > Caution: EXT Email
> >
> > On Thu, May 23, 2019 at 8:30 PM Yuantian Tang <andy.tang@nxp.com>
> > wrote:
> > >
> > > Add nxp sa56004 chip node for temperature monitor.
> > >
> > > Signed-off-by: Yuantian Tang <andy.tang@nxp.com>
> > > ---
> > > arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts | 5 +++++
> > > arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts | 5 +++++
> > > 2 files changed, 10 insertions(+)
> > >
> > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
> > > b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
> > > index b359068d9605..31fd626dd344 100644
> > > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
> > > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
> > > @@ -131,6 +131,11 @@
> > > compatible = "atmel,24c512";
> > > reg = <0x57>;
> > > };
> > > +
> > > + temp@4c {
> >
> > The recommended name for temperature senor in dts spec is
> > temperature-sensor.
> I didn't find the spec for this recommendation. Could you please provide the
> link?
You can find the spec on https://www.devicetree.org/
> I like to update it to temp-sensor though.
>
> >
> > > + compatible = "nxp,sa56004";
> >
> > The binding says the following property is required. If it is not the
> > case, probably we should update the binding.
> > - vcc-supply: vcc regulator for the supply voltage.
> I will add the vcc-supply to comply this requirement.
>
> Thanks,
> Andy
> >
> > > + reg = <0x4c>;
> > > + };
> > > };
> > >
> > > i2c@5 {
> > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts
> > > b/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts
> > > index f9c272fb0738..012b3f8696b7 100644
> > > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts
> > > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts
> > > @@ -119,6 +119,11 @@
> > > compatible = "nxp,pcf2129";
> > > reg = <0x51>;
> > > };
> > > +
> > > + temp@4c {
> > > + compatible = "nxp,sa56004";
> > > + reg = <0x4c>;
> > > + };
> > > };
> > > };
> > > };
> > > --
> > > 2.17.1
> > >
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-05-27 19:20 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-24 1:21 [PATCH] arm64: dts: ls1028a: Add temperature sensor node Yuantian Tang
2019-05-24 22:31 ` Li Yang
2019-05-27 8:27 ` [EXT] " Andy Tang
2019-05-27 19:19 ` Leo Li
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).