From: Steve Twiss <stwiss.opensource@diasemi.com>
To: Axel Lin <axel.lin@ingics.com>, Mark Brown <broonie@kernel.org>
Cc: James Seong-Won Ban <James.Ban.opensource@diasemi.com>,
Support Opensource <Support.Opensource@diasemi.com>,
"patches@opensource.cirrus.com" <patches@opensource.cirrus.com>,
Ashish Jangam <ashish.jangam@kpitcummins.com>,
Paul Kocialkowski <contact@paulk.fr>, Milo Kim <milo.kim@ti.com>,
Keerthy <j-keerthy@ti.com>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Liam Girdwood <lgirdwood@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 08/11] regulator: pv88060: Convert to use regulator_set/get_current_limit_regmap
Date: Thu, 28 Feb 2019 15:26:03 +0000 [thread overview]
Message-ID: <VI1PR10MB235291A7A4492A8481213045FE750@VI1PR10MB2352.EURPRD10.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <20190228134022.32625-9-axel.lin@ingics.com>
On 28 February 2019 13:40, Axel Lin wrote:
> Subject: [PATCH 08/11] regulator: pv88060: Convert to use
> regulator_set/get_current_limit_regmap
>
> Use regulator_set/get_current_limit_regmap helpers to save some code.
[...]
Hi Axel,
Looks good to me. Thanks again.
Acked-by: Steve Twiss <stwiss.opensource@diasemi.com>
Regards,
Steve
> @@ -171,8 +133,8 @@ static const struct regulator_ops pv88060_buck_ops = {
> .set_voltage_sel = regulator_set_voltage_sel_regmap,
> .get_voltage_sel = regulator_get_voltage_sel_regmap,
> .list_voltage = regulator_list_voltage_linear,
> - .set_current_limit = pv88060_set_current_limit,
> - .get_current_limit = pv88060_get_current_limit,
> + .set_current_limit = regulator_set_current_limit_regmap,
> + .get_current_limit = regulator_get_current_limit_regmap,
> };
>
> static const struct regulator_ops pv88060_ldo_ops = {
> @@ -207,10 +169,11 @@ static const struct regulator_ops pv88060_sw_ops = {
> .enable_mask = PV88060_BUCK_EN, \
> .vsel_reg = PV88060_REG_##regl_name##_CONF0,\
> .vsel_mask = PV88060_VBUCK_MASK,\
> + .curr_table = limits_array,\
> + .n_current_limits = ARRAY_SIZE(limits_array),\
> + .csel_reg = PV88060_REG_##regl_name##_CONF1,\
> + .csel_mask = PV88060_BUCK_ILIM_MASK,\
> },\
> - .current_limits = limits_array,\
> - .n_current_limits = ARRAY_SIZE(limits_array),\
> - .limit_mask = PV88060_BUCK_ILIM_MASK, \
> .conf = PV88060_REG_##regl_name##_CONF1,\
> }
>
> --
> 2.17.1
next prev parent reply other threads:[~2019-02-28 15:26 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-28 13:40 [PATCH 00/11] regulator: Add set/get_current_limit helpers and use it Axel Lin
2019-02-28 13:40 ` [PATCH 01/11] regulator: Fix comment for csel_reg and csel_mask Axel Lin
2019-02-28 13:40 ` [PATCH 02/11] regulator: core: Add set/get_current_limit helpers for regmap users Axel Lin
2019-02-28 13:40 ` [PATCH 03/11] regulator: da9055: Convert to use regulator_set/get_current_limit_regmap Axel Lin
2019-02-28 15:18 ` Steve Twiss
2019-02-28 13:40 ` [PATCH 04/11] regulator: da9210: " Axel Lin
2019-02-28 14:01 ` Steve Twiss
2019-02-28 13:40 ` [PATCH 05/11] regulator: lp872x: " Axel Lin
2019-02-28 13:40 ` [PATCH 06/11] regulator: lp873x: " Axel Lin
2019-02-28 13:40 ` [PATCH 07/11] regulator: max77650: " Axel Lin
2019-02-28 14:11 ` Bartosz Golaszewski
2019-02-28 13:40 ` [PATCH 08/11] regulator: pv88060: " Axel Lin
2019-02-28 15:26 ` Steve Twiss [this message]
2019-02-28 13:40 ` [PATCH 09/11] regulator: pv88080: " Axel Lin
2019-02-28 15:41 ` Steve Twiss
2019-02-28 13:40 ` [PATCH 10/11] regulator: pv88090: " Axel Lin
2019-02-28 15:47 ` Steve Twiss
2019-02-28 13:40 ` [PATCH 11/11] regulator: wm831x-dcdc: " Axel Lin
2019-03-01 8:33 ` Charles Keepax
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VI1PR10MB235291A7A4492A8481213045FE750@VI1PR10MB2352.EURPRD10.PROD.OUTLOOK.COM \
--to=stwiss.opensource@diasemi.com \
--cc=James.Ban.opensource@diasemi.com \
--cc=Support.Opensource@diasemi.com \
--cc=ashish.jangam@kpitcummins.com \
--cc=axel.lin@ingics.com \
--cc=bgolaszewski@baylibre.com \
--cc=broonie@kernel.org \
--cc=contact@paulk.fr \
--cc=j-keerthy@ti.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=milo.kim@ti.com \
--cc=patches@opensource.cirrus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).