* [PATCH 1/2] regulator: da9062: Select maximum current in specific range for set_current_limit
@ 2019-02-19 13:31 Axel Lin
2019-02-19 13:31 ` [PATCH 2/2] regulator: da9063: " Axel Lin
2019-02-19 14:05 ` [PATCH 1/2] regulator: da9062: " Steve Twiss
0 siblings, 2 replies; 4+ messages in thread
From: Axel Lin @ 2019-02-19 13:31 UTC (permalink / raw)
To: Mark Brown
Cc: Steve Twiss, Krystian Garbaciak, Support Opensource,
Liam Girdwood, linux-kernel, Axel Lin
Selecting the minimal value is only true for voltage regulators.
For current regulators the maximum in the given range should be
selected instead.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/regulator/da9062-regulator.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/regulator/da9062-regulator.c b/drivers/regulator/da9062-regulator.c
index d06e9600fa18..4c5d6ad853f8 100644
--- a/drivers/regulator/da9062-regulator.c
+++ b/drivers/regulator/da9062-regulator.c
@@ -126,7 +126,7 @@ static int da9062_set_current_limit(struct regulator_dev *rdev,
const struct da9062_regulator_info *rinfo = regl->info;
int n, tval;
- for (n = 0; n < rinfo->n_current_limits; n++) {
+ for (n = rinfo->n_current_limits - 1; n >= 0; n--) {
tval = rinfo->current_limits[n];
if (tval >= min_ua && tval <= max_ua)
return regmap_field_write(regl->ilimit, n);
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/2] regulator: da9063: Select maximum current in specific range for set_current_limit
2019-02-19 13:31 [PATCH 1/2] regulator: da9062: Select maximum current in specific range for set_current_limit Axel Lin
@ 2019-02-19 13:31 ` Axel Lin
2019-02-19 13:57 ` Steve Twiss
2019-02-19 14:05 ` [PATCH 1/2] regulator: da9062: " Steve Twiss
1 sibling, 1 reply; 4+ messages in thread
From: Axel Lin @ 2019-02-19 13:31 UTC (permalink / raw)
To: Mark Brown
Cc: Steve Twiss, Krystian Garbaciak, Support Opensource,
Liam Girdwood, linux-kernel, Axel Lin
Selecting the minimal value is only true for voltage regulators.
For current regulators the maximum in the given range should be
selected instead.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/regulator/da9063-regulator.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/regulator/da9063-regulator.c b/drivers/regulator/da9063-regulator.c
index 85c45577bad1..a83bbd3dbc37 100644
--- a/drivers/regulator/da9063-regulator.c
+++ b/drivers/regulator/da9063-regulator.c
@@ -167,7 +167,7 @@ static int da9063_set_current_limit(struct regulator_dev *rdev,
const struct da9063_regulator_info *rinfo = regl->info;
int n, tval;
- for (n = 0; n < rinfo->n_current_limits; n++) {
+ for (n = rinfo->n_current_limits - 1; n >= 0; n--) {
tval = rinfo->current_limits[n];
if (tval >= min_uA && tval <= max_uA)
return regmap_field_write(regl->ilimit, n);
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* RE: [PATCH 2/2] regulator: da9063: Select maximum current in specific range for set_current_limit
2019-02-19 13:31 ` [PATCH 2/2] regulator: da9063: " Axel Lin
@ 2019-02-19 13:57 ` Steve Twiss
0 siblings, 0 replies; 4+ messages in thread
From: Steve Twiss @ 2019-02-19 13:57 UTC (permalink / raw)
To: Axel Lin, Mark Brown
Cc: Steve Twiss, Krystian Garbaciak, Support Opensource,
Liam Girdwood, linux-kernel
On 19 February 2019 13:31, Axel Lin wrote:
> To: Mark Brown <broonie@kernel.org>
> Subject: [PATCH 2/2] regulator: da9063: Select maximum current in specific range for set_current_limit
>
> Selecting the minimal value is only true for voltage regulators.
> For current regulators the maximum in the given range should be
> selected instead.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> drivers/regulator/da9063-regulator.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/regulator/da9063-regulator.c b/drivers/regulator/da9063-
> regulator.c
> index 85c45577bad1..a83bbd3dbc37 100644
> --- a/drivers/regulator/da9063-regulator.c
> +++ b/drivers/regulator/da9063-regulator.c
> @@ -167,7 +167,7 @@ static int da9063_set_current_limit(struct regulator_dev
> *rdev,
> const struct da9063_regulator_info *rinfo = regl->info;
> int n, tval;
>
> - for (n = 0; n < rinfo->n_current_limits; n++) {
> + for (n = rinfo->n_current_limits - 1; n >= 0; n--) {
> tval = rinfo->current_limits[n];
> if (tval >= min_uA && tval <= max_uA)
> return regmap_field_write(regl->ilimit, n);
Acked-by: Steve Twiss <stwiss.opensource@diasemi.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH 1/2] regulator: da9062: Select maximum current in specific range for set_current_limit
2019-02-19 13:31 [PATCH 1/2] regulator: da9062: Select maximum current in specific range for set_current_limit Axel Lin
2019-02-19 13:31 ` [PATCH 2/2] regulator: da9063: " Axel Lin
@ 2019-02-19 14:05 ` Steve Twiss
1 sibling, 0 replies; 4+ messages in thread
From: Steve Twiss @ 2019-02-19 14:05 UTC (permalink / raw)
To: Axel Lin, Mark Brown
Cc: Steve Twiss, Support Opensource, Liam Girdwood, linux-kernel
Hi Axel,
On 19 February 2019 13:31, Axel Lin wrote:
> To: Mark Brown <broonie@kernel.org>
> Subject: [PATCH 1/2] regulator: da9062: Select maximum current in specific range for set_current_limit
>
> Selecting the minimal value is only true for voltage regulators.
> For current regulators the maximum in the given range should be
> selected instead.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> drivers/regulator/da9062-regulator.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/regulator/da9062-regulator.c b/drivers/regulator/da9062-
> regulator.c
> index d06e9600fa18..4c5d6ad853f8 100644
> --- a/drivers/regulator/da9062-regulator.c
> +++ b/drivers/regulator/da9062-regulator.c
> @@ -126,7 +126,7 @@ static int da9062_set_current_limit(struct regulator_dev
> *rdev,
> const struct da9062_regulator_info *rinfo = regl->info;
> int n, tval;
>
> - for (n = 0; n < rinfo->n_current_limits; n++) {
> + for (n = rinfo->n_current_limits - 1; n >= 0; n--) {
> tval = rinfo->current_limits[n];
> if (tval >= min_ua && tval <= max_ua)
> return regmap_field_write(regl->ilimit, n);
> --
> 2.17.1
Acked-by: Steve Twiss <stwiss.opensource@diasemi.com>
Thanks and regards,
Steve
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-02-19 14:05 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-19 13:31 [PATCH 1/2] regulator: da9062: Select maximum current in specific range for set_current_limit Axel Lin
2019-02-19 13:31 ` [PATCH 2/2] regulator: da9063: " Axel Lin
2019-02-19 13:57 ` Steve Twiss
2019-02-19 14:05 ` [PATCH 1/2] regulator: da9062: " Steve Twiss
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).