* RE: [PATCH] Staging: wlan-ng: Fix 80 character limit warnings Fixed 2 warnings identified by the checkpatch.pl tool which occured due to two lines of code going over the 80 character limit. Fixed by wrapping the lines. Signed-off-by: Jim Dog <jimdog@
@ 2010-02-23 15:37 JimDog
0 siblings, 0 replies; 4+ messages in thread
From: JimDog @ 2010-02-23 15:37 UTC (permalink / raw)
To: Richard Kennedy
Cc: Gábor Stefanik, jimdog, gregkh, jmm, mithlesh, devel, linux-kernel
No probs, i'll sort it tomorrow and resubmit it
-original message-
Subject: Re: [PATCH] Staging: wlan-ng: Fix 80 character limit warnings Fixed 2 warnings identified by the checkpatch.pl tool which occured due to two lines of code going over the 80 character limit. Fixed by wrapping the lines. Signed-off-by: Jim Dog <jimdog@
From: Richard Kennedy <richard@rsk.demon.co.uk>
Date: 23/02/2010 2:35 pm
On Sun, 2010-02-21 at 16:06 +0100, Gábor Stefanik wrote:
> > +/*
> > + {PRISM_USB_DEVICE(0x0ace, 0x1201, "ZyDAS ZD1201 Wireless USB Adapter")},
> > +*/
>
> Why is this even included? We do have support for this in zd1201, and
> I'm pretty sure wlan-ng doesn't actually handle it.
>
In that case, let's just remove it. It's only clutter and may cause
confusion.
JD do you want to update your patch to get rid of this?
regards
Richard
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Staging: wlan-ng: Fix 80 character limit warnings Fixed 2 warnings identified by the checkpatch.pl tool which occured due to two lines of code going over the 80 character limit. Fixed by wrapping the lines. Signed-off-by: Jim Dog <jimdog@
2010-02-21 15:06 Gábor Stefanik
2010-02-21 15:46 ` Jim Dog
@ 2010-02-23 14:35 ` Richard Kennedy
1 sibling, 0 replies; 4+ messages in thread
From: Richard Kennedy @ 2010-02-23 14:35 UTC (permalink / raw)
To: Gábor Stefanik, jimdog; +Cc: gregkh, jmm, mithlesh, devel, linux-kernel
On Sun, 2010-02-21 at 16:06 +0100, Gábor Stefanik wrote:
> > +/*
> > + {PRISM_USB_DEVICE(0x0ace, 0x1201, "ZyDAS ZD1201 Wireless USB Adapter")},
> > +*/
>
> Why is this even included? We do have support for this in zd1201, and
> I'm pretty sure wlan-ng doesn't actually handle it.
>
In that case, let's just remove it. It's only clutter and may cause
confusion.
JD do you want to update your patch to get rid of this?
regards
Richard
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Staging: wlan-ng: Fix 80 character limit warnings Fixed 2 warnings identified by the checkpatch.pl tool which occured due to two lines of code going over the 80 character limit. Fixed by wrapping the lines. Signed-off-by: Jim Dog <jimdog@
2010-02-21 15:06 Gábor Stefanik
@ 2010-02-21 15:46 ` Jim Dog
2010-02-23 14:35 ` Richard Kennedy
1 sibling, 0 replies; 4+ messages in thread
From: Jim Dog @ 2010-02-21 15:46 UTC (permalink / raw)
To: Gábor Stefanik
Cc: jimdog, gregkh, jmm, mithlesh, richard, devel, linux-kernel
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Not sure, guess that's why it's commented out. I just wrapped it so it
fitted in 80 chars.
JD
Gábor Stefanik wrote:
> On Sun, Feb 21, 2010 at 4:03 PM, <jimdog@northern-indymedia.org> wrote:
>> From: Jim Dog <jimdog@northern-indymedia.org>
>>
>> ---
>> drivers/staging/wlan-ng/prism2usb.c | 9 ++++++---
>> 1 files changed, 6 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/staging/wlan-ng/prism2usb.c b/drivers/staging/wlan-ng/prism2usb.c
>> index 9dde68b..b55930c 100644
>> --- a/drivers/staging/wlan-ng/prism2usb.c
>> +++ b/drivers/staging/wlan-ng/prism2usb.c
>> @@ -24,8 +24,9 @@ static struct usb_device_id usb_prism_tbl[] = {
>> (0x066b, 0x2213, "Linksys WUSB12v1.1 11Mbps WLAN USB Adapter")},
>> {PRISM_USB_DEVICE
>> (0x067c, 0x1022, "Siemens SpeedStream 1022 11Mbps WLAN USB Adapter")},
>> - {PRISM_USB_DEVICE(0x049f, 0x0033,
>> - "Compaq/Intel W100 PRO/Wireless 11Mbps multiport WLAN Adapter")},
>> + {PRISM_USB_DEVICE
>> + (0x049f, 0x0033,
>> + "Compaq/Intel W100 PRO/Wireless 11Mbps multiport WLAN Adapter")},
>> {PRISM_USB_DEVICE
>> (0x0411, 0x0016, "Melco WLI-USB-S11 11Mbps WLAN Adapter")},
>> {PRISM_USB_DEVICE
>> @@ -55,7 +56,9 @@ static struct usb_device_id usb_prism_tbl[] = {
>> (0x04f1, 0x3009, "JVC MP-XP7250 Builtin USB WLAN Adapter")},
>> {PRISM_USB_DEVICE(0x0846, 0x4110, "NetGear MA111")},
>> {PRISM_USB_DEVICE(0x03f3, 0x0020, "Adaptec AWN-8020 USB WLAN Adapter")},
>> -/* {PRISM_USB_DEVICE(0x0ace, 0x1201, "ZyDAS ZD1201 Wireless USB Adapter")}, */
>> +/*
>> + {PRISM_USB_DEVICE(0x0ace, 0x1201, "ZyDAS ZD1201 Wireless USB Adapter")},
>> +*/
>
> Why is this even included? We do have support for this in zd1201, and
> I'm pretty sure wlan-ng doesn't actually handle it.
>
>> {PRISM_USB_DEVICE(0x2821, 0x3300, "ASUS-WL140 Wireless USB Adapter")},
>> {PRISM_USB_DEVICE(0x2001, 0x3700, "DWL-122 Wireless USB Adapter")},
>> {PRISM_USB_DEVICE
>> --
>> 1.6.3.3
>>
>> _______________________________________________
>> devel mailing list
>> devel@linuxdriverproject.org
>> http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
>>
>
>
>
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iEYEARECAAYFAkuBVUAACgkQjI3ttaQQxva7ywCgtB2/cbd+Tz+4WvvlyIGKwiFq
o6kAnjIu9lCZeIEb374pfZRoEU3G9oQx
=TKK4
-----END PGP SIGNATURE-----
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Staging: wlan-ng: Fix 80 character limit warnings Fixed 2 warnings identified by the checkpatch.pl tool which occured due to two lines of code going over the 80 character limit. Fixed by wrapping the lines. Signed-off-by: Jim Dog <jimdog@
@ 2010-02-21 15:06 Gábor Stefanik
2010-02-21 15:46 ` Jim Dog
2010-02-23 14:35 ` Richard Kennedy
0 siblings, 2 replies; 4+ messages in thread
From: Gábor Stefanik @ 2010-02-21 15:06 UTC (permalink / raw)
To: jimdog; +Cc: gregkh, jmm, mithlesh, richard, devel, linux-kernel
On Sun, Feb 21, 2010 at 4:03 PM, <jimdog@northern-indymedia.org> wrote:
> From: Jim Dog <jimdog@northern-indymedia.org>
>
> ---
> drivers/staging/wlan-ng/prism2usb.c | 9 ++++++---
> 1 files changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/wlan-ng/prism2usb.c b/drivers/staging/wlan-ng/prism2usb.c
> index 9dde68b..b55930c 100644
> --- a/drivers/staging/wlan-ng/prism2usb.c
> +++ b/drivers/staging/wlan-ng/prism2usb.c
> @@ -24,8 +24,9 @@ static struct usb_device_id usb_prism_tbl[] = {
> (0x066b, 0x2213, "Linksys WUSB12v1.1 11Mbps WLAN USB Adapter")},
> {PRISM_USB_DEVICE
> (0x067c, 0x1022, "Siemens SpeedStream 1022 11Mbps WLAN USB Adapter")},
> - {PRISM_USB_DEVICE(0x049f, 0x0033,
> - "Compaq/Intel W100 PRO/Wireless 11Mbps multiport WLAN Adapter")},
> + {PRISM_USB_DEVICE
> + (0x049f, 0x0033,
> + "Compaq/Intel W100 PRO/Wireless 11Mbps multiport WLAN Adapter")},
> {PRISM_USB_DEVICE
> (0x0411, 0x0016, "Melco WLI-USB-S11 11Mbps WLAN Adapter")},
> {PRISM_USB_DEVICE
> @@ -55,7 +56,9 @@ static struct usb_device_id usb_prism_tbl[] = {
> (0x04f1, 0x3009, "JVC MP-XP7250 Builtin USB WLAN Adapter")},
> {PRISM_USB_DEVICE(0x0846, 0x4110, "NetGear MA111")},
> {PRISM_USB_DEVICE(0x03f3, 0x0020, "Adaptec AWN-8020 USB WLAN Adapter")},
> -/* {PRISM_USB_DEVICE(0x0ace, 0x1201, "ZyDAS ZD1201 Wireless USB Adapter")}, */
> +/*
> + {PRISM_USB_DEVICE(0x0ace, 0x1201, "ZyDAS ZD1201 Wireless USB Adapter")},
> +*/
Why is this even included? We do have support for this in zd1201, and
I'm pretty sure wlan-ng doesn't actually handle it.
> {PRISM_USB_DEVICE(0x2821, 0x3300, "ASUS-WL140 Wireless USB Adapter")},
> {PRISM_USB_DEVICE(0x2001, 0x3700, "DWL-122 Wireless USB Adapter")},
> {PRISM_USB_DEVICE
> --
> 1.6.3.3
>
> _______________________________________________
> devel mailing list
> devel@linuxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
>
--
Vista: [V]iruses, [I]ntruders, [S]pyware, [T]rojans and [A]dware. :-)
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-02-23 16:01 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-02-23 15:37 [PATCH] Staging: wlan-ng: Fix 80 character limit warnings Fixed 2 warnings identified by the checkpatch.pl tool which occured due to two lines of code going over the 80 character limit. Fixed by wrapping the lines. Signed-off-by: Jim Dog <jimdog@ JimDog
-- strict thread matches above, loose matches on Subject: below --
2010-02-21 15:06 Gábor Stefanik
2010-02-21 15:46 ` Jim Dog
2010-02-23 14:35 ` Richard Kennedy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).