From: Johan Hovold <johan@kernel.org>
To: Jin ChenXin <bg4akv@hotmail.com>
Cc: Johan Hovold <johan@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drivers: add new VID/PID for supporting Teraoka AD2000
Date: Wed, 13 Jan 2021 11:09:24 +0100 [thread overview]
Message-ID: <X/7G1LAzmTpfbPQF@hovoldconsulting.com> (raw)
In-Reply-To: <ME2PR01MB4483D68A6A925810E9A0B23082A90@ME2PR01MB4483.ausprd01.prod.outlook.com>
On Wed, Jan 13, 2021 at 09:03:36AM +0000, Jin ChenXin wrote:
Thanks for the patch. I've applied it now after fixing up some minor
nits (so you don't need to resend), but for next time please consider
the following comments.
> From 905036e81e0d32705379c40acddb634428aff0a6 Mon Sep 17 00:00:00 2001
Don't include this line since it prevents git-am from considering the
following lines.
It also seems hotmail base64-encoded your message, which you should try
to avoid (see Documentation/process/email-clients.rst).
> From: Chenxin Jin <bg4akv@hotmail.com>
> Date: Wed, 13 Jan 2021 16:59:05 +0800
> Subject: [PATCH] drivers: add new VID/PID for supporting Teraoka AD2000
Please use the same commit-summary prefix as other commits for the
subsystem and driver you're patching (e.g. "USB: serial: cp210x: ")
> Teraoka AD2000 uses the CP210x driver, but the chip VID/PID is
> customized with 0988/0578. We need the driver to support the new VID/PID.
>
> Signed-off-by: Chenxin Jin <bg4akv@hotmail.com>
> ---
> drivers/usb/serial/cp210x.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/serial/cp210x.c b/drivers/usb/serial/cp210x.c
> index fbb10df..c274cc3 100644
> --- a/drivers/usb/serial/cp210x.c
> +++ b/drivers/usb/serial/cp210x.c
> @@ -234,6 +234,7 @@ static int cp210x_tiocmset_port(struct usb_serial_port *port,
> { USB_DEVICE(0x3195, 0xF281) }, /* Link Instruments MSO-28 */
> { USB_DEVICE(0x3923, 0x7A0B) }, /* National Instruments USB Serial Console */
> { USB_DEVICE(0x413C, 0x9500) }, /* DW700 GPS USB interface */
> + { USB_DEVICE(0x0988, 0x0578) }, /* Teraoka AD2000 */
When possible, try to keep the entries ordered by VID and PID.
> { } /* Terminating Entry */
> };
The end-result is here:
https://git.kernel.org/pub/scm/linux/kernel/git/johan/usb-serial.git/commit/?h=usb-linus&id=43377df70480f82919032eb09832e9646a8a5efb
Johan
next parent reply other threads:[~2021-01-13 10:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <ME2PR01MB4483D68A6A925810E9A0B23082A90@ME2PR01MB4483.ausprd01.prod.outlook.com>
2021-01-13 10:09 ` Johan Hovold [this message]
2021-01-13 8:02 [PATCH] drivers: add new VID/PID for supporting Teraoka AD2000 Jin Chen Xin
2021-01-13 8:14 ` Greg Kroah-Hartman
-- strict thread matches above, loose matches on Subject: below --
2021-01-13 6:40 Jin Chen Xin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X/7G1LAzmTpfbPQF@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=bg4akv@hotmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).