Re: [PATCH] drivers: add new VID/PID for supporting Teraoka AD2000

Re: [PATCH] drivers: add new VID/PID for supporting Teraoka AD2000

[Johan Hovold]

On Wed, Jan 13, 2021 at 09:03:36AM +0000, Jin ChenXin wrote:

Thanks for the patch. I've applied it now after fixing up some minor
nits (so you don't need to resend), but for next time please consider
the following comments.

> From 905036e81e0d32705379c40acddb634428aff0a6 Mon Sep 17 00:00:00 2001

Don't include this line since it prevents git-am from considering the
following lines.

It also seems hotmail base64-encoded your message, which you should try
to avoid (see Documentation/process/email-clients.rst).

> From: Chenxin Jin <bg4akv@hotmail.com>
> Date: Wed, 13 Jan 2021 16:59:05 +0800
> Subject: [PATCH] drivers: add new VID/PID for supporting Teraoka AD2000

Please use the same commit-summary prefix as other commits for the
subsystem and driver you're patching (e.g. "USB: serial: cp210x: ")

> Teraoka AD2000 uses the CP210x driver, but the chip VID/PID is
> customized with 0988/0578. We need the driver to support the new VID/PID.
> 
> Signed-off-by: Chenxin Jin <bg4akv@hotmail.com>
> ---
>  drivers/usb/serial/cp210x.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/usb/serial/cp210x.c b/drivers/usb/serial/cp210x.c
> index fbb10df..c274cc3 100644
> --- a/drivers/usb/serial/cp210x.c
> +++ b/drivers/usb/serial/cp210x.c
> @@ -234,6 +234,7 @@ static int cp210x_tiocmset_port(struct usb_serial_port *port,
>  	{ USB_DEVICE(0x3195, 0xF281) }, /* Link Instruments MSO-28 */
>  	{ USB_DEVICE(0x3923, 0x7A0B) }, /* National Instruments USB Serial Console */
>  	{ USB_DEVICE(0x413C, 0x9500) }, /* DW700 GPS USB interface */
> +	{ USB_DEVICE(0x0988, 0x0578) }, /* Teraoka AD2000 */

When possible, try to keep the entries ordered by VID and PID.

>  	{ } /* Terminating Entry */
>  };

The end-result is here:

	https://git.kernel.org/pub/scm/linux/kernel/git/johan/usb-serial.git/commit/?h=usb-linus&id=43377df70480f82919032eb09832e9646a8a5efb

Johan

Re: [PATCH] drivers: add new VID/PID for supporting Teraoka AD2000

[Greg Kroah-Hartman]

On Wed, Jan 13, 2021 at 08:02:33AM +0000, Jin Chen Xin wrote:
> 
> From 1df119cfa105383a0e047a68602b3a9dc4f81c3c Mon Sep 17 00:00:00 2001
> From: Jin Chen-Xin <cx.jin@cn.digi-group.com>
> Date: Wed, 13 Jan 2021 14:09:07 +0800
> Subject: [PATCH] drivers: add new VID/PID for supporting Teraoka AD2000
> 
> Teraoka AD2000 uses the CP210x driver, but the chip VID/PID is
> customized with 0988/0578. We need the driver to support the new VID/PID.
> 
> Signed-off-by: Jin Chen-Xin <cx.jin@cn.digi-group.com>
> ---
>  drivers/usb/serial/cp210x.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/usb/serial/cp210x.c b/drivers/usb/serial/cp210x.c
> index fbb10df..c274cc3 100644
> --- a/drivers/usb/serial/cp210x.c
> +++ b/drivers/usb/serial/cp210x.c
> @@ -234,6 +234,7 @@ static int cp210x_tiocmset_port(struct usb_serial_port *port,
>  { USB_DEVICE(0x3195, 0xF281) }, /* Link Instruments MSO-28 */
>  { USB_DEVICE(0x3923, 0x7A0B) }, /* National Instruments USB Serial Console */
>  { USB_DEVICE(0x413C, 0x9500) }, /* DW700 GPS USB interface */
> +{ USB_DEVICE(0x0988, 0x0578) }, /* Teraoka AD2000 */
>  { } /* Terminating Entry */
>  };
> 
> --
> 1.8.3.1
> 
> 
> 
> 
> Best Regards,
> 
> Jin Chen-Xin
> Software Development Dept.
> Shanghai Teraoka Electronic Co., Ltd.
> 
> * The information contained in this message is intended for the use of the individuals to whom it is addressed and may contain information that is privileged and confidential. If you have received this email by mistake, please discard this email immediately. Do not disclose, forward or copy.
> * 信息安全声明：本邮件(包括其任何附件）的信息，仅用于邮件列出的接收者使用，并且可能包含有特许和机密的信息。如果您误收到这封电子邮件，请通知发件人，并立即删除它，请勿透露、转发或复制。

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- Your patch is malformed (tabs converted to spaces, linewrapped, etc.)
  and can not be applied.  Please read the file,
  Documentation/email-clients.txt in order to fix this.

- Your patch was attached, please place it inline so that it can be
  applied directly from the email message itself.

- This looks like a new version of a previously submitted patch, but you
  did not list below the --- line any changes from the previous version.
  Please read the section entitled "The canonical patch format" in the
  kernel file, Documentation/SubmittingPatches for what needs to be done
  here to properly describe this.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot

[PATCH] drivers: add new VID/PID for supporting Teraoka AD2000

[Jin Chen Xin]

From 1df119cfa105383a0e047a68602b3a9dc4f81c3c Mon Sep 17 00:00:00 2001
From: Jin Chen-Xin <cx.jin@cn.digi-group.com>
Date: Wed, 13 Jan 2021 14:09:07 +0800
Subject: [PATCH] drivers: add new VID/PID for supporting Teraoka AD2000

Teraoka AD2000 uses the CP210x driver, but the chip VID/PID is
customized with 0988/0578. We need the driver to support the new VID/PID.

Signed-off-by: Jin Chen-Xin <cx.jin@cn.digi-group.com>
---
 drivers/usb/serial/cp210x.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/usb/serial/cp210x.c b/drivers/usb/serial/cp210x.c
index fbb10df..c274cc3 100644
--- a/drivers/usb/serial/cp210x.c
+++ b/drivers/usb/serial/cp210x.c
@@ -234,6 +234,7 @@ static int cp210x_tiocmset_port(struct usb_serial_port *port,
 { USB_DEVICE(0x3195, 0xF281) }, /* Link Instruments MSO-28 */
 { USB_DEVICE(0x3923, 0x7A0B) }, /* National Instruments USB Serial Console */
 { USB_DEVICE(0x413C, 0x9500) }, /* DW700 GPS USB interface */
+{ USB_DEVICE(0x0988, 0x0578) }, /* Teraoka AD2000 */
 { } /* Terminating Entry */
 };

--
1.8.3.1




Best Regards,

Jin Chen-Xin
Software Development Dept.
Shanghai Teraoka Electronic Co., Ltd.

* The information contained in this message is intended for the use of the individuals to whom it is addressed and may contain information that is privileged and confidential. If you have received this email by mistake, please discard this email immediately. Do not disclose, forward or copy.
* 信息安全声明：本邮件(包括其任何附件）的信息，仅用于邮件列出的接收者使用，并且可能包含有特许和机密的信息。如果您误收到这封电子邮件，请通知发件人，并立即删除它，请勿透露、转发或复制。

[PATCH] drivers: add new VID/PID for supporting Teraoka AD2000

[Jin Chen Xin]

[-- Attachment #1: Type: text/plain, Size: 677 bytes --]





Best Regards,

Jin Chen-Xin
Software Development Dept.
Shanghai Teraoka Electronic Co., Ltd.

* The information contained in this message is intended for the use of the individuals to whom it is addressed and may contain information that is privileged and confidential. If you have received this email by mistake, please discard this email immediately. Do not disclose, forward or copy.
* 信息安全声明：本邮件(包括其任何附件）的信息，仅用于邮件列出的接收者使用，并且可能包含有特许和机密的信息。如果您误收到这封电子邮件，请通知发件人，并立即删除它，请勿透露、转发或复制。

[-- Attachment #2: 0001-drivers-add-new-VID-PID-for-supporting-Teraoka-AD200.patch --]
[-- Type: application/octet-stream, Size: 1056 bytes --]

From 1df119cfa105383a0e047a68602b3a9dc4f81c3c Mon Sep 17 00:00:00 2001
From: Jin Chen-Xin <cx.jin@cn.digi-group.com>
Date: Wed, 13 Jan 2021 14:09:07 +0800
Subject: [PATCH] drivers: add new VID/PID for supporting Teraoka AD2000

Teraoka AD2000 uses the CP210x driver, but the chip VID/PID is
customized with 0988/0578. We need the driver to support the new VID/PID.

Signed-off-by: Jin Chen-Xin <cx.jin@cn.digi-group.com>
---
 drivers/usb/serial/cp210x.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/usb/serial/cp210x.c b/drivers/usb/serial/cp210x.c
index fbb10df..c274cc3 100644
--- a/drivers/usb/serial/cp210x.c
+++ b/drivers/usb/serial/cp210x.c
@@ -234,6 +234,7 @@ static int cp210x_tiocmset_port(struct usb_serial_port *port,
 	{ USB_DEVICE(0x3195, 0xF281) }, /* Link Instruments MSO-28 */
 	{ USB_DEVICE(0x3923, 0x7A0B) }, /* National Instruments USB Serial Console */
 	{ USB_DEVICE(0x413C, 0x9500) }, /* DW700 GPS USB interface */
+	{ USB_DEVICE(0x0988, 0x0578) }, /* Teraoka AD2000 */
 	{ } /* Terminating Entry */
 };
 
-- 
1.8.3.1