* [PATCH v2 1/1] docs: submitting-patches: Emphasise the requirement to Cc: stable when using Fixes: tag
@ 2021-01-13 16:33 Lee Jones
2021-01-13 16:38 ` Greg Kroah-Hartman
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Lee Jones @ 2021-01-13 16:33 UTC (permalink / raw)
To: lee.jones; +Cc: linux-kernel, Greg Kroah-Hartman, Jonathan Corbet, linux-doc
Clear-up any confusion surrounding the Fixes: tag with regards to the
need to Cc: the stable mailing list when submitting stable patch
candidates.
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jonathan Corbet <corbet@lwn.net>
Cc: linux-doc@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
v2:
- Link to the 'stable-kernel-rules' document as per Greg's request
Documentation/process/submitting-patches.rst | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/Documentation/process/submitting-patches.rst b/Documentation/process/submitting-patches.rst
index 7c97ad580e7d0..7f48cccc75cdf 100644
--- a/Documentation/process/submitting-patches.rst
+++ b/Documentation/process/submitting-patches.rst
@@ -556,6 +556,11 @@ which stable kernel versions should receive your fix. This is the preferred
method for indicating a bug fixed by the patch. See :ref:`describe_changes`
for more details.
+Note: Attaching a Fixes: tag does not subvert the stable kernel rules
+process nor the requirement to Cc: stable@vger.kernel.org on all stable
+patch candidates. For more information, please read
+:ref:`Documentation/process/stable-kernel-rules.rst <stable_kernel_rules>`
+
.. _the_canonical_patch_format:
The canonical patch format
--
2.25.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH v2 1/1] docs: submitting-patches: Emphasise the requirement to Cc: stable when using Fixes: tag
2021-01-13 16:33 [PATCH v2 1/1] docs: submitting-patches: Emphasise the requirement to Cc: stable when using Fixes: tag Lee Jones
@ 2021-01-13 16:38 ` Greg Kroah-Hartman
2021-01-13 16:48 ` Jani Nikula
2021-01-18 20:09 ` Jonathan Corbet
2 siblings, 0 replies; 7+ messages in thread
From: Greg Kroah-Hartman @ 2021-01-13 16:38 UTC (permalink / raw)
To: Lee Jones; +Cc: linux-kernel, Jonathan Corbet, linux-doc
On Wed, Jan 13, 2021 at 04:33:15PM +0000, Lee Jones wrote:
> Clear-up any confusion surrounding the Fixes: tag with regards to the
> need to Cc: the stable mailing list when submitting stable patch
> candidates.
>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Jonathan Corbet <corbet@lwn.net>
> Cc: linux-doc@vger.kernel.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
> v2:
> - Link to the 'stable-kernel-rules' document as per Greg's request
>
> Documentation/process/submitting-patches.rst | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/process/submitting-patches.rst b/Documentation/process/submitting-patches.rst
> index 7c97ad580e7d0..7f48cccc75cdf 100644
> --- a/Documentation/process/submitting-patches.rst
> +++ b/Documentation/process/submitting-patches.rst
> @@ -556,6 +556,11 @@ which stable kernel versions should receive your fix. This is the preferred
> method for indicating a bug fixed by the patch. See :ref:`describe_changes`
> for more details.
>
> +Note: Attaching a Fixes: tag does not subvert the stable kernel rules
> +process nor the requirement to Cc: stable@vger.kernel.org on all stable
> +patch candidates. For more information, please read
> +:ref:`Documentation/process/stable-kernel-rules.rst <stable_kernel_rules>`
> +
> .. _the_canonical_patch_format:
>
> The canonical patch format
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2 1/1] docs: submitting-patches: Emphasise the requirement to Cc: stable when using Fixes: tag
2021-01-13 16:33 [PATCH v2 1/1] docs: submitting-patches: Emphasise the requirement to Cc: stable when using Fixes: tag Lee Jones
2021-01-13 16:38 ` Greg Kroah-Hartman
@ 2021-01-13 16:48 ` Jani Nikula
2021-01-13 17:12 ` Lee Jones
2021-01-18 20:09 ` Jonathan Corbet
2 siblings, 1 reply; 7+ messages in thread
From: Jani Nikula @ 2021-01-13 16:48 UTC (permalink / raw)
To: Lee Jones, lee.jones
Cc: linux-kernel, Greg Kroah-Hartman, Jonathan Corbet, linux-doc
On Wed, 13 Jan 2021, Lee Jones <lee.jones@linaro.org> wrote:
> Clear-up any confusion surrounding the Fixes: tag with regards to the
> need to Cc: the stable mailing list when submitting stable patch
> candidates.
>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Jonathan Corbet <corbet@lwn.net>
> Cc: linux-doc@vger.kernel.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
> v2:
> - Link to the 'stable-kernel-rules' document as per Greg's request
>
> Documentation/process/submitting-patches.rst | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/process/submitting-patches.rst b/Documentation/process/submitting-patches.rst
> index 7c97ad580e7d0..7f48cccc75cdf 100644
> --- a/Documentation/process/submitting-patches.rst
> +++ b/Documentation/process/submitting-patches.rst
> @@ -556,6 +556,11 @@ which stable kernel versions should receive your fix. This is the preferred
> method for indicating a bug fixed by the patch. See :ref:`describe_changes`
> for more details.
>
> +Note: Attaching a Fixes: tag does not subvert the stable kernel rules
> +process nor the requirement to Cc: stable@vger.kernel.org on all stable
> +patch candidates. For more information, please read
> +:ref:`Documentation/process/stable-kernel-rules.rst <stable_kernel_rules>`
Has there been a process change, or should I take it that a Fixes: tag
without Cc: stable *may* still end up being backported to stable?
BR,
Jani.
> +
> .. _the_canonical_patch_format:
>
> The canonical patch format
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2 1/1] docs: submitting-patches: Emphasise the requirement to Cc: stable when using Fixes: tag
2021-01-13 16:48 ` Jani Nikula
@ 2021-01-13 17:12 ` Lee Jones
2021-01-13 17:35 ` Jani Nikula
0 siblings, 1 reply; 7+ messages in thread
From: Lee Jones @ 2021-01-13 17:12 UTC (permalink / raw)
To: Jani Nikula; +Cc: linux-kernel, Greg Kroah-Hartman, Jonathan Corbet, linux-doc
On Wed, 13 Jan 2021, Jani Nikula wrote:
> On Wed, 13 Jan 2021, Lee Jones <lee.jones@linaro.org> wrote:
> > Clear-up any confusion surrounding the Fixes: tag with regards to the
> > need to Cc: the stable mailing list when submitting stable patch
> > candidates.
> >
> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > Cc: Jonathan Corbet <corbet@lwn.net>
> > Cc: linux-doc@vger.kernel.org
> > Signed-off-by: Lee Jones <lee.jones@linaro.org>
> > ---
> > v2:
> > - Link to the 'stable-kernel-rules' document as per Greg's request
> >
> > Documentation/process/submitting-patches.rst | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/Documentation/process/submitting-patches.rst b/Documentation/process/submitting-patches.rst
> > index 7c97ad580e7d0..7f48cccc75cdf 100644
> > --- a/Documentation/process/submitting-patches.rst
> > +++ b/Documentation/process/submitting-patches.rst
> > @@ -556,6 +556,11 @@ which stable kernel versions should receive your fix. This is the preferred
> > method for indicating a bug fixed by the patch. See :ref:`describe_changes`
> > for more details.
> >
> > +Note: Attaching a Fixes: tag does not subvert the stable kernel rules
> > +process nor the requirement to Cc: stable@vger.kernel.org on all stable
> > +patch candidates. For more information, please read
> > +:ref:`Documentation/process/stable-kernel-rules.rst <stable_kernel_rules>`
>
> Has there been a process change, or should I take it that a Fixes: tag
> without Cc: stable *may* still end up being backported to stable?
The 'process' has not changed. Cc:ing the stable mailing list has
been a requirement for years. This patch clears up the misconception
that you (and I ... and many others by all accounts) hold that the
Fixes: tag is enough.
Fixes: only works when/if Greg and/or Sasha run their magical scripts
to scan for them. By them doing so has "perpetuated a myth that this
was the proper thing to do". It's not.
Greg got fed-up of people asking that same question, so I'm fixing
that and giving him something to point to and say "RTFD".
Hope that clears things up.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2 1/1] docs: submitting-patches: Emphasise the requirement to Cc: stable when using Fixes: tag
2021-01-13 17:12 ` Lee Jones
@ 2021-01-13 17:35 ` Jani Nikula
2021-01-13 20:33 ` Lee Jones
0 siblings, 1 reply; 7+ messages in thread
From: Jani Nikula @ 2021-01-13 17:35 UTC (permalink / raw)
To: Lee Jones; +Cc: linux-kernel, Greg Kroah-Hartman, Jonathan Corbet, linux-doc
On Wed, 13 Jan 2021, Lee Jones <lee.jones@linaro.org> wrote:
> On Wed, 13 Jan 2021, Jani Nikula wrote:
>
>> On Wed, 13 Jan 2021, Lee Jones <lee.jones@linaro.org> wrote:
>> > Clear-up any confusion surrounding the Fixes: tag with regards to the
>> > need to Cc: the stable mailing list when submitting stable patch
>> > candidates.
>> >
>> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>> > Cc: Jonathan Corbet <corbet@lwn.net>
>> > Cc: linux-doc@vger.kernel.org
>> > Signed-off-by: Lee Jones <lee.jones@linaro.org>
>> > ---
>> > v2:
>> > - Link to the 'stable-kernel-rules' document as per Greg's request
>> >
>> > Documentation/process/submitting-patches.rst | 5 +++++
>> > 1 file changed, 5 insertions(+)
>> >
>> > diff --git a/Documentation/process/submitting-patches.rst b/Documentation/process/submitting-patches.rst
>> > index 7c97ad580e7d0..7f48cccc75cdf 100644
>> > --- a/Documentation/process/submitting-patches.rst
>> > +++ b/Documentation/process/submitting-patches.rst
>> > @@ -556,6 +556,11 @@ which stable kernel versions should receive your fix. This is the preferred
>> > method for indicating a bug fixed by the patch. See :ref:`describe_changes`
>> > for more details.
>> >
>> > +Note: Attaching a Fixes: tag does not subvert the stable kernel rules
>> > +process nor the requirement to Cc: stable@vger.kernel.org on all stable
>> > +patch candidates. For more information, please read
>> > +:ref:`Documentation/process/stable-kernel-rules.rst <stable_kernel_rules>`
>>
>> Has there been a process change, or should I take it that a Fixes: tag
>> without Cc: stable *may* still end up being backported to stable?
>
> The 'process' has not changed. Cc:ing the stable mailing list has
> been a requirement for years. This patch clears up the misconception
> that you (and I ... and many others by all accounts) hold that the
> Fixes: tag is enough.
>
> Fixes: only works when/if Greg and/or Sasha run their magical scripts
> to scan for them. By them doing so has "perpetuated a myth that this
> was the proper thing to do". It's not.
I held no misconception here, and we've scripted adding appropriate Cc:
stable for years along with the Fixes: tag.
There's been debate in the past whether commits with *only* Fixes:
should be automatically backported with the magic scripts at all. I
don't mean to reopen that question now, but that was what I was
referring to with the process change.
BR,
Jani.
>
> Greg got fed-up of people asking that same question, so I'm fixing
> that and giving him something to point to and say "RTFD".
>
> Hope that clears things up.
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2 1/1] docs: submitting-patches: Emphasise the requirement to Cc: stable when using Fixes: tag
2021-01-13 17:35 ` Jani Nikula
@ 2021-01-13 20:33 ` Lee Jones
0 siblings, 0 replies; 7+ messages in thread
From: Lee Jones @ 2021-01-13 20:33 UTC (permalink / raw)
To: Jani Nikula; +Cc: linux-kernel, Greg Kroah-Hartman, Jonathan Corbet, linux-doc
On Wed, 13 Jan 2021, Jani Nikula wrote:
> On Wed, 13 Jan 2021, Lee Jones <lee.jones@linaro.org> wrote:
> > On Wed, 13 Jan 2021, Jani Nikula wrote:
> >
> >> On Wed, 13 Jan 2021, Lee Jones <lee.jones@linaro.org> wrote:
> >> > Clear-up any confusion surrounding the Fixes: tag with regards to the
> >> > need to Cc: the stable mailing list when submitting stable patch
> >> > candidates.
> >> >
> >> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> >> > Cc: Jonathan Corbet <corbet@lwn.net>
> >> > Cc: linux-doc@vger.kernel.org
> >> > Signed-off-by: Lee Jones <lee.jones@linaro.org>
> >> > ---
> >> > v2:
> >> > - Link to the 'stable-kernel-rules' document as per Greg's request
> >> >
> >> > Documentation/process/submitting-patches.rst | 5 +++++
> >> > 1 file changed, 5 insertions(+)
> >> >
> >> > diff --git a/Documentation/process/submitting-patches.rst b/Documentation/process/submitting-patches.rst
> >> > index 7c97ad580e7d0..7f48cccc75cdf 100644
> >> > --- a/Documentation/process/submitting-patches.rst
> >> > +++ b/Documentation/process/submitting-patches.rst
> >> > @@ -556,6 +556,11 @@ which stable kernel versions should receive your fix. This is the preferred
> >> > method for indicating a bug fixed by the patch. See :ref:`describe_changes`
> >> > for more details.
> >> >
> >> > +Note: Attaching a Fixes: tag does not subvert the stable kernel rules
> >> > +process nor the requirement to Cc: stable@vger.kernel.org on all stable
> >> > +patch candidates. For more information, please read
> >> > +:ref:`Documentation/process/stable-kernel-rules.rst <stable_kernel_rules>`
> >>
> >> Has there been a process change, or should I take it that a Fixes: tag
> >> without Cc: stable *may* still end up being backported to stable?
> >
> > The 'process' has not changed. Cc:ing the stable mailing list has
> > been a requirement for years. This patch clears up the misconception
> > that you (and I ... and many others by all accounts) hold that the
> > Fixes: tag is enough.
> >
> > Fixes: only works when/if Greg and/or Sasha run their magical scripts
> > to scan for them. By them doing so has "perpetuated a myth that this
> > was the proper thing to do". It's not.
>
> I held no misconception here, and we've scripted adding appropriate Cc:
> stable for years along with the Fixes: tag.
>
> There's been debate in the past whether commits with *only* Fixes:
> should be automatically backported with the magic scripts at all. I
> don't mean to reopen that question now, but that was what I was
> referring to with the process change.
There's an on-going effort to pull in as many stable-worthy patches
as possible from across a plethora of varying sources. Patches with
Fixes: tags which "forgot" to Cc: the stable mailing list is just one
of those sources.
In answer to the question you didn't ask; there is still a requirement
this scenario to be catered for, IMHO.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2 1/1] docs: submitting-patches: Emphasise the requirement to Cc: stable when using Fixes: tag
2021-01-13 16:33 [PATCH v2 1/1] docs: submitting-patches: Emphasise the requirement to Cc: stable when using Fixes: tag Lee Jones
2021-01-13 16:38 ` Greg Kroah-Hartman
2021-01-13 16:48 ` Jani Nikula
@ 2021-01-18 20:09 ` Jonathan Corbet
2 siblings, 0 replies; 7+ messages in thread
From: Jonathan Corbet @ 2021-01-18 20:09 UTC (permalink / raw)
To: Lee Jones; +Cc: linux-kernel, Greg Kroah-Hartman, linux-doc
On Wed, 13 Jan 2021 16:33:15 +0000
Lee Jones <lee.jones@linaro.org> wrote:
> Clear-up any confusion surrounding the Fixes: tag with regards to the
> need to Cc: the stable mailing list when submitting stable patch
> candidates.
>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Jonathan Corbet <corbet@lwn.net>
> Cc: linux-doc@vger.kernel.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
> v2:
> - Link to the 'stable-kernel-rules' document as per Greg's request
>
> Documentation/process/submitting-patches.rst | 5 +++++
> 1 file changed, 5 insertions(+)
Applied, thanks.
jon
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2021-01-18 20:11 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-13 16:33 [PATCH v2 1/1] docs: submitting-patches: Emphasise the requirement to Cc: stable when using Fixes: tag Lee Jones
2021-01-13 16:38 ` Greg Kroah-Hartman
2021-01-13 16:48 ` Jani Nikula
2021-01-13 17:12 ` Lee Jones
2021-01-13 17:35 ` Jani Nikula
2021-01-13 20:33 ` Lee Jones
2021-01-18 20:09 ` Jonathan Corbet
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).