linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] tty: serial: replace spin_lock_irqsave by spin_lock in hard IRQ
@ 2020-11-19  9:01 Tian Tao
  2020-11-19  9:03 ` Jiri Slaby
  2020-11-20  8:23 ` Johan Hovold
  0 siblings, 2 replies; 7+ messages in thread
From: Tian Tao @ 2020-11-19  9:01 UTC (permalink / raw)
  To: gregkh, jirislaby, afaerber, manivannan.sadhasivam, linux-serial,
	linux-arm-kernel, linux-kernel

The code has been in a irq-disabled context since it is hard IRQ. There
is no necessity to do it again.

Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
---
 drivers/tty/serial/owl-uart.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/tty/serial/owl-uart.c b/drivers/tty/serial/owl-uart.c
index c149f8c3..472fdaf 100644
--- a/drivers/tty/serial/owl-uart.c
+++ b/drivers/tty/serial/owl-uart.c
@@ -251,10 +251,9 @@ static void owl_uart_receive_chars(struct uart_port *port)
 static irqreturn_t owl_uart_irq(int irq, void *dev_id)
 {
 	struct uart_port *port = dev_id;
-	unsigned long flags;
 	u32 stat;
 
-	spin_lock_irqsave(&port->lock, flags);
+	spin_lock(&port->lock);
 
 	stat = owl_uart_read(port, OWL_UART_STAT);
 
@@ -268,7 +267,7 @@ static irqreturn_t owl_uart_irq(int irq, void *dev_id)
 	stat |= OWL_UART_STAT_RIP | OWL_UART_STAT_TIP;
 	owl_uart_write(port, stat, OWL_UART_STAT);
 
-	spin_unlock_irqrestore(&port->lock, flags);
+	spin_unlock(&port->lock);
 
 	return IRQ_HANDLED;
 }
-- 
2.7.4


^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2020-11-21 15:17 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-19  9:01 [PATCH] tty: serial: replace spin_lock_irqsave by spin_lock in hard IRQ Tian Tao
2020-11-19  9:03 ` Jiri Slaby
2020-11-20  8:23 ` Johan Hovold
2020-11-20 11:25   ` tiantao (H)
2020-11-20 12:49     ` Johan Hovold
2020-11-20 20:00       ` David Laight
2020-11-21 15:17         ` Johan Hovold

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).