* [PATCH] pinctrl: remove the blank line in pinctrl_register()
@ 2020-12-07 16:11 Zhaoyu Liu
2020-12-07 18:20 ` Andy Shevchenko
0 siblings, 1 reply; 3+ messages in thread
From: Zhaoyu Liu @ 2020-12-07 16:11 UTC (permalink / raw)
To: linus.walleij, linux-gpio; +Cc: linux-kernel
Remove the blank line in pinctrl_register() to keep the code neat.
Signed-off-by: Zhaoyu Liu <zackary.liu.pro@gmail.com>
---
drivers/pinctrl/core.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/pinctrl/core.c b/drivers/pinctrl/core.c
index 3663d87f51a0..1f944685047b 100644
--- a/drivers/pinctrl/core.c
+++ b/drivers/pinctrl/core.c
@@ -2115,7 +2115,6 @@ struct pinctrl_dev *pinctrl_register(struct pinctrl_desc *pctldesc,
return ERR_PTR(error);
return pctldev;
-
}
EXPORT_SYMBOL_GPL(pinctrl_register);
--
2.29.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] pinctrl: remove the blank line in pinctrl_register()
2020-12-07 16:11 [PATCH] pinctrl: remove the blank line in pinctrl_register() Zhaoyu Liu
@ 2020-12-07 18:20 ` Andy Shevchenko
2020-12-09 9:26 ` Linus Walleij
0 siblings, 1 reply; 3+ messages in thread
From: Andy Shevchenko @ 2020-12-07 18:20 UTC (permalink / raw)
To: Zhaoyu Liu
Cc: Linus Walleij, open list:GPIO SUBSYSTEM, Linux Kernel Mailing List
On Mon, Dec 7, 2020 at 6:13 PM Zhaoyu Liu <zackary.liu.pro@gmail.com> wrote:
>
> Remove the blank line in pinctrl_register() to keep the code neat.
Probably you want to apply the same for other drivers at once?
% git grep -n -B1 -w ^} -- drivers/pinctrl/ | grep -C1 '[0-9]-$' | less
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] pinctrl: remove the blank line in pinctrl_register()
2020-12-07 18:20 ` Andy Shevchenko
@ 2020-12-09 9:26 ` Linus Walleij
0 siblings, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2020-12-09 9:26 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Zhaoyu Liu, open list:GPIO SUBSYSTEM, Linux Kernel Mailing List
On Mon, Dec 7, 2020 at 7:20 PM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
> On Mon, Dec 7, 2020 at 6:13 PM Zhaoyu Liu <zackary.liu.pro@gmail.com> wrote:
> >
> > Remove the blank line in pinctrl_register() to keep the code neat.
>
> Probably you want to apply the same for other drivers at once?
>
> % git grep -n -B1 -w ^} -- drivers/pinctrl/ | grep -C1 '[0-9]-$' | less
I agree with Andy, a patch should be "one technical step" so just sweep
the entire subsystem if you wanna do this cosmetic.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-12-09 9:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-07 16:11 [PATCH] pinctrl: remove the blank line in pinctrl_register() Zhaoyu Liu
2020-12-07 18:20 ` Andy Shevchenko
2020-12-09 9:26 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).