From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: kholk11@gmail.com
Cc: agross@kernel.org, sboyd@kernel.org, marijns95@gmail.com,
konradybcio@gmail.com, martin.botka1@gmail.com,
linux-arm-msm@vger.kernel.org, phone-devel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/5] clk: qcom: mmcc-sdm660: Add MDP clock source CXC to MDSS GDSC
Date: Fri, 4 Dec 2020 23:08:41 -0600 [thread overview]
Message-ID: <X8sV2UOipnhP1Y78@builder.lan> (raw)
In-Reply-To: <20200926130306.13843-4-kholk11@gmail.com>
On Sat 26 Sep 08:03 CDT 2020, kholk11@gmail.com wrote:
> From: AngeloGioacchino Del Regno <kholk11@gmail.com>
>
> It is required for optimal performance and to avoid MDP stalls to
> retain mem/periph on GDSC enablement: to achieve this, let's add
> the required CXC to the MDSS GDSC.
>
Can you please explain how you came to this conclusion, I don't see the
reference to the MDP_CLK_SRC in the downstream kernel.
Thanks,
Bjorn
> Signed-off-by: AngeloGioacchino Del Regno <kholk11@gmail.com>
> ---
> drivers/clk/qcom/mmcc-sdm660.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/clk/qcom/mmcc-sdm660.c b/drivers/clk/qcom/mmcc-sdm660.c
> index 234aca7c873b..7b1384cf8506 100644
> --- a/drivers/clk/qcom/mmcc-sdm660.c
> +++ b/drivers/clk/qcom/mmcc-sdm660.c
> @@ -2572,6 +2572,8 @@ static struct gdsc mdss_gdsc = {
> .pd = {
> .name = "mdss",
> },
> + .cxcs = (unsigned int []){ 0x2040 },
> + .cxc_count = 1,
> .pwrsts = PWRSTS_OFF_ON,
> };
>
> --
> 2.28.0
>
next prev parent reply other threads:[~2020-12-05 5:09 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-26 13:03 [PATCH 0/5] SDM630/660 Multimedia and GPU clock controllers kholk11
2020-09-26 13:03 ` [PATCH 1/5] clk: qcom: Add SDM660 Multimedia Clock Controller (MMCC) driver kholk11
2020-09-26 13:23 ` Martin Botka
2020-09-30 20:47 ` kernel test robot
2020-10-13 14:51 ` Martin Botka
2020-10-13 15:01 ` Martin Botka
2020-12-05 4:59 ` Bjorn Andersson
2020-09-26 13:03 ` [PATCH 2/5] dt-bindings: clock: Add support for the SDM630 and SDM660 mmcc kholk11
2020-09-26 13:03 ` [PATCH 3/5] clk: qcom: mmcc-sdm660: Add MDP clock source CXC to MDSS GDSC kholk11
2020-12-05 5:08 ` Bjorn Andersson [this message]
2021-01-09 18:39 ` AngeloGioacchino Del Regno
2020-09-26 13:03 ` [PATCH 4/5] clk: qcom: Add SDM660 GPU Clock Controller (GPUCC) driver kholk11
2020-09-26 13:29 ` Martin Botka
2020-09-30 20:46 ` kernel test robot
2020-09-30 21:58 ` AngeloGioacchino Del Regno
2020-10-02 5:39 ` Philip Li
2020-12-05 5:16 ` Bjorn Andersson
2020-09-26 13:03 ` [PATCH 5/5] dt-bindings: clock: Add QCOM SDM630 and SDM660 graphics clock bindings kholk11
2020-09-26 13:30 ` Martin Botka
2020-12-05 5:14 ` Bjorn Andersson
2020-12-04 18:16 ` [PATCH 0/5] SDM630/660 Multimedia and GPU clock controllers AngeloGioacchino Del Regno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X8sV2UOipnhP1Y78@builder.lan \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=kholk11@gmail.com \
--cc=konradybcio@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijns95@gmail.com \
--cc=martin.botka1@gmail.com \
--cc=phone-devel@vger.kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).