* [PATCH] phy: cadence-torrent: Fix error code in cdns_torrent_phy_probe()
@ 2020-12-17 11:04 Dan Carpenter
2021-01-13 12:01 ` Vinod Koul
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2020-12-17 11:04 UTC (permalink / raw)
To: Kishon Vijay Abraham I, Swapnil Jakhade
Cc: Vinod Koul, Yuti Amonkar, linux-kernel, kernel-janitors
This error path should return -EINVAL, but currently it returns
success.
Fixes: d09945eacad0 ("phy: cadence-torrent: Check total lane count for all subnodes is within limit")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/phy/cadence/phy-cadence-torrent.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/phy/cadence/phy-cadence-torrent.c b/drivers/phy/cadence/phy-cadence-torrent.c
index f310e15d94cb..591a15834b48 100644
--- a/drivers/phy/cadence/phy-cadence-torrent.c
+++ b/drivers/phy/cadence/phy-cadence-torrent.c
@@ -2298,6 +2298,7 @@ static int cdns_torrent_phy_probe(struct platform_device *pdev)
if (total_num_lanes > MAX_NUM_LANES) {
dev_err(dev, "Invalid lane configuration\n");
+ ret = -EINVAL;
goto put_lnk_rst;
}
--
2.29.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] phy: cadence-torrent: Fix error code in cdns_torrent_phy_probe()
2020-12-17 11:04 [PATCH] phy: cadence-torrent: Fix error code in cdns_torrent_phy_probe() Dan Carpenter
@ 2021-01-13 12:01 ` Vinod Koul
0 siblings, 0 replies; 2+ messages in thread
From: Vinod Koul @ 2021-01-13 12:01 UTC (permalink / raw)
To: Dan Carpenter
Cc: Kishon Vijay Abraham I, Swapnil Jakhade, Yuti Amonkar,
linux-kernel, kernel-janitors
On 17-12-20, 14:04, Dan Carpenter wrote:
> This error path should return -EINVAL, but currently it returns
> success.
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-01-13 12:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-17 11:04 [PATCH] phy: cadence-torrent: Fix error code in cdns_torrent_phy_probe() Dan Carpenter
2021-01-13 12:01 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).