From: James Morris <jmorris@redhat.com>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org,
Stephen Smalley <sds@epoch.ncsc.mil>,
Kaigai Kohei <kaigai@ak.jp.nec.com>
Subject: Re: 2.6.10-rc2-mm1 - SELinux atomic_dec_and_test() bug
Date: Tue, 16 Nov 2004 11:48:10 -0500 (EST) [thread overview]
Message-ID: <Xine.LNX.4.44.0411161136080.26462-100000@thoron.boston.redhat.com> (raw)
In-Reply-To: <20041116014213.2128aca9.akpm@osdl.org>
Atomic underflow debugging in this kernel exposed a bug in the AVC RCU
code, fix below. The effect of this bug would be delayed node
reclamation.
Signed-off-by: James Morris <jmorris@redhat.com>
---
diff -purN -X dontdiff linux-2.6.10-rc2-mm1.o/security/selinux/avc.c linux-2.6.10-rc2-mm1.w/security/selinux/avc.c
--- linux-2.6.10-rc2-mm1.o/security/selinux/avc.c 2004-11-16 10:57:16.000000000 -0500
+++ linux-2.6.10-rc2-mm1.w/security/selinux/avc.c 2004-11-16 11:27:19.000000000 -0500
@@ -269,7 +269,7 @@ static inline int avc_reclaim_node(void)
continue;
list_for_each_entry(node, &avc_cache.slots[hvalue], list) {
- if (!atomic_dec_and_test(&node->ae.used)) {
+ if (atomic_dec_and_test(&node->ae.used)) {
/* Recently Unused */
avc_node_delete(node);
avc_cache_stats_incr(reclaims);
next prev parent reply other threads:[~2004-11-16 16:52 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-16 9:42 2.6.10-rc2-mm1 Andrew Morton
2004-11-16 16:48 ` James Morris [this message]
2004-11-16 21:30 ` 2.6.10-rc2-mm1 Lee Revell
2004-11-17 2:22 ` 2.6.10-rc2-mm1 Andrew Morton
2004-11-17 2:28 ` 2.6.10-rc2-mm1 Lee Revell
2004-11-17 3:21 ` 2.6.10-rc2-mm1 Dave Airlie
2004-11-17 3:23 ` 2.6.10-rc2-mm1 Lee Revell
2004-11-17 22:08 ` 2.6.10-rc2-mm1 Dave Airlie
2004-11-16 21:38 ` 2.6.10-rc2-mm1 Lee Revell
2004-11-17 11:04 ` 2.6.10-rc2-mm1 (8139too interrupt) Ralf Gerbig
2004-11-17 19:06 ` Andrew Morton
2004-11-17 22:18 ` Ralf Gerbig
2004-11-18 20:46 ` Ralf Gerbig
2004-11-19 7:48 ` Dave Airlie
2004-11-19 8:12 ` Dave Airlie
2004-11-23 7:55 ` Dave Airlie
2004-11-17 11:32 ` 2.6.10-rc2-mm1 William Lee Irwin III
2004-11-17 12:34 ` 2.6.10-rc2-mm1 William Lee Irwin III
2004-11-17 12:56 ` 2.6.10-rc2-mm1 William Lee Irwin III
2004-11-18 10:22 ` 2.6.10-rc2-mm1 William Lee Irwin III
2004-11-18 10:31 ` 2.6.10-rc2-mm1 Andrew Morton
2004-11-19 7:57 ` 2.6.10-rc2-mm1 William Lee Irwin III
2004-11-17 20:53 ` 2.6.10-rc2-mm1 Grzegorz Piotr Jaskiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Xine.LNX.4.44.0411161136080.26462-100000@thoron.boston.redhat.com \
--to=jmorris@redhat.com \
--cc=akpm@osdl.org \
--cc=kaigai@ak.jp.nec.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sds@epoch.ncsc.mil \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).