linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] net: lan743x: LAN743X selects FIXED_PHY to resolve a link error
@ 2023-02-19 15:03 Tom Rix
  2023-02-19 18:16 ` Simon Horman
  0 siblings, 1 reply; 9+ messages in thread
From: Tom Rix @ 2023-02-19 15:03 UTC (permalink / raw)
  To: davem, edumazet, kuba, pabeni, steen.hegelund
  Cc: netdev, linux-kernel, Tom Rix

A rand config causes this link error
drivers/net/ethernet/microchip/lan743x_main.o: In function `lan743x_netdev_open':
drivers/net/ethernet/microchip/lan743x_main.c:1512: undefined reference to `fixed_phy_register'

lan743x_netdev_open is controlled by LAN743X
fixed_phy_register is controlled by FIXED_PHY

So LAN743X should also select FIXED_PHY

Signed-off-by: Tom Rix <trix@redhat.com>
---
 drivers/net/ethernet/microchip/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/microchip/Kconfig b/drivers/net/ethernet/microchip/Kconfig
index 24c994baad13..43ba71e82260 100644
--- a/drivers/net/ethernet/microchip/Kconfig
+++ b/drivers/net/ethernet/microchip/Kconfig
@@ -47,6 +47,7 @@ config LAN743X
 	depends on PCI
 	depends on PTP_1588_CLOCK_OPTIONAL
 	select PHYLIB
+	select FIXED_PHY
 	select CRC16
 	select CRC32
 	help
-- 
2.27.0


^ permalink raw reply related	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2023-02-27 12:05 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-19 15:03 [PATCH] net: lan743x: LAN743X selects FIXED_PHY to resolve a link error Tom Rix
2023-02-19 18:16 ` Simon Horman
2023-02-20  1:19   ` Andrew Lunn
2023-02-20  6:46     ` Simon Horman
2023-02-21  2:29       ` Andrew Lunn
2023-02-21 16:20         ` Simon Horman
2023-02-26 15:15           ` Tom Rix
2023-02-27  8:37             ` Arnd Bergmann
2023-02-27 12:05             ` Simon Horman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).