* [PATCH] firmware: coreboot: Remove GOOGLE_COREBOOT_TABLE_ACPI/OF Kconfig entries
@ 2023-02-07 16:12 Douglas Anderson
2023-02-07 16:16 ` Guenter Roeck
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: Douglas Anderson @ 2023-02-07 16:12 UTC (permalink / raw)
To: Benson Leung, Greg Kroah-Hartman
Cc: Julius Werner, David Gow, Jack Rosenthal, chrome-platform,
Stephen Boyd, Douglas Anderson, Guenter Roeck, linux-kernel
Ever since commit a28aad66da8b ("firmware: coreboot: Collapse platform
drivers into bus core") the Kconfig entries GOOGLE_COREBOOT_TABLE_OF
and GOOGLE_COREBOOT_TABLE_ACPI have been dead. They have no "help"
text and thus aren't user choosable. They also aren't "select"ed by
anything. They also control the compilation of no code.
Let's remove them.
Fixes: a28aad66da8b ("firmware: coreboot: Collapse platform drivers into bus core")
Signed-off-by: Douglas Anderson <dianders@chromium.org>
---
drivers/firmware/google/Kconfig | 8 --------
1 file changed, 8 deletions(-)
diff --git a/drivers/firmware/google/Kconfig b/drivers/firmware/google/Kconfig
index 9f190eab43ed..1bc7cbf2f65d 100644
--- a/drivers/firmware/google/Kconfig
+++ b/drivers/firmware/google/Kconfig
@@ -44,14 +44,6 @@ config GOOGLE_COREBOOT_TABLE
device tree node /firmware/coreboot.
If unsure say N.
-config GOOGLE_COREBOOT_TABLE_ACPI
- tristate
- select GOOGLE_COREBOOT_TABLE
-
-config GOOGLE_COREBOOT_TABLE_OF
- tristate
- select GOOGLE_COREBOOT_TABLE
-
config GOOGLE_MEMCONSOLE
tristate
depends on GOOGLE_MEMCONSOLE_X86_LEGACY || GOOGLE_MEMCONSOLE_COREBOOT
--
2.39.1.519.gcb327c4b5f-goog
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] firmware: coreboot: Remove GOOGLE_COREBOOT_TABLE_ACPI/OF Kconfig entries
2023-02-07 16:12 [PATCH] firmware: coreboot: Remove GOOGLE_COREBOOT_TABLE_ACPI/OF Kconfig entries Douglas Anderson
@ 2023-02-07 16:16 ` Guenter Roeck
2023-02-07 18:02 ` Jack Rosenthal
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Guenter Roeck @ 2023-02-07 16:16 UTC (permalink / raw)
To: Douglas Anderson
Cc: Benson Leung, Greg Kroah-Hartman, Julius Werner, David Gow,
Jack Rosenthal, chrome-platform, Stephen Boyd, Guenter Roeck,
linux-kernel
On Tue, Feb 7, 2023 at 8:12 AM Douglas Anderson <dianders@chromium.org> wrote:
>
> Ever since commit a28aad66da8b ("firmware: coreboot: Collapse platform
> drivers into bus core") the Kconfig entries GOOGLE_COREBOOT_TABLE_OF
> and GOOGLE_COREBOOT_TABLE_ACPI have been dead. They have no "help"
> text and thus aren't user choosable. They also aren't "select"ed by
> anything. They also control the compilation of no code.
>
> Let's remove them.
>
> Fixes: a28aad66da8b ("firmware: coreboot: Collapse platform drivers into bus core")
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Guenter Roeck <groeck@chromium.org>
> ---
>
> drivers/firmware/google/Kconfig | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/drivers/firmware/google/Kconfig b/drivers/firmware/google/Kconfig
> index 9f190eab43ed..1bc7cbf2f65d 100644
> --- a/drivers/firmware/google/Kconfig
> +++ b/drivers/firmware/google/Kconfig
> @@ -44,14 +44,6 @@ config GOOGLE_COREBOOT_TABLE
> device tree node /firmware/coreboot.
> If unsure say N.
>
> -config GOOGLE_COREBOOT_TABLE_ACPI
> - tristate
> - select GOOGLE_COREBOOT_TABLE
> -
> -config GOOGLE_COREBOOT_TABLE_OF
> - tristate
> - select GOOGLE_COREBOOT_TABLE
> -
> config GOOGLE_MEMCONSOLE
> tristate
> depends on GOOGLE_MEMCONSOLE_X86_LEGACY || GOOGLE_MEMCONSOLE_COREBOOT
> --
> 2.39.1.519.gcb327c4b5f-goog
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] firmware: coreboot: Remove GOOGLE_COREBOOT_TABLE_ACPI/OF Kconfig entries
2023-02-07 16:12 [PATCH] firmware: coreboot: Remove GOOGLE_COREBOOT_TABLE_ACPI/OF Kconfig entries Douglas Anderson
2023-02-07 16:16 ` Guenter Roeck
@ 2023-02-07 18:02 ` Jack Rosenthal
2023-02-08 20:39 ` Stephen Boyd
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Jack Rosenthal @ 2023-02-07 18:02 UTC (permalink / raw)
To: Douglas Anderson
Cc: Benson Leung, Greg Kroah-Hartman, Julius Werner, David Gow,
chrome-platform, Stephen Boyd, Guenter Roeck, linux-kernel
On 2023-02-07 at 08:12 -0800, Douglas Anderson wrote:
> Ever since commit a28aad66da8b ("firmware: coreboot: Collapse platform
> drivers into bus core") the Kconfig entries GOOGLE_COREBOOT_TABLE_OF
> and GOOGLE_COREBOOT_TABLE_ACPI have been dead. They have no "help"
> text and thus aren't user choosable. They also aren't "select"ed by
> anything. They also control the compilation of no code.
>
> Let's remove them.
>
> Fixes: a28aad66da8b ("firmware: coreboot: Collapse platform drivers into bus core")
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
> ---
>
> drivers/firmware/google/Kconfig | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/drivers/firmware/google/Kconfig b/drivers/firmware/google/Kconfig
> index 9f190eab43ed..1bc7cbf2f65d 100644
> --- a/drivers/firmware/google/Kconfig
> +++ b/drivers/firmware/google/Kconfig
> @@ -44,14 +44,6 @@ config GOOGLE_COREBOOT_TABLE
> device tree node /firmware/coreboot.
> If unsure say N.
>
> -config GOOGLE_COREBOOT_TABLE_ACPI
> - tristate
> - select GOOGLE_COREBOOT_TABLE
> -
> -config GOOGLE_COREBOOT_TABLE_OF
> - tristate
> - select GOOGLE_COREBOOT_TABLE
> -
> config GOOGLE_MEMCONSOLE
> tristate
> depends on GOOGLE_MEMCONSOLE_X86_LEGACY || GOOGLE_MEMCONSOLE_COREBOOT
> --
> 2.39.1.519.gcb327c4b5f-goog
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] firmware: coreboot: Remove GOOGLE_COREBOOT_TABLE_ACPI/OF Kconfig entries
2023-02-07 16:12 [PATCH] firmware: coreboot: Remove GOOGLE_COREBOOT_TABLE_ACPI/OF Kconfig entries Douglas Anderson
2023-02-07 16:16 ` Guenter Roeck
2023-02-07 18:02 ` Jack Rosenthal
@ 2023-02-08 20:39 ` Stephen Boyd
2023-03-06 2:43 ` patchwork-bot+chrome-platform
2023-03-06 2:53 ` patchwork-bot+chrome-platform
4 siblings, 0 replies; 6+ messages in thread
From: Stephen Boyd @ 2023-02-08 20:39 UTC (permalink / raw)
To: Benson Leung, Douglas Anderson, Greg Kroah-Hartman
Cc: Julius Werner, David Gow, Jack Rosenthal, chrome-platform,
Guenter Roeck, linux-kernel
Quoting Douglas Anderson (2023-02-07 08:12:00)
> Ever since commit a28aad66da8b ("firmware: coreboot: Collapse platform
> drivers into bus core") the Kconfig entries GOOGLE_COREBOOT_TABLE_OF
> and GOOGLE_COREBOOT_TABLE_ACPI have been dead. They have no "help"
> text and thus aren't user choosable. They also aren't "select"ed by
> anything. They also control the compilation of no code.
>
> Let's remove them.
>
> Fixes: a28aad66da8b ("firmware: coreboot: Collapse platform drivers into bus core")
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> ---
Acked-by: Stephen Boyd <swboyd@chromium.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] firmware: coreboot: Remove GOOGLE_COREBOOT_TABLE_ACPI/OF Kconfig entries
2023-02-07 16:12 [PATCH] firmware: coreboot: Remove GOOGLE_COREBOOT_TABLE_ACPI/OF Kconfig entries Douglas Anderson
` (2 preceding siblings ...)
2023-02-08 20:39 ` Stephen Boyd
@ 2023-03-06 2:43 ` patchwork-bot+chrome-platform
2023-03-06 2:53 ` patchwork-bot+chrome-platform
4 siblings, 0 replies; 6+ messages in thread
From: patchwork-bot+chrome-platform @ 2023-03-06 2:43 UTC (permalink / raw)
To: Douglas Anderson
Cc: bleung, gregkh, jwerner, davidgow, jrosenth, chrome-platform,
swboyd, groeck, linux-kernel
Hello:
This patch was applied to chrome-platform/linux.git (for-kernelci)
by Greg Kroah-Hartman <gregkh@linuxfoundation.org>:
On Tue, 7 Feb 2023 08:12:00 -0800 you wrote:
> Ever since commit a28aad66da8b ("firmware: coreboot: Collapse platform
> drivers into bus core") the Kconfig entries GOOGLE_COREBOOT_TABLE_OF
> and GOOGLE_COREBOOT_TABLE_ACPI have been dead. They have no "help"
> text and thus aren't user choosable. They also aren't "select"ed by
> anything. They also control the compilation of no code.
>
> Let's remove them.
>
> [...]
Here is the summary with links:
- firmware: coreboot: Remove GOOGLE_COREBOOT_TABLE_ACPI/OF Kconfig entries
https://git.kernel.org/chrome-platform/c/e42af72223fd
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] firmware: coreboot: Remove GOOGLE_COREBOOT_TABLE_ACPI/OF Kconfig entries
2023-02-07 16:12 [PATCH] firmware: coreboot: Remove GOOGLE_COREBOOT_TABLE_ACPI/OF Kconfig entries Douglas Anderson
` (3 preceding siblings ...)
2023-03-06 2:43 ` patchwork-bot+chrome-platform
@ 2023-03-06 2:53 ` patchwork-bot+chrome-platform
4 siblings, 0 replies; 6+ messages in thread
From: patchwork-bot+chrome-platform @ 2023-03-06 2:53 UTC (permalink / raw)
To: Douglas Anderson
Cc: bleung, gregkh, jwerner, davidgow, jrosenth, chrome-platform,
swboyd, groeck, linux-kernel
Hello:
This patch was applied to chrome-platform/linux.git (for-next)
by Greg Kroah-Hartman <gregkh@linuxfoundation.org>:
On Tue, 7 Feb 2023 08:12:00 -0800 you wrote:
> Ever since commit a28aad66da8b ("firmware: coreboot: Collapse platform
> drivers into bus core") the Kconfig entries GOOGLE_COREBOOT_TABLE_OF
> and GOOGLE_COREBOOT_TABLE_ACPI have been dead. They have no "help"
> text and thus aren't user choosable. They also aren't "select"ed by
> anything. They also control the compilation of no code.
>
> Let's remove them.
>
> [...]
Here is the summary with links:
- firmware: coreboot: Remove GOOGLE_COREBOOT_TABLE_ACPI/OF Kconfig entries
https://git.kernel.org/chrome-platform/c/e42af72223fd
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-03-06 2:53 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-07 16:12 [PATCH] firmware: coreboot: Remove GOOGLE_COREBOOT_TABLE_ACPI/OF Kconfig entries Douglas Anderson
2023-02-07 16:16 ` Guenter Roeck
2023-02-07 18:02 ` Jack Rosenthal
2023-02-08 20:39 ` Stephen Boyd
2023-03-06 2:43 ` patchwork-bot+chrome-platform
2023-03-06 2:53 ` patchwork-bot+chrome-platform
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).