* linux-next: Signed-off-by missing for commit in the perf tree
@ 2022-10-30 20:45 Stephen Rothwell
2022-10-31 14:04 ` Arnaldo Carvalho de Melo
0 siblings, 1 reply; 9+ messages in thread
From: Stephen Rothwell @ 2022-10-30 20:45 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 239 bytes --]
Hi all,
Commit
a2879339be71 ("perf bpf: No need to include headers just use forward declarations")
is missing a Signed-off-by from its author and committer.
Just a misspelt "Signed-off-by".
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: linux-next: Signed-off-by missing for commit in the perf tree
2022-10-30 20:45 linux-next: Signed-off-by missing for commit in the perf tree Stephen Rothwell
@ 2022-10-31 14:04 ` Arnaldo Carvalho de Melo
0 siblings, 0 replies; 9+ messages in thread
From: Arnaldo Carvalho de Melo @ 2022-10-31 14:04 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Arnaldo Carvalho de Melo, Linux Kernel Mailing List,
Linux Next Mailing List
Em Mon, Oct 31, 2022 at 07:45:02AM +1100, Stephen Rothwell escreveu:
> Hi all,
>
> Commit
>
> a2879339be71 ("perf bpf: No need to include headers just use forward declarations")
>
> is missing a Signed-off-by from its author and committer.
>
> Just a misspelt "Signed-off-by".
Ouch, I'll fix it and force push.
- Arnaldo
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: linux-next: Signed-off-by missing for commit in the perf tree
2023-12-05 22:14 Stephen Rothwell
@ 2023-12-06 12:33 ` Arnaldo Carvalho de Melo
0 siblings, 0 replies; 9+ messages in thread
From: Arnaldo Carvalho de Melo @ 2023-12-06 12:33 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Arnaldo Carvalho de Melo, Namhyung Kim, Ian Rogers,
Linux Kernel Mailing List, Linux Next Mailing List
Em Wed, Dec 06, 2023 at 09:14:33AM +1100, Stephen Rothwell escreveu:
> Commit
> 08b953508560 ("perf evsel: Fallback to "task-clock" when not system wide")
> is missing a Signed-off-by from its author.
Thanks for the report, fixed, the issue was that Ian's S-o-B was after a
--- line and thus git-am chopped it up :-\
===============================================================================
When the cycles event isn't available evsel will fallback to the
cpu-clock software event. task-clock is similar to cpu-clock but only
runs when the process is running. Falling back to cpu-clock when not
system wide leads to confusion, by falling back to task-clock it is
hoped the confusion is less.
Pass the target to determine if task-clock is more appropriate. Update
a nearby comment and debug string for the change.
---
v2. Use target__has_cpu as suggested by Namhyung.
https://lpc.events/event/17/contributions/1556/
Signed-off-by: Ian Rogers <irogers@google.com>
---
tools/perf/builtin-record.c | 2 +-
tools/perf/builtin-stat.c | 2 +-
tools/perf/builtin-top.c | 2 +-
tools/perf/util/evsel.c | 18 ++++++++++--------
tools/perf/util/evsel.h | 3 ++-
5 files changed, 15 insertions(+), 12 deletions(-
--
===============================================================================
I'll check my pre-commit hooks to see why this didn't get flagged...
- Arnaldo
^ permalink raw reply [flat|nested] 9+ messages in thread
* linux-next: Signed-off-by missing for commit in the perf tree
@ 2023-12-05 22:14 Stephen Rothwell
2023-12-06 12:33 ` Arnaldo Carvalho de Melo
0 siblings, 1 reply; 9+ messages in thread
From: Stephen Rothwell @ 2023-12-05 22:14 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo, Namhyung Kim
Cc: Ian Rogers, Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 180 bytes --]
Hi all,
Commit
08b953508560 ("perf evsel: Fallback to "task-clock" when not system wide")
is missing a Signed-off-by from its author.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: linux-next: Signed-off-by missing for commit in the perf tree
2023-09-14 21:26 Stephen Rothwell
@ 2023-09-15 2:50 ` Namhyung Kim
0 siblings, 0 replies; 9+ messages in thread
From: Namhyung Kim @ 2023-09-15 2:50 UTC (permalink / raw)
To: Stephen Rothwell, Veronika Molnarova
Cc: Arnaldo Carvalho de Melo, Linux Kernel Mailing List,
Linux Next Mailing List
Hello Stephen,
On Thu, Sep 14, 2023 at 2:26 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> Commits
>
> 19d8ab40f89b ("perf test stat+shadow_stat.sh: Add threshold for rounding errors")
> 0c4ded92280b ("perf test lock_contention.sh: Skip test if the number of CPUs is low")
>
> are missing a Signed-off-by from their author.
Thanks for the notice. As they're recently added, I think I can replace them
with new commits with s-o-b from the author and force-push.
Veronika, can you resend those two commits with your Sign-off?
Thanks,
Namhyung
^ permalink raw reply [flat|nested] 9+ messages in thread
* linux-next: Signed-off-by missing for commit in the perf tree
@ 2023-09-14 21:26 Stephen Rothwell
2023-09-15 2:50 ` Namhyung Kim
0 siblings, 1 reply; 9+ messages in thread
From: Stephen Rothwell @ 2023-09-14 21:26 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo, Namhyung Kim
Cc: Veronika Molnarova, Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 280 bytes --]
Hi all,
Commits
19d8ab40f89b ("perf test stat+shadow_stat.sh: Add threshold for rounding errors")
0c4ded92280b ("perf test lock_contention.sh: Skip test if the number of CPUs is low")
are missing a Signed-off-by from their author.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: linux-next: Signed-off-by missing for commit in the perf tree
2022-12-13 21:36 ` Arnaldo Carvalho de Melo
@ 2022-12-13 21:40 ` Ian Rogers
0 siblings, 0 replies; 9+ messages in thread
From: Ian Rogers @ 2022-12-13 21:40 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: Stephen Rothwell, Linux Kernel Mailing List, Linux Next Mailing List
On Tue, Dec 13, 2022 at 1:37 PM Arnaldo Carvalho de Melo
<arnaldo.melo@gmail.com> wrote:
>
>
>
> On December 13, 2022 6:34:34 PM GMT-03:00, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >Hi all,
> >
> >Commit
> >
> > 9e03ed43cd4f ("perf stat: Check existence of os->prefix, fixing a segfault")
> >
> >is missing a Signed-off-by from its author.
>
> Thanks, I'll fix this as well.
>
> - Arnaldo
Happy any which way this is resolved. In case it is useful:
Signed-off-by: Ian Rogers <irogers@google.com>
Thanks,
Ian
> >
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: linux-next: Signed-off-by missing for commit in the perf tree
2022-12-13 21:34 Stephen Rothwell
@ 2022-12-13 21:36 ` Arnaldo Carvalho de Melo
2022-12-13 21:40 ` Ian Rogers
0 siblings, 1 reply; 9+ messages in thread
From: Arnaldo Carvalho de Melo @ 2022-12-13 21:36 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Ian Rogers, Linux Kernel Mailing List, Linux Next Mailing List
On December 13, 2022 6:34:34 PM GMT-03:00, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>Hi all,
>
>Commit
>
> 9e03ed43cd4f ("perf stat: Check existence of os->prefix, fixing a segfault")
>
>is missing a Signed-off-by from its author.
Thanks, I'll fix this as well.
- Arnaldo
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* linux-next: Signed-off-by missing for commit in the perf tree
@ 2022-12-13 21:34 Stephen Rothwell
2022-12-13 21:36 ` Arnaldo Carvalho de Melo
0 siblings, 1 reply; 9+ messages in thread
From: Stephen Rothwell @ 2022-12-13 21:34 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: Ian Rogers, Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 182 bytes --]
Hi all,
Commit
9e03ed43cd4f ("perf stat: Check existence of os->prefix, fixing a segfault")
is missing a Signed-off-by from its author.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2023-12-06 12:33 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-30 20:45 linux-next: Signed-off-by missing for commit in the perf tree Stephen Rothwell
2022-10-31 14:04 ` Arnaldo Carvalho de Melo
2022-12-13 21:34 Stephen Rothwell
2022-12-13 21:36 ` Arnaldo Carvalho de Melo
2022-12-13 21:40 ` Ian Rogers
2023-09-14 21:26 Stephen Rothwell
2023-09-15 2:50 ` Namhyung Kim
2023-12-05 22:14 Stephen Rothwell
2023-12-06 12:33 ` Arnaldo Carvalho de Melo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).